From: Stephen Hemminger <stephen@networkplumber.org>
To: Gregory Etelson <getelson@nvidia.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3] app/testpmd: fix interactive mode with no ports
Date: Thu, 19 Jan 2023 09:28:11 -0800 [thread overview]
Message-ID: <20230119092811.3826b869@hermes.local> (raw)
In-Reply-To: <20230119172312.15418-1-getelson@nvidia.com>
On Thu, 19 Jan 2023 19:23:12 +0200
Gregory Etelson <getelson@nvidia.com> wrote:
> + if (!no_device_start && start_port(RTE_PORT_ALL) != 0) {
> + fprintf(stderr, "Start ports failed\n");
> + if (!interactive) {
> + rte_eal_cleanup();
> + rte_exit(EXIT_FAILURE, "Start ports failed\n");
> + }
> + }
Ok, but you are printing message twice now.
next prev parent reply other threads:[~2023-01-19 17:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221109165410.1326-1-getelson@nvidia.com>
2022-11-09 17:09 ` [PATCH v2] " Gregory Etelson
2022-11-16 4:23 ` Singh, Aman Deep
2023-01-19 15:09 ` Ferruh Yigit
2023-01-19 17:16 ` [PATCH v3] " Gregory Etelson
2023-01-19 17:23 ` Gregory Etelson
2023-01-19 17:28 ` Stephen Hemminger [this message]
2023-01-19 17:45 ` [PATCH v4] " Gregory Etelson
2023-01-27 23:04 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230119092811.3826b869@hermes.local \
--to=stephen@networkplumber.org \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=getelson@nvidia.com \
--cc=stable@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).