From: Chengwen Feng <fengchengwen@huawei.com>
To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>,
<andrew.rybchenko@oktetlabs.ru>
Cc: <dev@dpdk.org>, <ciara.power@intel.com>, <kevin.laatz@intel.com>,
<bruce.richardson@intel.com>
Subject: [PATCH v4 5/5] ethdev: telemetry xstats support hide zero
Date: Fri, 20 Jan 2023 03:34:56 +0000 [thread overview]
Message-ID: <20230120033456.29710-6-fengchengwen@huawei.com> (raw)
In-Reply-To: <20230120033456.29710-1-fengchengwen@huawei.com>
The number of xstats may be large, after the hide zero option is added,
only non-zero values can be displayed.
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
lib/ethdev/rte_ethdev.c | 23 +++++++++++++++++------
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index ebcb05b523..a8ba3f2280 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -5870,20 +5870,28 @@ eth_dev_handle_port_xstats(const char *cmd __rte_unused,
{
struct rte_eth_xstat *eth_xstats;
struct rte_eth_xstat_name *xstat_names;
+ char *end_param, *hide_param;
int port_id, num_xstats;
+ int hide_zero = 0;
int i, ret;
- char *end_param;
if (params == NULL || strlen(params) == 0 || !isdigit(*params))
return -1;
port_id = strtoul(params, &end_param, 0);
- if (*end_param != '\0')
- RTE_ETHDEV_LOG(NOTICE,
- "Extra parameters passed to ethdev telemetry command, ignoring\n");
if (!rte_eth_dev_is_valid_port(port_id))
return -1;
+ if (*end_param != '\0') {
+ hide_param = strtok(end_param, ",");
+ if (hide_param == NULL || strlen(hide_param) == 0 || !isdigit(*hide_param))
+ return -EINVAL;
+ hide_zero = strtoul(hide_param, &end_param, 0);
+ if (*end_param != '\0')
+ RTE_ETHDEV_LOG(NOTICE,
+ "Extra parameters passed to ethdev telemetry command, ignoring\n");
+ }
+
num_xstats = rte_eth_xstats_get(port_id, NULL, 0);
if (num_xstats < 0)
return -1;
@@ -5908,9 +5916,12 @@ eth_dev_handle_port_xstats(const char *cmd __rte_unused,
}
rte_tel_data_start_dict(d);
- for (i = 0; i < num_xstats; i++)
+ for (i = 0; i < num_xstats; i++) {
+ if (hide_zero != 0 && eth_xstats[i].value == 0)
+ continue;
rte_tel_data_add_dict_u64(d, xstat_names[i].name,
eth_xstats[i].value);
+ }
free(eth_xstats);
return 0;
}
@@ -6352,7 +6363,7 @@ RTE_INIT(ethdev_init_telemetry)
rte_telemetry_register_cmd("/ethdev/stats", eth_dev_handle_port_stats,
"Returns the common stats for a port. Parameters: int port_id");
rte_telemetry_register_cmd("/ethdev/xstats", eth_dev_handle_port_xstats,
- "Returns the extended stats for a port. Parameters: int port_id");
+ "Returns the extended stats for a port. Parameters: int port_id, bool hide_zero (Optional, non-zero indicates hide zero xstats)");
rte_telemetry_register_cmd("/ethdev/xstats_reset", eth_dev_handle_port_xstats_reset,
"Reset the extended stats for a port. Parameters: int port_id");
#ifndef RTE_EXEC_ENV_WINDOWS
--
2.17.1
next prev parent reply other threads:[~2023-01-20 3:41 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 9:07 [PATCH v5 0/5] support dmadev/ethdev stats reset Chengwen Feng
2022-12-19 9:07 ` [PATCH v5 1/5] dmadev: support stats reset telemetry command Chengwen Feng
2022-12-19 9:07 ` [PATCH v5 2/5] telemetry: fix repeated display when callback don't set dict Chengwen Feng
2022-12-19 9:33 ` Bruce Richardson
2022-12-26 4:53 ` fengchengwen
2023-01-06 16:07 ` Bruce Richardson
2023-01-06 17:33 ` Bruce Richardson
2023-01-11 12:38 ` fengchengwen
2022-12-19 9:07 ` [PATCH v5 3/5] ethdev: support xstats reset telemetry command Chengwen Feng
2022-12-19 9:07 ` [PATCH v5 4/5] ethdev: telemetry xstats support hide zero Chengwen Feng
2022-12-19 9:07 ` [PATCH v5 5/5] ethdev: add newline to telemetry log string Chengwen Feng
2022-12-26 4:55 ` [PATCH v5 0/5] support dmadev/ethdev stats reset fengchengwen
2023-01-11 12:02 ` [PATCH v2 " Chengwen Feng
2023-01-11 12:02 ` [PATCH v2 1/5] dmadev: support stats reset telemetry command Chengwen Feng
2023-01-11 12:02 ` [PATCH v2 2/5] telemetry: fix repeat display when callback don't set dict Chengwen Feng
2023-01-11 12:02 ` [PATCH v2 3/5] ethdev: add newline to telemetry log string Chengwen Feng
2023-01-11 12:02 ` [PATCH v2 4/5] ethdev: support xstats reset telemetry command Chengwen Feng
2023-01-11 12:02 ` [PATCH v2 5/5] ethdev: telemetry xstats support hide zero Chengwen Feng
2023-01-11 12:06 ` [PATCH v2 0/5] support dmadev/ethdev stats reset Chengwen Feng
2023-01-11 12:06 ` [PATCH v2 1/5] dmadev: support stats reset telemetry command Chengwen Feng
2023-01-11 13:58 ` Bruce Richardson
2023-01-11 12:06 ` [PATCH v2 2/5] telemetry: fix repeat display when callback don't set dict Chengwen Feng
2023-01-11 14:01 ` Bruce Richardson
2023-01-11 12:06 ` [PATCH v2 3/5] ethdev: add newline to telemetry log string Chengwen Feng
2023-01-11 12:06 ` [PATCH v2 4/5] ethdev: support xstats reset telemetry command Chengwen Feng
2023-01-11 12:06 ` [PATCH v2 5/5] ethdev: telemetry xstats support hide zero Chengwen Feng
2023-01-11 14:08 ` Bruce Richardson
2023-01-20 3:51 ` fengchengwen
2023-01-11 12:36 ` [PATCH v2 0/5] support dmadev/ethdev stats reset fengchengwen
2023-01-20 3:25 ` [PATCH v3 " Chengwen Feng
2023-01-20 3:25 ` [PATCH v3 1/5] dmadev: support stats reset telemetry command Chengwen Feng
2023-01-20 3:25 ` [PATCH v3 2/5] telemetry: fix repeat display when callback don't init dict Chengwen Feng
2023-01-20 3:25 ` [PATCH v3 3/5] ethdev: add newline to telemetry log string Chengwen Feng
2023-01-20 3:25 ` [PATCH v3 4/5] ethdev: support xstats reset telemetry command Chengwen Feng
2023-01-20 3:25 ` [PATCH v3 5/5] ethdev: telemetry xstats support hide zero Chengwen Feng
2023-01-20 3:34 ` [PATCH v4 0/5] support dmadev/ethdev stats reset Chengwen Feng
2023-01-20 3:34 ` [PATCH v4 1/5] dmadev: support stats reset telemetry command Chengwen Feng
2023-01-20 3:34 ` [PATCH v4 2/5] telemetry: fix repeat display when callback don't init dict Chengwen Feng
2023-02-08 14:15 ` Bruce Richardson
2023-02-09 1:33 ` fengchengwen
2023-01-20 3:34 ` [PATCH v4 3/5] ethdev: add newline to telemetry log string Chengwen Feng
2023-01-20 3:34 ` [PATCH v4 4/5] ethdev: support xstats reset telemetry command Chengwen Feng
2023-01-20 3:34 ` Chengwen Feng [this message]
2023-02-06 8:39 ` [PATCH v4 0/5] support dmadev/ethdev stats reset Thomas Monjalon
2023-02-08 14:17 ` Bruce Richardson
2023-02-09 1:45 ` fengchengwen
2023-02-09 2:32 ` [PATCH v5 0/2] " Chengwen Feng
2023-02-09 2:32 ` [PATCH v5 1/2] dmadev: support stats reset telemetry command Chengwen Feng
2023-02-09 2:32 ` [PATCH v5 2/2] ethdev: support xstats " Chengwen Feng
2023-02-15 3:19 ` Dongdong Liu
2023-02-16 11:53 ` fengchengwen
2023-02-16 12:06 ` Ferruh Yigit
2023-02-16 12:42 ` fengchengwen
2023-02-16 12:54 ` Bruce Richardson
2023-02-16 12:55 ` Bruce Richardson
2023-02-17 9:44 ` fengchengwen
2023-02-20 13:05 ` Thomas Monjalon
2023-07-03 3:58 ` fengchengwen
2023-07-03 7:20 ` Thomas Monjalon
2023-07-03 13:44 ` Morten Brørup
2023-07-04 6:41 ` fengchengwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230120033456.29710-6-fengchengwen@huawei.com \
--to=fengchengwen@huawei.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=kevin.laatz@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).