From: Stephen Hemminger <stephen@networkplumber.org>
To: Volodymyr Fialko <vfialko@marvell.com>
Cc: <dev@dpdk.org>, Reshma Pattan <reshma.pattan@intel.com>,
<jerinj@marvell.com>, <anoobj@marvell.com>
Subject: Re: [PATCH 1/2] reorder: invalidate buf from ready queue in drain
Date: Tue, 7 Feb 2023 08:24:52 -0800 [thread overview]
Message-ID: <20230207082452.0efd1d22@hermes.local> (raw)
In-Reply-To: <20230107151939.2540148-2-vfialko@marvell.com>
On Sat, 7 Jan 2023 16:19:38 +0100
Volodymyr Fialko <vfialko@marvell.com> wrote:
> Set drained buffers from ready queue to NULL, since their ownership
> returned to user. Otherwise it's possible that both user and library
> will attempt to free the packet.
>
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
Looks correct to me.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2023-02-07 16:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 15:19 [PATCH 0/2] lib/reorder: fix drain/free issues Volodymyr Fialko
2023-01-07 15:19 ` [PATCH 1/2] reorder: invalidate buf from ready queue in drain Volodymyr Fialko
2023-02-07 16:24 ` Stephen Hemminger [this message]
2023-01-07 15:19 ` [PATCH 2/2] test/reorder: fix double free of drained buffers Volodymyr Fialko
2023-01-26 15:51 ` David Marchand
2023-02-07 16:25 ` Stephen Hemminger
2023-01-26 15:47 ` [PATCH 0/2] lib/reorder: fix drain/free issues David Marchand
2023-02-07 11:18 ` Thomas Monjalon
2023-02-06 15:47 ` Volodymyr Fialko
2023-02-19 23:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207082452.0efd1d22@hermes.local \
--to=stephen@networkplumber.org \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=reshma.pattan@intel.com \
--cc=vfialko@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).