From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com,
Chaoyong He <chaoyong.he@corigine.com>,
stable@dpdk.org
Subject: [PATCH 6/6] net/nfp: fix the set IPv4/v6 DSCP flow action
Date: Tue, 21 Feb 2023 14:49:30 +0800 [thread overview]
Message-ID: <20230221064930.3399-7-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20230221064930.3399-1-chaoyong.he@corigine.com>
The former logic of set IPv4/v6 DSCP flow action don't consider the
mask filed of control message passed to the firmware.
This caused the firmware skip the set action logic, and the offloaded
packets don't have the right IPv4/v6 DSCP as expected.
Fixes: 9c665d70f7a7 ("net/nfp: support IPv4 DSCP flow action")
Fixes: 3202b003bec1 ("net/nfp: support IPv6 DSCP flow action")
Cc: stable@dpdk.org
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
drivers/net/nfp/nfp_flow.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c
index c6e19d8cac..c8c57bc363 100644
--- a/drivers/net/nfp/nfp_flow.c
+++ b/drivers/net/nfp/nfp_flow.c
@@ -2300,6 +2300,7 @@ nfp_flow_action_set_tos(char *act_data,
tos_conf = (const struct rte_flow_action_set_dscp *)action->conf;
ttl_tos->ipv4_tos = tos_conf->dscp;
+ ttl_tos->ipv4_tos_mask = 0xff;
ttl_tos->reserved = 0;
}
@@ -2323,6 +2324,7 @@ nfp_flow_action_set_tc(char *act_data,
tos_conf = (const struct rte_flow_action_set_dscp *)action->conf;
tc_hl->ipv6_tc = tos_conf->dscp;
+ tc_hl->ipv6_tc_mask = 0xff;
tc_hl->reserved = 0;
}
--
2.29.3
next prev parent reply other threads:[~2023-02-21 6:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230221064930.3399-1-chaoyong.he@corigine.com>
2023-02-21 6:49 ` [PATCH 1/6] net/nfp: fix the set MAC " Chaoyong He
2023-02-21 6:49 ` [PATCH 2/6] net/nfp: fix the set IPv4 " Chaoyong He
2023-02-21 6:49 ` [PATCH 3/6] net/nfp: fix the set IPv6 " Chaoyong He
2023-02-21 6:49 ` [PATCH 4/6] net/nfp: fix the set TP " Chaoyong He
2023-02-21 6:49 ` [PATCH 5/6] net/nfp: fix the set TTL " Chaoyong He
2023-02-21 6:49 ` Chaoyong He [this message]
[not found] ` <20230221103513.412-1-chaoyong.he@corigine.com>
2023-02-21 10:35 ` [PATCH v2 1/6] net/nfp: fix the set MAC " Chaoyong He
2023-02-21 10:35 ` [PATCH v2 2/6] net/nfp: fix the set IPv4 " Chaoyong He
2023-02-21 10:35 ` [PATCH v2 3/6] net/nfp: fix the set IPv6 " Chaoyong He
2023-02-21 10:35 ` [PATCH v2 4/6] net/nfp: fix the set TP " Chaoyong He
2023-02-21 10:35 ` [PATCH v2 5/6] net/nfp: fix the set TTL " Chaoyong He
2023-02-21 10:35 ` [PATCH v2 6/6] net/nfp: fix the set IPv4/v6 DSCP " Chaoyong He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221064930.3399-7-chaoyong.he@corigine.com \
--to=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).