From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net, olivier.matz@6wind.com,
stephen@networkplumber.org, mb@smartsharesystems.com,
hofors@lysator.liu.se
Subject: Re: [PATCH v6 1/3] eal: add rte thread create control API
Date: Fri, 24 Feb 2023 11:04:26 -0800 [thread overview]
Message-ID: <20230224190426.GF21944@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <CAJFAV8ziMWpCha9BXE9T4VyY+9SJR27rEDU64NB97chNQDi=3A@mail.gmail.com>
On Fri, Feb 24, 2023 at 09:13:56AM +0100, David Marchand wrote:
> On Wed, Feb 8, 2023 at 10:26 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > Add rte_thread_create_control API as a replacement for
> > rte_ctrl_thread_create to allow deprecation of the use of platform
> > specific types in DPDK public API.
> >
> > Add test from David Marchand to exercise the new API.
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > Acked-by: Morten Brørup <mb@smartsharesystems.com>
> > Reviewed-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> > ---
> > app/test/test_threads.c | 26 ++++++++++++
> > lib/eal/common/eal_common_thread.c | 85 ++++++++++++++++++++++++++++++++++----
> > lib/eal/include/rte_thread.h | 33 +++++++++++++++
> > lib/eal/version.map | 1 +
> > 4 files changed, 137 insertions(+), 8 deletions(-)
> >
> > diff --git a/app/test/test_threads.c b/app/test/test_threads.c
> > index e0f18e4..657ecad 100644
> > --- a/app/test/test_threads.c
> > +++ b/app/test/test_threads.c
> > @@ -232,6 +232,31 @@
> > return 0;
> > }
> >
> > +static int
> > +test_thread_create_control_join(void)
> > +{
> > + rte_thread_t thread_id;
> > + rte_thread_t thread_main_id;
> > +
> > + thread_id_ready = 0;
> > + RTE_TEST_ASSERT(rte_thread_create_control(&thread_id, "test_control_threads",
> > + NULL, thread_main, &thread_main_id) == 0,
> > + "Failed to create thread.");
> > +
> > + while (__atomic_load_n(&thread_id_ready, __ATOMIC_ACQUIRE) == 0)
> > + ;
> > +
> > + RTE_TEST_ASSERT(rte_thread_equal(thread_id, thread_main_id) != 0,
> > + "Unexpected thread id.");
> > +
> > + __atomic_store_n(&thread_id_ready, 2, __ATOMIC_RELEASE);
> > +
> > + RTE_TEST_ASSERT(rte_thread_join(thread_id, NULL) == 0,
> > + "Failed to join thread.");
> > +
> > + return 0;
> > +}
> > +
> > static struct unit_test_suite threads_test_suite = {
> > .suite_name = "threads autotest",
> > .setup = NULL,
> > @@ -243,6 +268,7 @@
> > TEST_CASE(test_thread_priority),
> > TEST_CASE(test_thread_attributes_affinity),
> > TEST_CASE(test_thread_attributes_priority),
> > + TEST_CASE(test_thread_create_control_join),
> > TEST_CASES_END()
> > }
> > };
> > diff --git a/lib/eal/common/eal_common_thread.c b/lib/eal/common/eal_common_thread.c
> > index 3181515..4f83c97 100644
> > --- a/lib/eal/common/eal_common_thread.c
> > +++ b/lib/eal/common/eal_common_thread.c
> > @@ -232,7 +232,10 @@ enum __rte_ctrl_thread_status {
> > };
> >
> > struct rte_thread_ctrl_params {
> > - void *(*start_routine)(void *);
> > + union {
> > + void *(*ctrl_start_routine)(void *arg);
> > + rte_thread_func control_start_routine;
> > + } u;
> > void *arg;
> > int ret;
> > /* Control thread status.
> > @@ -241,27 +244,47 @@ struct rte_thread_ctrl_params {
> > enum __rte_ctrl_thread_status ctrl_thread_status;
> > };
> >
> > -static void *ctrl_thread_init(void *arg)
> > +static int ctrl_thread_init(void *arg)
> > {
> > struct internal_config *internal_conf =
> > eal_get_internal_configuration();
> > rte_cpuset_t *cpuset = &internal_conf->ctrl_cpuset;
> > struct rte_thread_ctrl_params *params = arg;
> > - void *(*start_routine)(void *) = params->start_routine;
> > - void *routine_arg = params->arg;
> >
> > __rte_thread_init(rte_lcore_id(), cpuset);
> > params->ret = rte_thread_set_affinity_by_id(rte_thread_self(), cpuset);
> > if (params->ret != 0) {
> > __atomic_store_n(¶ms->ctrl_thread_status,
> > CTRL_THREAD_ERROR, __ATOMIC_RELEASE);
> > - return NULL;
> > + return params->ret;
> > }
> >
> > __atomic_store_n(¶ms->ctrl_thread_status,
> > CTRL_THREAD_RUNNING, __ATOMIC_RELEASE);
> >
> > - return start_routine(routine_arg);
> > + return 0;
> > +}
> > +
> > +static void *ctrl_thread_start(void *arg)
> > +{
> > + struct rte_thread_ctrl_params *params = arg;
> > + void *(*start_routine)(void *) = params->u.ctrl_start_routine;
> > +
> > + if (ctrl_thread_init(arg) != 0)
> > + return NULL;
> > +
> > + return start_routine(params->arg);
>
> Does this patch open a race on params->arg between the newly created
> thread, and the one that asked for creation?
> Reading params->arg is not under the ctrl_thread_status
> syncrhonisation point anymore (which was protecting against
> free(params)).
>
> WDYT?
i will take a look, thanks for letting me know.
>
> (Note that I doubt this patch has anything to do with the recent bz
> opened by Intel QE)
>
>
> > +}
> > +
> > +static uint32_t control_thread_start(void *arg)
> > +{
> > + struct rte_thread_ctrl_params *params = arg;
> > + rte_thread_func start_routine = params->u.control_start_routine;
> > +
> > + if (ctrl_thread_init(arg) != 0)
> > + return params->ret;
>
> Idem here for params->ret.
>
>
> > +
> > + return start_routine(params->arg);
> > }
> >
> > int
> > @@ -277,12 +300,12 @@ static void *ctrl_thread_init(void *arg)
> > if (!params)
> > return -ENOMEM;
> >
> > - params->start_routine = start_routine;
> > + params->u.ctrl_start_routine = start_routine;
> > params->arg = arg;
> > params->ret = 0;
> > params->ctrl_thread_status = CTRL_THREAD_LAUNCHING;
> >
> > - ret = pthread_create(thread, attr, ctrl_thread_init, (void *)params);
> > + ret = pthread_create(thread, attr, ctrl_thread_start, (void *)params);
> > if (ret != 0) {
> > free(params);
> > return -ret;
> > @@ -315,6 +338,52 @@ static void *ctrl_thread_init(void *arg)
> > }
> >
> > int
> > +rte_thread_create_control(rte_thread_t *thread, const char *name,
> > + const rte_thread_attr_t *attr,
> > + rte_thread_func start_routine, void *arg)
> > +{
> > + struct rte_thread_ctrl_params *params;
> > + enum __rte_ctrl_thread_status ctrl_thread_status;
> > + int ret;
> > +
> > + params = malloc(sizeof(*params));
> > + if (params == NULL)
> > + return -ENOMEM;
> > +
> > + params->u.control_start_routine = start_routine;
> > + params->arg = arg;
> > + params->ret = 0;
> > + params->ctrl_thread_status = CTRL_THREAD_LAUNCHING;
> > +
> > + ret = rte_thread_create(thread, attr, control_thread_start, params);
> > + if (ret != 0) {
> > + free(params);
> > + return -ret;
> > + }
> > +
> > + if (name != NULL)
> > + rte_thread_set_name(*thread, name);
> > +
> > + /* Wait for the control thread to initialize successfully */
> > + while ((ctrl_thread_status =
> > + __atomic_load_n(¶ms->ctrl_thread_status,
> > + __ATOMIC_ACQUIRE)) == CTRL_THREAD_LAUNCHING) {
> > + rte_delay_us_sleep(1);
> > + }
> > +
> > + /* Check if the control thread encountered an error */
> > + if (ctrl_thread_status == CTRL_THREAD_ERROR) {
> > + /* ctrl thread is exiting */
> > + rte_thread_join(*thread, NULL);
> > + }
> > +
> > + ret = params->ret;
> > + free(params);
> > +
> > + return ret;
> > +}
> > +
> > +int
> > rte_thread_register(void)
> > {
> > unsigned int lcore_id;
> > diff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h
> > index d247930..fae26a7 100644
> > --- a/lib/eal/include/rte_thread.h
> > +++ b/lib/eal/include/rte_thread.h
> > @@ -98,6 +98,39 @@ int rte_thread_create(rte_thread_t *thread_id,
> > * @warning
> > * @b EXPERIMENTAL: this API may change without prior notice.
> > *
> > + * Create a control thread.
> > + *
> > + * Creates a control thread with the given name and attributes. The
> > + * affinity of the new thread is based on the CPU affinity retrieved
> > + * at the time rte_eal_init() was called, the EAL threads are then
> > + * excluded. If setting the name of the thread fails, the error is
> > + * ignored and a debug message is logged.
> > + *
> > + * @param thread
> > + * Filled with the thread id of the new created thread.
> > + * @param name
> > + * The name of the control thread
> > + * (max RTE_MAX_THREAD_NAME_LEN characters including '\0').
> > + * @param thread_attr
> > + * Attributes for the new thread.
> > + * @param thread_func
> > + * Function to be executed by the new thread.
> > + * @param arg
> > + * Argument passed to start_routine.
> > + * @return
> > + * On success, returns 0; on error, it returns a negative value
> > + * corresponding to the error number.
> > + */
> > +__rte_experimental
> > +int
> > +rte_thread_create_control(rte_thread_t *thread, const char *name,
> > + const rte_thread_attr_t *thread_attr,
> > + rte_thread_func thread_func, void *arg);
> > +
> > +/**
> > + * @warning
> > + * @b EXPERIMENTAL: this API may change without prior notice.
> > + *
> > * Waits for the thread identified by 'thread_id' to terminate
> > *
> > * @param thread_id
> > diff --git a/lib/eal/version.map b/lib/eal/version.map
> > index 6523102..285a0bd 100644
> > --- a/lib/eal/version.map
> > +++ b/lib/eal/version.map
> > @@ -441,6 +441,7 @@ EXPERIMENTAL {
> > rte_thread_join;
> >
> > # added in 23.03
> > + rte_thread_create_control;
> > rte_thread_set_name;
> > };
> >
> > --
> > 1.8.3.1
> >
>
>
> --
> David Marchand
next prev parent reply other threads:[~2023-02-24 19:04 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 20:24 [PATCH 0/3] eal: rte_ctrl_thread_create API replacement Tyler Retzlaff
2022-12-05 20:24 ` [PATCH 1/3] eal: add rte control thread create API Tyler Retzlaff
2022-12-05 21:11 ` Stephen Hemminger
2022-12-06 0:21 ` Tyler Retzlaff
2022-12-06 17:35 ` Tyler Retzlaff
2022-12-07 0:49 ` Stephen Hemminger
2022-12-05 20:24 ` [PATCH 2/3] test: add rte control thread create API test Tyler Retzlaff
2022-12-05 20:24 ` [PATCH 3/3] eal: deprecate pthread control thread create API Tyler Retzlaff
2022-12-05 21:18 ` Stephen Hemminger
2022-12-06 0:24 ` Tyler Retzlaff
2022-12-05 20:34 ` [PATCH 0/3] eal: rte_ctrl_thread_create API replacement Morten Brørup
2022-12-06 17:28 ` [PATCH v2 " Tyler Retzlaff
2022-12-06 17:28 ` [PATCH v2 1/3] eal: add rte control thread create API Tyler Retzlaff
2022-12-07 9:13 ` Mattias Rönnblom
2022-12-07 16:38 ` Tyler Retzlaff
2022-12-07 20:37 ` Tyler Retzlaff
2022-12-08 21:59 ` Mattias Rönnblom
2022-12-08 22:15 ` Tyler Retzlaff
2022-12-09 1:09 ` Stephen Hemminger
2022-12-09 19:49 ` Tyler Retzlaff
2022-12-06 17:28 ` [PATCH v2 2/3] test: add rte control thread create API test Tyler Retzlaff
2022-12-06 17:28 ` [PATCH v2 3/3] eal: deprecate pthread control thread create API Tyler Retzlaff
2022-12-07 20:31 ` [PATCH v3 0/3] eal: rte_ctrl_thread_create API replacement Tyler Retzlaff
2022-12-07 20:31 ` [PATCH v3 1/3] eal: add rte control thread create API Tyler Retzlaff
2022-12-07 20:31 ` [PATCH v3 2/3] test: add rte control thread create API test Tyler Retzlaff
2022-12-07 20:31 ` [PATCH v3 3/3] eal: deprecate pthread control thread create API Tyler Retzlaff
2022-12-08 23:19 ` [PATCH v4 0/3] eal: rte_ctrl_thread_create API replacement Tyler Retzlaff
2022-12-08 23:19 ` [PATCH v4 1/3] eal: add rte control thread create API Tyler Retzlaff
2022-12-08 23:19 ` [PATCH v4 2/3] test: add rte control thread create API test Tyler Retzlaff
2022-12-08 23:19 ` [PATCH v4 3/3] eal: deprecate pthread control thread create API Tyler Retzlaff
2022-12-10 14:31 ` [PATCH v4 0/3] eal: rte_ctrl_thread_create API replacement Mattias Rönnblom
2023-01-31 19:46 ` [PATCH v5 0/3] eal: deprecate last use of pthread_t in public API Tyler Retzlaff
2023-01-31 19:46 ` [PATCH v5 1/3] eal: add rte control thread create API Tyler Retzlaff
2023-01-31 19:46 ` [PATCH v5 2/3] doc: add missing index entry for thread Tyler Retzlaff
2023-01-31 19:46 ` [PATCH v5 3/3] doc: announce deprecation of thread ctrl create function Tyler Retzlaff
2023-01-31 20:30 ` [PATCH v5 0/3] eal: deprecate last use of pthread_t in public API Tyler Retzlaff
2023-01-31 20:30 ` [PATCH v5 1/3] eal: add rte control thread create API Tyler Retzlaff
2023-02-07 13:12 ` David Marchand
2023-02-07 21:41 ` Tyler Retzlaff
2023-01-31 20:30 ` [PATCH v5 2/3] doc: add missing index entry for thread Tyler Retzlaff
2023-02-07 15:39 ` David Marchand
2023-02-07 21:39 ` Tyler Retzlaff
2023-01-31 20:30 ` [PATCH v5 3/3] doc: announce deprecation of thread ctrl create function Tyler Retzlaff
2023-02-07 15:40 ` David Marchand
2023-01-31 20:33 ` [PATCH v5 0/3] eal: deprecate last use of pthread_t in public API Tyler Retzlaff
2023-02-08 21:26 ` [PATCH v6 " Tyler Retzlaff
2023-02-08 21:26 ` [PATCH v6 1/3] eal: add rte thread create control API Tyler Retzlaff
2023-02-24 5:52 ` Li, WeiyuanX
2023-02-24 8:13 ` David Marchand
2023-02-24 19:04 ` Tyler Retzlaff [this message]
2023-02-24 20:52 ` Tyler Retzlaff
2023-02-08 21:26 ` [PATCH v6 2/3] doc: add missing index entry for thread Tyler Retzlaff
2023-02-08 21:26 ` [PATCH v6 3/3] doc: announce deprecation of thread ctrl create function Tyler Retzlaff
2023-02-09 8:59 ` Bruce Richardson
2023-02-09 8:51 ` [PATCH v6 0/3] eal: deprecate last use of pthread_t in public API David Marchand
2023-02-09 11:55 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224190426.GF21944@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hofors@lysator.liu.se \
--cc=mb@smartsharesystems.com \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).