From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Ruifeng Wang <Ruifeng.Wang@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"thomas@monjalon.net" <thomas@monjalon.net>, nd <nd@arm.com>
Subject: Re: [PATCH 11/17] net/iavf: use previous value atomic fetch operations
Date: Thu, 2 Mar 2023 07:50:54 -0800 [thread overview]
Message-ID: <20230302155054.GA29061@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <AM9PR08MB708580C2D1064156FA7A58759EB29@AM9PR08MB7085.eurprd08.prod.outlook.com>
On Thu, Mar 02, 2023 at 09:28:09AM +0000, Ruifeng Wang wrote:
> > -----Original Message-----
> > From: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > Sent: Thursday, March 2, 2023 8:48 AM
> > To: dev@dpdk.org
> > Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; thomas@monjalon.net; Tyler
> > Retzlaff <roretzla@linux.microsoft.com>
> > Subject: [PATCH 11/17] net/iavf: use previous value atomic fetch operations
> >
> > Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch
> > when we have no interest in the result of the operation.
> >
> > Reduces unnecessary codegen that provided the result of the atomic operation that was not
> > used.
> >
> > Change brings closer alignment with atomics available in C11 standard and will reduce
> > review effort when they are integrated.
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> > drivers/net/iavf/iavf_vchnl.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index
> > 9adaadb..73875d7 100644
> > --- a/drivers/net/iavf/iavf_vchnl.c
> > +++ b/drivers/net/iavf/iavf_vchnl.c
> > @@ -128,7 +128,7 @@ struct iavf_event_handler {
> > int err = pipe(handler->fd);
> > #endif
> > if (err != 0) {
> > - __atomic_sub_fetch(&handler->ndev, 1, __ATOMIC_RELAXED);
> > + __atomic_fetch_sub(&handler->ndev, 1, __ATOMIC_RELAXED);
> > return -1;
> > }
> >
> > @@ -137,7 +137,7 @@ struct iavf_event_handler {
> >
> > if (rte_ctrl_thread_create(&handler->tid, "iavf-event-thread",
> > NULL, iavf_dev_event_handle, NULL)) {
> > - __atomic_sub_fetch(&handler->ndev, 1, __ATOMIC_RELAXED);
> > + __atomic_fetch_sub(&handler->ndev, 1, __ATOMIC_RELAXED);
> > return -1;
> > }
> >
> > @@ -533,7 +533,7 @@ struct iavf_event_handler {
> > /* read message and it's expected one */
> > if (msg_opc == vf->pend_cmd) {
> > uint32_t cmd_count =
> > - __atomic_sub_fetch(&vf->pend_cmd_count,
> > + __atomic_fetch_sub(&vf->pend_cmd_count,
>
> It doesn't apply here. The return value is used.
> The rest of the series looks good to me.
oh, i was blind to the line wrapping. definitely not correct.
thanks for catching this, will submit v2 with it reverted.
>
> > 1, __ATOMIC_RELAXED);
> > if (cmd_count == 0)
> > _notify_cmd(vf, msg_ret);
> > --
> > 1.8.3.1
next prev parent reply other threads:[~2023-03-02 15:50 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 0:47 [PATCH 00/17] use __atomic operations returning previous value Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 01/17] vhost: use previous value atomic fetch operations Tyler Retzlaff
2023-03-02 14:47 ` Maxime Coquelin
2023-03-02 0:47 ` [PATCH 02/17] telemetry: " Tyler Retzlaff
2023-03-02 9:34 ` Bruce Richardson
2023-03-02 0:47 ` [PATCH 03/17] stack: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 04/17] eal: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 05/17] distributor: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 06/17] bbdev: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 07/17] examples/vhost: " Tyler Retzlaff
2023-03-02 14:47 ` Maxime Coquelin
2023-03-02 0:47 ` [PATCH 08/17] net/virtio: " Tyler Retzlaff
2023-03-02 14:48 ` Maxime Coquelin
2023-03-02 0:47 ` [PATCH 09/17] net/octeontx: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 10/17] net/mlx5: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 11/17] net/iavf: " Tyler Retzlaff
2023-03-02 9:28 ` Ruifeng Wang
2023-03-02 15:50 ` Tyler Retzlaff [this message]
2023-03-02 0:47 ` [PATCH 12/17] net/cxgbe: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 13/17] drivers/event: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 14/17] dma/skeleton: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 15/17] drivers/common: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 16/17] app/test: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 17/17] test-eventdev: " Tyler Retzlaff
2023-03-02 14:40 ` [PATCH 00/17] use __atomic operations returning previous value Morten Brørup
2023-03-02 16:18 ` [PATCH v2 " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 01/17] vhost: use previous value atomic fetch operations Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 02/17] telemetry: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 03/17] stack: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 04/17] eal: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 05/17] distributor: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 06/17] bbdev: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 07/17] examples/vhost: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 08/17] net/virtio: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 09/17] net/octeontx: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 10/17] net/mlx5: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 11/17] net/iavf: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 12/17] net/cxgbe: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 13/17] drivers/event: " Tyler Retzlaff
2023-03-13 7:02 ` [EXT] " Pavan Nikhilesh Bhagavatula
2023-03-02 16:18 ` [PATCH v2 14/17] dma/skeleton: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 15/17] drivers/common: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 16/17] app/test: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 17/17] test-eventdev: " Tyler Retzlaff
2023-03-03 1:54 ` [PATCH v2 00/17] use __atomic operations returning previous value Ruifeng Wang
2023-03-03 2:33 ` fengchengwen
2023-04-25 9:10 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302155054.GA29061@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).