From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Ciara Power <ciara.power@intel.com>,
Declan Doherty <declan.doherty@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>
Subject: Re: [PATCH] telemetry: fix autotest failures on Alpine
Date: Fri, 10 Mar 2023 11:08:32 -0800 [thread overview]
Message-ID: <20230310110832.1cfa47e5@hermes.local> (raw)
In-Reply-To: <20230310181836.162336-1-bruce.richardson@intel.com>
On Fri, 10 Mar 2023 18:18:36 +0000
Bruce Richardson <bruce.richardson@intel.com> wrote:
> On Alpine linux, the telemetry_data_autotest was failing for the
> test where we had dictionaries embedded in other dictionaries up
> to three levels deep. Indications are that this issue is due to
> excess data being stored on the stack, so replace stack-allocated
> buffer data with dynamically allocated data in the case where we
> are doing recursive processing of telemetry data structures into
> json.
>
> Bugzilla ID: 1177
> Fixes: c933bb5177ca ("telemetry: support array values in data object")
> Fixes: d2671e642a8e ("telemetry: support dict of dicts")
> Cc: stable@dpdk.org
Looking at the telemetry code:
- why so many temporary buffers, could this be streamed or redesigned
so that an allocated buffer is returned.
- why is rte_tel_json_XXX all inline? These should just be internal
functions and not in a .h file.
FYI - if this library reused existing json writer it would have
been much simpler.
https://github.com/shemminger/iproute2/blob/main/lib/json_writer.c
next prev parent reply other threads:[~2023-03-10 19:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 18:18 Bruce Richardson
2023-03-10 19:08 ` Stephen Hemminger [this message]
2023-03-13 9:38 ` Bruce Richardson
[not found] ` <20230405154414.183915-1-bruce.richardson@intel.com>
2023-04-05 15:44 ` [PATCH v2 1/5] " Bruce Richardson
2023-04-07 19:21 ` Tyler Retzlaff
2023-04-11 8:43 ` Bruce Richardson
[not found] ` <20230405160326.186921-1-bruce.richardson@intel.com>
2023-04-05 16:03 ` [PATCH v3 " Bruce Richardson
2023-04-07 19:22 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310110832.1cfa47e5@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).