patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	stable@dpdk.org,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: [PATCH 1/2] examples/qos_sched: fix config entries in wrong sections
Date: Tue, 21 Mar 2023 13:13:49 +0000	[thread overview]
Message-ID: <20230321131350.122290-2-bruce.richardson@intel.com> (raw)
In-Reply-To: <20230321131350.122290-1-bruce.richardson@intel.com>

When specifying the QoS config, the profiles to be used for each pipe
within a subport must be specified in the subport section, not in the
section for the subport profile itself. Similarly for subport profiles,
those should be specified in the port section.

Fixes: de3cfa2c9823 ("sched: initial import")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 examples/qos_sched/profile.cfg     | 6 +++---
 examples/qos_sched/profile_ov.cfg  | 6 +++---
 examples/qos_sched/profile_pie.cfg | 6 +++---
 examples/qos_sched/profile_red.cfg | 6 +++---
 4 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/examples/qos_sched/profile.cfg b/examples/qos_sched/profile.cfg
index e8de101b6c..00d4c7c1a5 100644
--- a/examples/qos_sched/profile.cfg
+++ b/examples/qos_sched/profile.cfg
@@ -26,6 +26,8 @@ number of subports per port = 1
 number of pipes per subport = 4096
 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64

+pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
+
 [subport profile 0]
 tb rate = 1250000000           ; Bytes per second
 tb size = 1000000              ; Bytes
@@ -46,8 +48,6 @@ tc 12 rate = 1250000000        ; Bytes per second

 tc period = 10                 ; Milliseconds

-pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
-
 ; Pipe configuration
 [pipe profile 0]
 tb rate = 305175               ; Bytes per second
@@ -71,4 +71,4 @@ tc period = 40                ; Milliseconds

 tc 12 oversubscription weight = 1

-tc 12 wrr weights = 1 1 1 1
\ No newline at end of file
+tc 12 wrr weights = 1 1 1 1
diff --git a/examples/qos_sched/profile_ov.cfg b/examples/qos_sched/profile_ov.cfg
index 14c89ae340..b6fe21ee1e 100644
--- a/examples/qos_sched/profile_ov.cfg
+++ b/examples/qos_sched/profile_ov.cfg
@@ -6,12 +6,14 @@
 frame overhead = 24
 number of subports per port = 1

+subport 0-8 = 0
+
 ; Subport configuration
 [subport 0]
 number of pipes per subport = 32
 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64

-subport 0-8 = 0
+pipe 0-31 = 0               ; These pipes are configured with pipe profile 0

 [subport profile 0]
 tb rate = 8400000           ; Bytes per second
@@ -32,8 +34,6 @@ tc 11 rate = 8400000         ; Bytes per second
 tc 12 rate = 8400000         ; Bytes per second
 tc period = 10              ; Milliseconds

-pipe 0-31 = 0               ; These pipes are configured with pipe profile 0
-
 ; Pipe configuration
 [pipe profile 0]
 tb rate = 16800000             ; Bytes per second
diff --git a/examples/qos_sched/profile_pie.cfg b/examples/qos_sched/profile_pie.cfg
index 241f748b33..bbc09d912b 100644
--- a/examples/qos_sched/profile_pie.cfg
+++ b/examples/qos_sched/profile_pie.cfg
@@ -21,12 +21,14 @@
 frame overhead = 24
 number of subports per port = 1

+subport 0-8 = 0                ; These subports are configured with subport profile 0
+
 ; Subport configuration
 [subport 0]
 number of pipes per subport = 4096
 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64

-subport 0-8 = 0                ; These subports are configured with subport profile 0
+pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0

 [subport profile 0]
 tb rate = 1250000000           ; Bytes per second
@@ -48,8 +50,6 @@ tc 12 rate = 1250000000        ; Bytes per second

 tc period = 10                 ; Milliseconds

-pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
-
 ; Pipe configuration
 [pipe profile 0]
 tb rate = 305175               ; Bytes per second
diff --git a/examples/qos_sched/profile_red.cfg b/examples/qos_sched/profile_red.cfg
index 4486d2799e..cee1470fd7 100644
--- a/examples/qos_sched/profile_red.cfg
+++ b/examples/qos_sched/profile_red.cfg
@@ -21,12 +21,14 @@
 frame overhead = 24
 number of subports per port = 1

+subport 0-8 = 0                ; These subports are configured with subport profile 0
+
 ; Subport configuration
 [subport 0]
 number of pipes per subport = 4096
 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64

-subport 0-8 = 0                ; These subports are configured with subport profile 0
+pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0

 [subport profile 0]
 tb rate = 1250000000           ; Bytes per second
@@ -48,8 +50,6 @@ tc 12 rate = 1250000000        ; Bytes per second

 tc period = 10                 ; Milliseconds

-pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
-
 ; Pipe configuration
 [pipe profile 0]
 tb rate = 305175               ; Bytes per second
--
2.37.2


       reply	other threads:[~2023-03-21 13:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230321131350.122290-1-bruce.richardson@intel.com>
2023-03-21 13:13 ` Bruce Richardson [this message]
2023-03-21 17:38   ` Dumitrescu, Cristian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230321131350.122290-2-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).