From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, ciara.power@intel.com, david.marchand@redhat.com,
thomas@monjalon.net, konstantin.ananyev@huawei.com
Subject: Re: [PATCH v4] telemetry: remove non-portable array initialization syntax
Date: Wed, 5 Apr 2023 08:27:35 -0700 [thread overview]
Message-ID: <20230405152735.GC28418@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <ZC03uN24XtMZC2ga@bricha3-MOBL.ger.corp.intel.com>
On Wed, Apr 05, 2023 at 09:56:24AM +0100, Bruce Richardson wrote:
> On Tue, Apr 04, 2023 at 11:09:16AM -0700, Tyler Retzlaff wrote:
> > Use of ranges in designated initialization are a non-standard gcc
> > extension.
> >
> > Only initialize '_' and '/' elements of the array and filter tests
> > of characters through name with standard C isalnum before checking
> > the array.
> >
> > Suggested-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> > Suggested-by: Bruce Richardson <bruce.richardson@intel.com>
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> The array should probably be "static", which was a miss in the original
> version too.
micro optimization trade off image size vs stack usage yeah. i'd be inclined
to use static so i can update that.
>
> > ---
> > lib/telemetry/telemetry_data.c | 16 +++++++---------
> > 1 file changed, 7 insertions(+), 9 deletions(-)
> >
> > diff --git a/lib/telemetry/telemetry_data.c b/lib/telemetry/telemetry_data.c
> > index 2bac2de..0dc091a 100644
> > --- a/lib/telemetry/telemetry_data.c
> > +++ b/lib/telemetry/telemetry_data.c
> > @@ -2,6 +2,7 @@
> > * Copyright(c) 2020 Intel Corporation
> > */
> >
> > +#include <ctype.h>
> > #include <errno.h>
> > #include <stdlib.h>
> > #include <inttypes.h>
> > @@ -152,17 +153,14 @@
> > static bool
> > valid_name(const char *name)
> > {
> > - char allowed[128] = {
> > - ['0' ... '9'] = 1,
> > - ['A' ... 'Z'] = 1,
> > - ['a' ... 'z'] = 1,
> > - ['_'] = 1,
> > - ['/'] = 1,
> > - };
> > - while (*name != '\0') {
> > + /* non-alpha-numeric characters allowed in names */
> > + const char allowed[128] = { ['_'] = 1, ['/'] = 1 };
> > +
> > + for (; *name != '\0'; name++) {
> > + if (isalnum(*name))
> > + continue;
> > if ((size_t)*name >= RTE_DIM(allowed) || allowed[(int)*name] == 0)
> > return false;
> > - name++;
> > }
> > return true;
> > }
> > --
> > 1.8.3.1
> >
next prev parent reply other threads:[~2023-04-05 15:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 16:30 [PATCH 0/2] improve code portability Tyler Retzlaff
2023-04-03 16:30 ` [PATCH 1/2] telemetry: use malloc instead of variable length array Tyler Retzlaff
2023-04-03 17:17 ` Tyler Retzlaff
2023-04-03 20:19 ` Stephen Hemminger
2023-04-03 20:40 ` Tyler Retzlaff
2023-04-04 8:47 ` Bruce Richardson
2023-04-04 16:24 ` Tyler Retzlaff
2023-04-04 16:28 ` Bruce Richardson
2023-04-04 16:44 ` Tyler Retzlaff
2023-04-04 17:25 ` Bruce Richardson
2023-04-04 17:34 ` Tyler Retzlaff
2023-04-05 1:20 ` Stephen Hemminger
2023-04-05 8:53 ` Bruce Richardson
2023-04-05 1:04 ` Stephen Hemminger
2023-04-05 8:54 ` Bruce Richardson
2023-04-05 15:25 ` Tyler Retzlaff
2023-04-05 15:30 ` Dmitry Kozlyuk
2023-04-05 15:37 ` Stephen Hemminger
2023-04-05 15:47 ` Bruce Richardson
2023-04-03 16:30 ` [PATCH 2/2] telemetry: use portable syntax to initialize array Tyler Retzlaff
2023-04-03 17:04 ` [PATCH 0/2] improve code portability Bruce Richardson
2023-04-03 17:35 ` Tyler Retzlaff
2023-04-03 18:47 ` [PATCH v2] " Tyler Retzlaff
2023-04-03 18:47 ` [PATCH v2] telemetry: use portable syntax to initialize array Tyler Retzlaff
2023-04-03 18:59 ` [PATCH v3] improve code portability Tyler Retzlaff
2023-04-03 18:59 ` [PATCH v3] telemetry: use portable syntax to initialize array Tyler Retzlaff
2023-04-04 8:51 ` Bruce Richardson
2023-04-04 15:54 ` Tyler Retzlaff
2023-04-04 16:08 ` Bruce Richardson
2023-04-04 9:01 ` Konstantin Ananyev
2023-04-04 15:59 ` Tyler Retzlaff
2023-04-04 16:19 ` Bruce Richardson
2023-04-04 16:28 ` Tyler Retzlaff
2023-04-04 18:09 ` [PATCH v4] improve code portability Tyler Retzlaff
2023-04-04 18:09 ` [PATCH v4] telemetry: remove non-portable array initialization syntax Tyler Retzlaff
2023-04-05 8:56 ` Bruce Richardson
2023-04-05 15:27 ` Tyler Retzlaff [this message]
2023-04-05 18:52 ` [PATCH v5] improve code portability Tyler Retzlaff
2023-04-05 18:52 ` [PATCH v5] telemetry: remove non-portable array initialization syntax Tyler Retzlaff
2023-05-24 20:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405152735.GC28418@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).