From: Ronak Doshi <doshir@vmware.com>
To: Jochen Behrens <jbehrens@vmware.com>
Cc: <dev@dpdk.org>, Ronak Doshi <doshir@vmware.com>
Subject: [PATCH v2 next 5/7] net/vmxnet3: limit number of TXDs used for TSO packet
Date: Wed, 26 Apr 2023 12:04:12 -0700 [thread overview]
Message-ID: <20230426190415.28239-6-doshir@vmware.com> (raw)
In-Reply-To: <20230426190415.28239-1-doshir@vmware.com>
Currently, vmxnet3 does not have a limit on number of descriptors
used for a TSO packet. However, with UPT, for hardware performance
reasons, this patch limits the number of transmit descriptors to 24
for a TSO packet.
Signed-off-by: Ronak Doshi <doshir@vmware.com>
Acked-by: Jochen Behrens <jbehrens@vmware.com>
---
drivers/net/vmxnet3/base/vmxnet3_defs.h | 2 ++
drivers/net/vmxnet3/vmxnet3_rxtx.c | 18 ++++++++++++++----
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base/vmxnet3_defs.h
index d8cc295b08..24c235876e 100644
--- a/drivers/net/vmxnet3/base/vmxnet3_defs.h
+++ b/drivers/net/vmxnet3/base/vmxnet3_defs.h
@@ -419,6 +419,8 @@ typedef union Vmxnet3_GenericDesc {
/* max # of tx descs for a non-tso pkt */
#define VMXNET3_MAX_TXD_PER_PKT 16
+/* max # of tx descs for a tso pkt */
+#define VMXNET3_MAX_TSO_TXD_PER_PKT 24
/* Max size of a single rx buffer */
#define VMXNET3_MAX_RX_BUF_SIZE ((1 << 14) - 1)
diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index e31878ecab..7bbae4177e 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
@@ -364,6 +364,14 @@ vmxnet3_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,
rte_errno = EINVAL;
return i;
}
+ /* TSO packet cannot occupy more than
+ * VMXNET3_MAX_TSO_TXD_PER_PKT TX descriptors.
+ */
+ if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) != 0 &&
+ m->nb_segs > VMXNET3_MAX_TSO_TXD_PER_PKT) {
+ rte_errno = EINVAL;
+ return i;
+ }
/* check that only supported TX offloads are requested. */
if ((ol_flags & VMXNET3_TX_OFFLOAD_NOTSUP_MASK) != 0 ||
@@ -444,10 +452,12 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
continue;
}
- /* Drop non-TSO packet that is excessively fragmented */
- if (unlikely(!tso && count > VMXNET3_MAX_TXD_PER_PKT)) {
- PMD_TX_LOG(ERR, "Non-TSO packet cannot occupy more than %d tx "
- "descriptors. Packet dropped.", VMXNET3_MAX_TXD_PER_PKT);
+ /* Drop non-TSO or TSO packet that is excessively fragmented */
+ if (unlikely((!tso && count > VMXNET3_MAX_TXD_PER_PKT) ||
+ (tso && count > VMXNET3_MAX_TSO_TXD_PER_PKT))) {
+ PMD_TX_LOG(ERR, "Non-TSO or TSO packet cannot occupy more than "
+ "%d or %d tx descriptors respectively. Packet dropped.",
+ VMXNET3_MAX_TXD_PER_PKT, VMXNET3_MAX_TSO_TXD_PER_PKT);
txq->stats.drop_too_many_segs++;
txq->stats.drop_total++;
rte_pktmbuf_free(txm);
--
2.11.0
next prev parent reply other threads:[~2023-04-26 19:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 19:04 [PATCH v2 next 0/7] net/vmxnet3: upgrade to version 7 Ronak Doshi
2023-04-26 19:04 ` [PATCH v2 next 1/7] net/vmxnet3: prepare for version 7 changes Ronak Doshi
2023-04-26 19:04 ` [PATCH v2 next 2/7] net/vmxnet3: add support for capability registers Ronak Doshi
2023-04-26 19:04 ` [PATCH v2 next 3/7] net/vmxnet3: add support for large passthrough BAR register Ronak Doshi
2023-04-26 19:04 ` [PATCH v2 next 4/7] net/vmxnet3: add command to set ring buffer sizes Ronak Doshi
2023-04-26 19:04 ` Ronak Doshi [this message]
2023-04-26 19:04 ` [PATCH v2 next 6/7] net/vmxnet3: avoid updating rxprod register frequently Ronak Doshi
2023-04-26 19:04 ` [PATCH v2 next 7/7] net/vmxnet3: update to version 7 Ronak Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230426190415.28239-6-doshir@vmware.com \
--to=doshir@vmware.com \
--cc=dev@dpdk.org \
--cc=jbehrens@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).