From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>, dev@dpdk.org, techboard@dpdk.org
Subject: Re: [PATCH] build: announce requirement for C11
Date: Wed, 3 May 2023 09:07:54 -0700 [thread overview]
Message-ID: <20230503160754.GB12879@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <ZFKEdMP188QoJWYh@bricha3-MOBL.ger.corp.intel.com>
On Wed, May 03, 2023 at 04:57:40PM +0100, Bruce Richardson wrote:
> On Wed, May 03, 2023 at 04:39:14PM +0100, Ferruh Yigit wrote:
> > On 5/3/2023 4:14 PM, Bruce Richardson wrote:
> > > Add a deprecation notice informing users that we will require a C11
> > > compiler from 23.11 release onwards. This requirement was agreed by
> > > technical board to enable use of newer C language features, e.g.
> > > standard atomics. [1]
> > >
> > > [1] http://inbox.dpdk.org/dev/DBAPR08MB58148CEC3E1454E8848A938998AB9@DBAPR08MB5814.eurprd08.prod.outlook.com/
> > >
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > ---
> > > doc/guides/rel_notes/deprecation.rst | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > > index dcc1ca1696..9a391d2c49 100644
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > @@ -11,6 +11,12 @@ here.
> > > Deprecation Notices
> > > -------------------
> > >
> > > +* C Compiler: From DPDK 23.11 onwards,
> > > + building DPDK will require a C compiler which supports the C11 standard, or later.
> > > + Please note:
> > > + - C11 is supported from GCC version 5 onwards, and is the default language version in that release
> > > + - C11 is the default compilation mode in Clang from version 3.6
> > > +
> > > * kvargs: The function ``rte_kvargs_process`` will get a new parameter
> > > for returning key match count. It will ease handling of no-match case.
> > >
> >
> > This only applies to DPDK internals, right?
> > Application linked with DPDK library won't have this requirement,
> > meaning DPDK public headers won't rely on C99 and C11 features.
> >
> No, AFAIK, that is not correct. Originally I had thought that that would be
> the case - hence the special-case tests for the headers in my previous C99
> patch - but the consensus at the DPDK techboard was that we won't require
> all headers to remain C89 compatible.
>
this is my recollection as well, everything is being aligned to C11,
which is why we are waiting for 23.11 release before the changes can
come in.
> Originally, I was unsure about this, but now I agree with this position, on
> the basis that since GCC 5, unless you have been explicitly requesting an
> older standard, the compiler is using C11 rules. Therefore, everyone using
> these later GCC versions is already using C11+.
>
> /Bruce
next prev parent reply other threads:[~2023-05-03 16:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 15:14 Bruce Richardson
2023-05-03 15:35 ` Tyler Retzlaff
2023-05-03 15:37 ` Bruce Richardson
2023-05-03 15:39 ` Ferruh Yigit
2023-05-03 15:45 ` Tyler Retzlaff
2023-05-03 15:57 ` Bruce Richardson
2023-05-03 16:07 ` Tyler Retzlaff [this message]
2023-05-03 16:51 ` Ferruh Yigit
2023-05-03 17:30 ` [PATCH v2] " Bruce Richardson
2023-05-04 7:50 ` Mattias Rönnblom
2023-05-04 8:48 ` Bruce Richardson
2023-05-04 15:24 ` Tyler Retzlaff
2023-05-03 21:34 ` [PATCH] " Morten Brørup
2023-05-17 17:34 ` [PATCH v3] " Bruce Richardson
2023-05-19 12:19 ` Aaron Conole
2023-05-19 20:01 ` Tyler Retzlaff
2023-07-20 8:22 ` Bruce Richardson
2023-07-20 10:56 ` Jerin Jacob
2023-07-28 9:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230503160754.GB12879@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=techboard@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).