DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Arnaud Fiorini <arnaud.fiorini@polymtl.ca>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	Harry van Haaren <harry.van.haaren@intel.com>,
	Jerin Jacob <jerinj@marvell.com>,
	Sunil Kumar Kori <skori@marvell.com>,
	dev@dpdk.org
Subject: Re: [PATCH v2] eal: add tracepoints to track lcores and services
Date: Thu, 11 May 2023 15:18:50 -0700	[thread overview]
Message-ID: <20230511151850.58e1d5e9@hermes.local> (raw)
In-Reply-To: <c826ca46-c4e5-17b8-7dfb-35486171f34a@polymtl.ca>

On Thu, 11 May 2023 17:01:48 -0400
Arnaud Fiorini <arnaud.fiorini@polymtl.ca> wrote:

> On 2023-05-11 4:50 p.m., Stephen Hemminger wrote:
> > On Thu, 11 May 2023 20:16:28 +0000
> > Arnaud Fiorini <arnaud.fiorini@polymtl.ca> wrote:
> >  
> >> +The service core library is instrumented with tracepoints using the DPDK Trace
> >> +Library. These tracepoints allow you to track the service and logical cores
> >> +state. The tracepoints that are on the fast path are compiled out by default.
> >> +To activate the fast path tracepoints, it is necessary to add the
> >> +``enable_trace_fp`` option when building DPDK using meson.
> >> +
> >> +To activate tracing when launching a DPDK program it is necessary to use the
> >> +``--trace`` option to specify a regular expression to select which tracepoints
> >> +to enable. Here is an example if you want to only specify service core tracing::
> >> +
> >> +    ./dpdk/examples/service_cores/build/service_cores --trace="lib.eal.thread*" --trace="lib.eal.service*"
> >> +  
> > These state changes are not in the hot path. So they should always be available?  
> 
> Some of the tracepoints (rte_eal_trace_thread_lcore_running, 
> rte_eal_trace_thread_lcore_stopped, rte_eal_trace_service_run_begin) are 
> defined as fast path tracepoints. If these changes do not need to be in 
> the fast path, I can change their definition.
> 

Only inside the loop itself, ie polling is really fast path.
State transitions are not.

  reply	other threads:[~2023-05-11 22:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-11 20:16 Arnaud Fiorini
2023-05-11 20:50 ` Stephen Hemminger
2023-05-11 21:01   ` Arnaud Fiorini
2023-05-11 22:18     ` Stephen Hemminger [this message]
2023-05-12 14:30 ` [PATCH v3] " Arnaud Fiorini
2023-06-05 14:48   ` Arnaud Fiorini
2023-06-13  8:38   ` David Marchand
2023-06-13 10:00     ` Van Haaren, Harry
2023-06-21  8:25   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230511151850.58e1d5e9@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=arnaud.fiorini@polymtl.ca \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=jerinj@marvell.com \
    --cc=skori@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).