From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>
Subject: [PATCH v3 02/19] eal: replace use of sanity check in comments and messages
Date: Fri, 19 May 2023 10:45:54 -0700 [thread overview]
Message-ID: <20230519174611.11232-3-stephen@networkplumber.org> (raw)
In-Reply-To: <20230519174611.11232-1-stephen@networkplumber.org>
Sanity check is on the Tier 2 non-inclusive list.
Replace or remove it.
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/eal/common/eal_common_memory.c | 2 +-
lib/eal/common/eal_common_proc.c | 3 ++-
lib/eal/common/eal_common_trace.c | 2 +-
lib/eal/common/eal_memcfg.h | 2 +-
lib/eal/common/rte_malloc.c | 2 +-
lib/eal/freebsd/eal.c | 2 +-
lib/eal/linux/eal.c | 2 +-
lib/eal/windows/eal.c | 2 +-
8 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c
index e21fc7cfaecc..f99c6b43c885 100644
--- a/lib/eal/common/eal_common_memory.c
+++ b/lib/eal/common/eal_common_memory.c
@@ -560,7 +560,7 @@ check_dma_mask(uint8_t maskbits, bool thread_unsafe)
uint64_t mask;
int ret;
- /* Sanity check. We only check width can be managed with 64 bits
+ /* We only check width can be managed with 64 bits
* variables. Indeed any higher value is likely wrong. */
if (maskbits > MAX_DMA_MASK_BITS) {
RTE_LOG(ERR, EAL, "wrong dma mask size %u (Max: %u)\n",
diff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c
index 1fc1d6c53bd2..972f3269d8ae 100644
--- a/lib/eal/common/eal_common_proc.c
+++ b/lib/eal/common/eal_common_proc.c
@@ -309,7 +309,8 @@ read_msg(int fd, struct mp_msg_internal *m, struct sockaddr_un *s)
break;
}
}
- /* sanity-check the response */
+
+ /* Check that the response is valid */
if (m->msg.num_fds < 0 || m->msg.num_fds > RTE_MP_MAX_FD_NUM) {
RTE_LOG(ERR, EAL, "invalid number of fd's received\n");
return -1;
diff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c
index cb980af06d9f..cadb85b94fde 100644
--- a/lib/eal/common/eal_common_trace.c
+++ b/lib/eal/common/eal_common_trace.c
@@ -465,7 +465,7 @@ __rte_trace_point_register(rte_trace_point_t *handle, const char *name,
struct trace_point *tp;
uint16_t sz;
- /* Sanity checks of arguments */
+ /* Check arguments */
if (name == NULL || register_fn == NULL || handle == NULL) {
trace_err("invalid arguments");
rte_errno = EINVAL;
diff --git a/lib/eal/common/eal_memcfg.h b/lib/eal/common/eal_memcfg.h
index ea013a9daf17..dc7ef18dc11b 100644
--- a/lib/eal/common/eal_memcfg.h
+++ b/lib/eal/common/eal_memcfg.h
@@ -18,7 +18,7 @@
* Memory configuration shared across multiple processes.
*/
struct rte_mem_config {
- volatile uint32_t magic; /**< Magic number - sanity check. */
+ volatile uint32_t magic; /**< Magic number check. */
uint32_t version;
/**< Prevent secondary processes using different DPDK versions. */
diff --git a/lib/eal/common/rte_malloc.c b/lib/eal/common/rte_malloc.c
index ebafef3f6cf2..e632c395132c 100644
--- a/lib/eal/common/rte_malloc.c
+++ b/lib/eal/common/rte_malloc.c
@@ -654,7 +654,7 @@ rte_malloc_heap_destroy(const char *heap_name)
ret = -1;
goto unlock;
}
- /* sanity checks done, now we can destroy the heap */
+ /* checks done, now we can destroy the heap */
rte_spinlock_lock(&heap->lock);
ret = malloc_heap_destroy(heap);
rte_spinlock_unlock(&heap->lock);
diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index 7daf22e31449..d3499dd5906d 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -501,7 +501,7 @@ eal_parse_args(int argc, char **argv)
goto out;
}
- /* sanity checks */
+ /* options checks */
if (eal_check_common_options(internal_conf) != 0) {
eal_usage(prgname);
ret = -1;
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index ae323cd492d4..251aa533b274 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -803,7 +803,7 @@ eal_parse_args(int argc, char **argv)
goto out;
}
- /* sanity checks */
+ /* options checks */
if (eal_check_common_options(internal_conf) != 0) {
eal_usage(prgname);
ret = -1;
diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c
index 033825c14c67..17a5f9d1ba30 100644
--- a/lib/eal/windows/eal.c
+++ b/lib/eal/windows/eal.c
@@ -194,7 +194,7 @@ eal_parse_args(int argc, char **argv)
if (eal_adjust_config(internal_conf) != 0)
return -1;
- /* sanity checks */
+ /* options checks */
if (eal_check_common_options(internal_conf) != 0) {
eal_usage(prgname);
return -1;
--
2.39.2
next prev parent reply other threads:[~2023-05-19 17:46 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 16:15 [PATCH 00/20] Replace use of term sanity-check Stephen Hemminger
2023-05-17 16:15 ` [PATCH 01/20] mbuf: replace term sanity check Stephen Hemminger
2023-05-17 22:58 ` Morten Brørup
2023-05-22 6:52 ` Andrew Rybchenko
2023-05-17 16:15 ` [PATCH 02/20] eal: replace use of sanity check in comments and messages Stephen Hemminger
2023-05-18 11:39 ` Burakov, Anatoly
2023-05-17 16:15 ` [PATCH 03/20] net/ring: replace use of sanity Stephen Hemminger
2023-05-17 16:15 ` [PATCH 04/20] test: replace use word sanity Stephen Hemminger
2023-05-17 16:15 ` [PATCH 05/20] examples: remove term sanity Stephen Hemminger
2023-05-17 16:15 ` [PATCH 06/20] lib: replace use of sanity check in comments and messages Stephen Hemminger
2023-05-17 16:15 ` [PATCH 07/20] net/nfp: remove word sanity Stephen Hemminger
2023-05-18 1:37 ` Chaoyong He
2023-05-17 16:15 ` [PATCH 08/20] doc/eventdev_pipeline: remove sanity Stephen Hemminger
2023-05-17 16:15 ` [PATCH 09/20] net/fm10k, net/ixgbe: remove word sanity Stephen Hemminger
2023-05-17 16:15 ` [PATCH 10/20] net/mlx[45]: " Stephen Hemminger
2023-05-17 16:15 ` [PATCH 11/20] net/sfc: remove term "sanity check" Stephen Hemminger
2023-05-22 6:53 ` Andrew Rybchenko
2023-05-17 16:15 ` [PATCH 12/20] net/ark: replace use of term sanity Stephen Hemminger
2023-05-17 16:15 ` [PATCH 13/20] net/bnxt: " Stephen Hemminger
2023-05-17 16:15 ` [PATCH 14/20] net/bnx2x: remove reference to sanity Stephen Hemminger
2023-05-17 16:15 ` [PATCH 15/20] cnxk: replace term sanity Stephen Hemminger
2023-05-17 16:15 ` [PATCH 16/20] event/opdl: remove " Stephen Hemminger
2023-05-17 16:16 ` [PATCH 17/20] net/txgbe: replace " Stephen Hemminger
2023-05-17 16:16 ` [PATCH 18/20] net/cxgbe: remove use of " Stephen Hemminger
2023-05-17 16:16 ` [PATCH 19/20] crypto/bcmfs: replace term sanity check Stephen Hemminger
2023-05-17 16:16 ` [PATCH 20/20] Remove use of " Stephen Hemminger
2023-05-18 9:21 ` [EXT] " Devendra Singh Rawat
2023-05-18 10:24 ` Hemant Agrawal
2023-05-17 22:05 ` [PATCH 00/20] Replace use of term sanity-check Tyler Retzlaff
2023-05-18 16:45 ` [PATCH v2 00/19] Replace use of the " Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 01/19] mbuf: replace term sanity check Stephen Hemminger
2023-05-18 16:52 ` Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 02/19] eal: replace use of sanity check in comments and messages Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 03/19] test: replace use word sanity Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 04/19] examples: remove term sanity Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 05/19] lib: replace use of sanity check in comments and messages Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 06/19] doc/eventdev_pipeline: remove sanity Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 07/19] net/ring: replace use of sanity Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 08/19] net/fm10k, net/ixgbe: remove word sanity Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 09/19] net/mlx[45]: " Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 10/19] net/sfc: remove term "sanity check" Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 11/19] net/ark: replace use of term sanity Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 12/19] net/bnxt: " Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 13/19] net/bnx2x: remove reference to sanity Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 14/19] cnxk: replace term sanity Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 15/19] event/opdl: remove " Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 16/19] net/txgbe: replace " Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 17/19] net/cxgbe: remove use of " Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 18/19] crypto/bcmfs: replace term sanity check Stephen Hemminger
2023-05-18 16:45 ` [PATCH v2 19/19] Remove use of " Stephen Hemminger
2023-05-19 17:45 ` [PATCH v3 00/19] Replace use "sanity check" Stephen Hemminger
2023-05-19 17:45 ` [PATCH v3 01/19] mbuf: replace term sanity check Stephen Hemminger
2023-05-20 7:08 ` Morten Brørup
2023-05-22 6:54 ` Andrew Rybchenko
2023-05-19 17:45 ` Stephen Hemminger [this message]
2023-05-19 17:45 ` [PATCH v3 03/19] test: replace use word sanity Stephen Hemminger
2023-05-19 17:45 ` [PATCH v3 04/19] examples: remove term sanity Stephen Hemminger
2023-05-19 17:45 ` [PATCH v3 05/19] lib: replace use of sanity check in comments and messages Stephen Hemminger
2023-05-19 17:45 ` [PATCH v3 06/19] doc/eventdev_pipeline: remove sanity Stephen Hemminger
2023-05-19 17:45 ` [PATCH v3 07/19] net/ring: replace use of sanity Stephen Hemminger
2023-05-19 17:46 ` [PATCH v3 08/19] net/fm10k, net/ixgbe: remove word sanity Stephen Hemminger
2023-05-19 17:46 ` [PATCH v3 09/19] net/mlx[45]: " Stephen Hemminger
2023-05-19 17:46 ` [PATCH v3 10/19] net/sfc: remove term "sanity check" Stephen Hemminger
2023-05-22 6:54 ` Andrew Rybchenko
2023-05-19 17:46 ` [PATCH v3 11/19] net/ark: replace use of term sanity Stephen Hemminger
2023-05-19 17:46 ` [PATCH v3 12/19] net/bnxt: " Stephen Hemminger
2023-05-19 17:46 ` [PATCH v3 13/19] net/bnx2x: remove reference to sanity Stephen Hemminger
2023-05-19 17:46 ` [PATCH v3 14/19] cnxk: replace term sanity Stephen Hemminger
2023-05-19 17:46 ` [PATCH v3 15/19] event/opdl: remove " Stephen Hemminger
2023-05-19 17:46 ` [PATCH v3 16/19] net/txgbe: replace " Stephen Hemminger
2023-05-19 17:46 ` [PATCH v3 17/19] net/cxgbe: remove use of " Stephen Hemminger
2023-05-19 17:46 ` [PATCH v3 18/19] crypto/bcmfs: replace term sanity check Stephen Hemminger
2023-05-19 17:46 ` [PATCH v3 19/19] Remove use of " Stephen Hemminger
2023-05-19 20:12 ` [PATCH v3 00/19] Replace use "sanity check" Ajit Khaparde
2023-08-02 23:25 ` [PATCH v4 00/19] replace use of term " Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 01/19] mbuf: replace term sanity check Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 02/19] eal: replace use of sanity check in comments and messages Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 03/19] test: replace use word sanity Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 04/19] examples: remove term sanity Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 05/19] lib: replace use of sanity check in comments and messages Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 06/19] doc/eventdev_pipeline: remove sanity Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 07/19] net/ring: replace use of sanity Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 08/19] net/fm10k, net/ixgbe: remove word sanity Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 09/19] net/mlx[45]: " Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 10/19] net/sfc: remove term "sanity check" Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 11/19] net/ark: replace use of term sanity Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 12/19] net/bnxt: " Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 13/19] net/bnx2x: remove reference to sanity Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 14/19] cnxk: replace term sanity Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 15/19] event/opdl: remove " Stephen Hemminger
2023-08-21 15:52 ` Liang Ma
2023-08-02 23:25 ` [PATCH v4 16/19] net/txgbe: replace " Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 17/19] net/cxgbe: remove use of " Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 18/19] crypto/bcmfs: replace term sanity check Stephen Hemminger
2023-08-02 23:25 ` [PATCH v4 19/19] drivers: remove use of " Stephen Hemminger
2023-08-03 3:13 ` [EXT] " Devendra Singh Rawat
2023-11-29 17:25 ` [PATCH v5 00/19] remove use of the term "sanity check" Stephen Hemminger
2023-11-29 17:25 ` [PATCH v5 01/19] mbuf: replace term sanity check Stephen Hemminger
2023-11-29 17:25 ` [PATCH v5 02/19] eal: replace use of sanity check in comments and messages Stephen Hemminger
2023-11-29 17:25 ` [PATCH v5 03/19] test: replace use word sanity Stephen Hemminger
2023-11-30 5:48 ` Hemant Agrawal
2023-11-29 17:25 ` [PATCH v5 04/19] examples: remove term sanity Stephen Hemminger
2023-11-29 17:25 ` [PATCH v5 05/19] lib: replace use of sanity check in comments and messages Stephen Hemminger
2023-11-29 17:26 ` [PATCH v5 06/19] doc/eventdev_pipeline: remove sanity Stephen Hemminger
2023-11-29 17:26 ` [PATCH v5 07/19] net/ring: replace use of sanity Stephen Hemminger
2023-11-29 17:26 ` [PATCH v5 08/19] net/fm10k, net/ixgbe: remove word sanity Stephen Hemminger
2023-11-29 17:26 ` [PATCH v5 09/19] net/mlx[45]: " Stephen Hemminger
2023-12-07 8:50 ` Dariusz Sosnowski
2023-11-29 17:26 ` [PATCH v5 10/19] net/sfc: remove term "sanity check" Stephen Hemminger
2023-11-29 17:26 ` [PATCH v5 11/19] net/ark: replace use of term sanity Stephen Hemminger
2023-11-29 17:26 ` [PATCH v5 12/19] net/bnxt: " Stephen Hemminger
2023-11-30 3:31 ` Somnath Kotur
2023-11-29 17:26 ` [PATCH v5 13/19] net/bnx2x: remove reference to sanity Stephen Hemminger
2023-11-29 17:26 ` [PATCH v5 14/19] cnxk: replace term sanity Stephen Hemminger
2023-11-29 17:26 ` [PATCH v5 15/19] event/opdl: remove " Stephen Hemminger
2023-11-29 17:26 ` [PATCH v5 16/19] net/txgbe: replace " Stephen Hemminger
2023-11-29 17:26 ` [PATCH v5 17/19] net/cxgbe: remove use of " Stephen Hemminger
2023-11-29 17:26 ` [PATCH v5 18/19] crypto/bcmfs: replace term sanity check Stephen Hemminger
2023-11-29 17:26 ` [PATCH v5 19/19] drivers: remove use of " Stephen Hemminger
2023-11-30 1:21 ` Chaoyong He
2023-11-30 2:14 ` [EXT] " Devendra Singh Rawat
2023-11-30 5:37 ` Hemant Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230519174611.11232-3-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=jerinj@marvell.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=skori@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).