From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH 00/25] replace snprintf with strlcpy
Date: Fri, 2 Jun 2023 13:01:45 -0700 [thread overview]
Message-ID: <20230602200145.GA28889@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org>
On Thu, Jun 01, 2023 at 08:00:41AM -0700, Stephen Hemminger wrote:
> This patch series was generated by using the existing
> Coccinelle script to find where snprintf() is used but
> strlcpy() could be used instead.
i guess the motivation here is strlcpy is safer to use than the portable
snprintf? not objecting, just confirming.
>
> Manually replaced fixed some trigraphs and paren's where
> needed. Also one instance the whole temporary string
> copy was not needed at all.
>
> Stephen Hemminger (25):
> app: use strlcpy in tests
> examples: use strlcpy instead of snprintf
> lib: use strlcpy instead of snprintf
> raw/ifpga: replace snprintf with strlcpy
> common/cnxk: replace snprint with strlcpy
> common/mlx5: replace snprintf with strlcpy
> drivers/gpu: replace snprintf with strlcpy
> crypto/ipsec_mb: remove unnecessary snprintf
> crypto/dpaa_sec: replace snprintf with strlcpy
> event/cnxk: replace snprintf with strlcpy
> net/atlantic: replace snprintf with strlcpy
> net/axgbe: replace snprintf with strlcpy
> net/bnxt: replace snprintf with strlcpy
> net/cpfl: replace snprintf with strlcpy
> net/cxgbe: replace snprintf with strlcpy
> net/dpaa*: replace snprintf with strlcpy
> net/hinic: replace snptintf with strlcpy
> net/hns3: replace snprint with strlcpy
> net/intel: replace snprintf with strlcpy
> net/ionic: replace snprintf with strlcpy
> net/mlx5: replace snprintf with strlcpy
> net/nfp: replace snprintf with strlcpy
> net/ngbe: replace snprintf with strlcpy
> net/qede: replace snprintf with strlcpy
> net/txgbe: replace snprintf with strlcpy
>
> app/test-bbdev/main.c | 5 ++--
> app/test-pmd/cmdline_flow.c | 6 ++--
> app/test/process.h | 2 +-
> app/test/test_graph_perf.c | 29 ++++++++++---------
> drivers/common/cnxk/roc_nix_stats.c | 4 +--
> drivers/common/mlx5/linux/mlx5_common_os.c | 2 +-
> drivers/common/mlx5/mlx5_common_utils.c | 5 ++--
> drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +-
> drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 7 +----
> drivers/event/cnxk/cnxk_eventdev_stats.c | 11 ++++---
> drivers/gpu/cuda/cuda.c | 2 +-
> drivers/gpu/cuda/gdrcopy.c | 2 +-
> drivers/net/atlantic/atl_ethdev.c | 5 ++--
> drivers/net/axgbe/axgbe_ethdev.c | 6 ++--
> drivers/net/bnxt/bnxt_ethdev.c | 8 ++---
> drivers/net/cpfl/cpfl_ethdev.c | 6 ++--
> drivers/net/cxgbe/cxgbe_ethdev.c | 9 +++---
> drivers/net/dpaa/dpaa_ethdev.c | 8 ++---
> drivers/net/dpaa2/dpaa2_ethdev.c | 8 ++---
> drivers/net/fm10k/fm10k_ethdev.c | 6 ++--
> drivers/net/hinic/base/hinic_compat.h | 1 +
> drivers/net/hinic/base/hinic_pmd_niccfg.c | 4 +--
> drivers/net/hinic/hinic_pmd_ethdev.c | 14 ++++-----
> drivers/net/hns3/hns3_fdir.c | 2 +-
> drivers/net/hns3/hns3_rxtx.c | 8 ++---
> drivers/net/hns3/hns3_stats.c | 22 +++++++-------
> drivers/net/i40e/i40e_rxtx.c | 8 ++---
> drivers/net/iavf/iavf_ethdev.c | 6 ++--
> drivers/net/ice/ice_dcf_ethdev.c | 6 ++--
> drivers/net/ice/ice_rxtx.c | 8 ++---
> drivers/net/idpf/idpf_ethdev.c | 6 ++--
> drivers/net/ionic/ionic_ethdev.c | 15 +++++-----
> drivers/net/ipn3ke/ipn3ke_representor.c | 17 +++++------
> drivers/net/mlx5/mlx5_rx.c | 16 +++++-----
> .../net/nfp/flower/nfp_flower_representor.c | 4 +--
> drivers/net/ngbe/ngbe_rxtx.c | 8 ++---
> drivers/net/qede/qede_ethdev.c | 10 +++----
> drivers/net/txgbe/txgbe_ethdev_vf.c | 6 ++--
> drivers/raw/ifpga/afu_pmd_core.c | 3 +-
> examples/fips_validation/fips_validation.c | 8 ++---
> examples/l3fwd-graph/main.c | 2 +-
> examples/pipeline/cli.c | 2 +-
> examples/vhost_blk/vhost_blk.c | 5 ++--
> lib/bbdev/rte_bbdev.c | 2 +-
> lib/ethdev/sff_8636.c | 11 ++++---
> 45 files changed, 157 insertions(+), 170 deletions(-)
>
> --
> 2.39.2
prev parent reply other threads:[~2023-06-02 20:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 15:00 Stephen Hemminger
2023-06-01 15:00 ` [PATCH 01/25] app: use strlcpy in tests Stephen Hemminger
2023-06-01 15:00 ` [PATCH 02/25] examples: use strlcpy instead of snprintf Stephen Hemminger
2023-06-01 15:00 ` [PATCH 03/25] lib: " Stephen Hemminger
2023-06-01 15:00 ` [PATCH 04/25] raw/ifpga: replace snprintf with strlcpy Stephen Hemminger
2023-06-02 6:04 ` Xu, Rosen
2023-06-01 15:00 ` [PATCH 05/25] common/cnxk: replace snprint " Stephen Hemminger
2023-06-01 15:00 ` [PATCH 06/25] common/mlx5: replace snprintf " Stephen Hemminger
2023-06-01 15:00 ` [PATCH 07/25] drivers/gpu: " Stephen Hemminger
2023-06-01 15:00 ` [PATCH 08/25] crypto/ipsec_mb: remove unnecessary snprintf Stephen Hemminger
2023-06-01 15:00 ` [PATCH 09/25] crypto/dpaa_sec: replace snprintf with strlcpy Stephen Hemminger
2023-06-02 4:24 ` Hemant Agrawal
2023-06-01 15:00 ` [PATCH 10/25] event/cnxk: " Stephen Hemminger
2023-06-01 15:00 ` [PATCH 11/25] net/atlantic: " Stephen Hemminger
2023-06-01 15:00 ` [PATCH 12/25] net/axgbe: " Stephen Hemminger
2023-06-01 15:00 ` [PATCH 13/25] net/bnxt: " Stephen Hemminger
2023-06-01 15:00 ` [PATCH 14/25] net/cpfl: " Stephen Hemminger
2023-06-01 15:00 ` [PATCH 15/25] net/cxgbe: " Stephen Hemminger
2023-06-01 15:00 ` [PATCH 16/25] net/dpaa*: " Stephen Hemminger
2023-06-02 4:24 ` Hemant Agrawal
2023-06-01 15:00 ` [PATCH 17/25] net/hinic: replace snptintf " Stephen Hemminger
2023-06-01 15:00 ` [PATCH 18/25] net/hns3: replace snprint " Stephen Hemminger
2023-06-01 15:01 ` [PATCH 19/25] net/intel: replace snprintf " Stephen Hemminger
2023-06-01 15:01 ` [PATCH 20/25] net/ionic: " Stephen Hemminger
2023-06-02 6:05 ` Xu, Rosen
2023-06-01 15:01 ` [PATCH 21/25] net/mlx5: " Stephen Hemminger
2023-06-01 15:01 ` [PATCH 22/25] net/nfp: " Stephen Hemminger
2023-06-05 11:10 ` Niklas Söderlund
2023-06-01 15:01 ` [PATCH 23/25] net/ngbe: " Stephen Hemminger
2023-06-01 15:01 ` [PATCH 24/25] net/qede: " Stephen Hemminger
2023-06-01 15:01 ` [PATCH 25/25] net/txgbe: " Stephen Hemminger
2023-06-02 20:01 ` Tyler Retzlaff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602200145.GA28889@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).