From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: Dongdong Liu <liudongdong3@huawei.com>, dev@dpdk.org
Subject: Re: [PATCH] doc: deprecation notice to add RSS hash algorithm field
Date: Tue, 6 Jun 2023 09:35:42 -0700 [thread overview]
Message-ID: <20230606093542.351884fe@hermes.local> (raw)
In-Reply-To: <6e9dd06f-6f90-b80f-7f26-3b8c58ea2036@amd.com>
On Tue, 6 Jun 2023 16:50:53 +0100
Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> On 6/6/2023 4:39 PM, Stephen Hemminger wrote:
> > On Tue, 6 Jun 2023 20:11:26 +0800
> > Dongdong Liu <liudongdong3@huawei.com> wrote:
> >
> >> Deprecation notice to add "func" field to ``rte_eth_rss_conf``
> >> structure for RSS hash algorithm.
> >>
> >> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
> >> ---
> >
> > New fields do not require deprecation notice.
> > Since this seems to be a repeated issue, perhaps someone should
> > add this to the documentation.
> >
>
>
> Hi Stephen,
>
> This is follow up to an existing patchset:
> https://patches.dpdk.org/project/dpdk/list/?series=27400&state=*
>
> Although field is addition to the "struct rte_eth_rss_conf" struct, it
> is embedded into "struct rte_eth_conf" which is parameter to an API, so
> change cause size increase in outer struct and causes ABI breakage,
> requiring deprecation notice.
It will change ABI so will have to wait for 23.11.
But the purpose of deprecation notice is more about telling users that API
will change.
The automated tools may give false complaint. Ok to add to deprecation,
but really not necessary.
next prev parent reply other threads:[~2023-06-06 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 12:11 Dongdong Liu
2023-06-06 15:39 ` Stephen Hemminger
2023-06-06 15:50 ` Ferruh Yigit
2023-06-06 16:35 ` Stephen Hemminger [this message]
2023-07-28 15:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606093542.351884fe@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=liudongdong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).