From: Stephen Hemminger <stephen@networkplumber.org>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"alanrobertsonatt@gmail.com" <alanrobertsonatt@gmail.com>,
"dev@dpdk.org" <dev@dpdk.org>, Alan Robertson <ar771e@att.com>,
Alan Robertson <alan.robertson@att.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>
Subject: Re: [dpdk-dev] [PATCH] Improve the shaper accuracy for large packets
Date: Sat, 10 Jun 2023 19:45:26 -0700 [thread overview]
Message-ID: <20230610194526.1ab7ee81@hermes.local> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E8727B1@IRSMSX108.ger.corp.intel.com>
On Mon, 8 Apr 2019 13:36:14 +0000
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com> wrote:
> > -----Original Message-----
> > From: Yigit, Ferruh
> > Sent: Friday, April 5, 2019 4:54 PM
> > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> > Cc: alanrobertsonatt@gmail.com; dev@dpdk.org; Alan Robertson
> > <ar771e@att.com>; Alan Robertson <alan.robertson@att.com>; Thomas
> > Monjalon <thomas@monjalon.net>
> > Subject: Re: [dpdk-dev] [PATCH] Improve the shaper accuracy for large
> > packets
> >
> > On 2/9/2018 10:38 AM, alanrobertsonatt@gmail.com wrote:
> > > From: Alan Robertson <ar771e@att.com>
> > >
> > > There were 2 issues, the first was time could be lost whilst updating
> > > the traffic-class period, the second was a frame could be delayed if
> > > not enough tokens were available for the full frame. By allowing the
> > > shaper to borrow credit from the next period the throughput is improved.
> > >
> > > Signed-off-by: Alan Robertson <alan.robertson@att.com>
> >
> >
> > Hi Cristian,
> >
> > Another 'librte_sched' patch waiting for a review for almost a year now, do
> > you
> > know status of this patch?
> >
> > Thanks,
> > ferruh
>
> As previously announced, we are planning to do some improvements on this part of the code [1] and we are planning improve this behavior in a way that is less intrusive and has slightly better performance (due to no branches).
>
> Regards,
> Cristian
>
> [1] https://mails.dpdk.org/archives/dev/2018-November/120035.html
>
This patch is quite old. It looks the original issue was that rte_sched_port_dequeue
is racy if port is shared by multiple lcore's. The only update to port->time
happens in rte_sched_port_time_resync() frin rte_sched_port_dequeue().
The warnings about thread safety in qos_framework.rst could be improved, but that
is something for another patch in future.
next prev parent reply other threads:[~2023-06-11 2:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 10:38 alanrobertsonatt
2019-04-05 15:54 ` Ferruh Yigit
2019-04-05 15:54 ` Ferruh Yigit
2019-04-08 13:36 ` Dumitrescu, Cristian
2019-04-08 13:36 ` Dumitrescu, Cristian
2023-06-11 2:45 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-02-09 10:26 alanrobertsonatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230610194526.1ab7ee81@hermes.local \
--to=stephen@networkplumber.org \
--cc=alan.robertson@att.com \
--cc=alanrobertsonatt@gmail.com \
--cc=ar771e@att.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jasvinder.singh@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).