From: Jiawen Wu <jiawenwu@trustnetic.com>
To: dev@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>, stable@dpdk.org
Subject: [PATCH 7/9] net/ngbe: fix issues caused by MNG veto bit setting
Date: Wed, 14 Jun 2023 10:34:27 +0800 [thread overview]
Message-ID: <20230614023429.1002071-8-jiawenwu@trustnetic.com> (raw)
In-Reply-To: <20230614023429.1002071-1-jiawenwu@trustnetic.com>
In the new firmware, MNG veto bit is set by default for new features. It
causes the PHY configuration not to be reset after LAN reset. So PHY power
will be down after stopping device. The internal PHY then cannot be
initialized successfully at device start. Add setting power on for internal
PHY to fix this issue.
Fixes: abea8974c7a6 ("net/ngbe: support link down/up")
Cc: stable@dpdk.org
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/ngbe/base/ngbe_phy_rtl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ngbe/base/ngbe_phy_rtl.c b/drivers/net/ngbe/base/ngbe_phy_rtl.c
index 9b323624ec..88bacec114 100644
--- a/drivers/net/ngbe/base/ngbe_phy_rtl.c
+++ b/drivers/net/ngbe/base/ngbe_phy_rtl.c
@@ -120,6 +120,8 @@ s32 ngbe_init_phy_rtl(struct ngbe_hw *hw)
hw->init_phy = true;
msec_delay(1);
+ hw->phy.set_phy_power(hw, true);
+
for (i = 0; i < 15; i++) {
if (!rd32m(hw, NGBE_STAT,
NGBE_STAT_GPHY_IN_RST(hw->bus.lan_id)))
--
2.27.0
next prev parent reply other threads:[~2023-06-14 2:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230614023429.1002071-1-jiawenwu@trustnetic.com>
2023-06-14 2:34 ` [PATCH 1/9] net/txgbe: fix Tx failure with fiber hotplug Jiawen Wu
2023-06-14 2:34 ` [PATCH 2/9] net/txgbe: fix interrupt enable mask Jiawen Wu
2023-06-14 2:34 ` [PATCH 3/9] net/txgbe: fix issues caused by MNG veto bit setting Jiawen Wu
2023-06-14 2:34 ` [PATCH 4/9] net/txgbe: fix to set autoneg for 1G speed Jiawen Wu
2023-06-14 2:34 ` [PATCH 5/9] net/txgbe: fix device extended stats Jiawen Wu
2023-06-14 2:34 ` [PATCH 6/9] net/ngbe: " Jiawen Wu
2023-06-14 2:34 ` Jiawen Wu [this message]
2023-06-14 2:34 ` [PATCH 8/9] net/ngbe: fix link status in no LSC mode Jiawen Wu
2023-06-14 2:34 ` [PATCH 9/9] net/ngbe: remove redundant codes Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614023429.1002071-8-jiawenwu@trustnetic.com \
--to=jiawenwu@trustnetic.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).