DPDK patches and discussions
 help / color / mirror / Atom feed
From: Abhijit Gangurde <abhijit.gangurde@amd.com>
To: <Nipun.Gupta@amd.com>, <nikhil.agarwal@amd.com>
Cc: <dev@dpdk.org>, <david.marchand@redhat.com>,
	<ferruh.yigit@amd.com>,
	Abhijit Gangurde <abhijit.gangurde@amd.com>,
	Nipun Gupta <nipun.gupta@amd.com>
Subject: [PATCH v2 1/3] bus/cdx: remove ineffective code statement
Date: Fri, 16 Jun 2023 18:09:08 +0530	[thread overview]
Message-ID: <20230616123910.1110724-2-abhijit.gangurde@amd.com> (raw)
In-Reply-To: <20230616123910.1110724-1-abhijit.gangurde@amd.com>

Remove ineffective code statement ret = 0 since it is
overwritten in a loop.

Coverity issue: 385379
Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus")
Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
Acked-by: Nipun Gupta <nipun.gupta@amd.com>
---
 v2:
 - Updated commit message

 drivers/bus/cdx/cdx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c
index 28bbf92ed5..9130c30515 100644
--- a/drivers/bus/cdx/cdx.c
+++ b/drivers/bus/cdx/cdx.c
@@ -452,7 +452,6 @@ cdx_probe(void)
 				dev->name);
 			rte_errno = errno;
 			failed++;
-			ret = 0;
 		}
 	}
 
-- 
2.25.1


  reply	other threads:[~2023-06-16 12:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16 12:39 [PATCH v2 0/3] bus/cdx: fix coverity issue Abhijit Gangurde
2023-06-16 12:39 ` Abhijit Gangurde [this message]
2023-06-16 12:39 ` [PATCH v2 2/3] bus/cdx: move debug print before unmapping resource Abhijit Gangurde
2023-06-16 12:39 ` [PATCH v2 3/3] bus/cdx: fix resource leak Abhijit Gangurde
2023-06-19  3:58 ` [PATCH v2 0/3] bus/cdx: fix coverity issue Nipun Gupta
2023-06-27 21:22   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230616123910.1110724-2-abhijit.gangurde@amd.com \
    --to=abhijit.gangurde@amd.com \
    --cc=Nipun.Gupta@amd.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=nikhil.agarwal@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).