From: Stephen Hemminger <stephen@networkplumber.org>
To: Shinae Woo <shinae@alkira.net>
Cc: dev@dpdk.org
Subject: Re: [PATCH] linux/igb_uio: make module parameters visible in sysfs
Date: Wed, 5 Jul 2023 19:40:36 -0700 [thread overview]
Message-ID: <20230705194036.0f1ad691@hermes.local> (raw)
In-Reply-To: <20220821221213.9591-1-shinae@alkira.net>
On Sun, 21 Aug 2022 15:12:13 -0700
Shinae Woo <shinae@alkira.net> wrote:
> - explicitly set default value for intr_mode
> - give read permission on wc_activate
> - applying patch gives below visibility
>
> ```
> $ more /sys/module/igb_uio/parameters/* | cat
> ::::::::::::::
> /sys/module/igb_uio/parameters/intr_mode
> ::::::::::::::
> msix
> ::::::::::::::
> /sys/module/igb_uio/parameters/wc_activate
> ::::::::::::::
> 0
> ```
>
> Signed-off-by: Shinae Woo <shinae@alkira.net>
Looks ok.
This would have to go against dpdk-kmods tree.
Checkpatch is being overly picky here
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2023-07-06 2:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 22:12 Shinae Woo
2023-07-06 2:40 ` Stephen Hemminger [this message]
2022-08-21 23:19 Shinae Woo
2023-10-31 16:59 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705194036.0f1ad691@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=shinae@alkira.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).