DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: okaya@kernel.org
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 00/10] codeql fixes for various subsystems
Date: Thu, 6 Jul 2023 15:43:26 -0700	[thread overview]
Message-ID: <20230706154326.4b7c408f@hermes.local> (raw)
In-Reply-To: <20230120044140.95975-1-okaya@kernel.org>

On Thu, 19 Jan 2023 23:41:30 -0500
okaya@kernel.org wrote:

> From: Sinan Kaya <okaya@kernel.org>
> 
> Following up the codeql reported problems first submitted
> by Stephen Hemminger here:
> 
> https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/
> 
> Posting a series of fixes about potential null pointer accesses.
> 
> Changes from v3:
> - Dropped net/tap: check if name is null
> - Moved the comment to the appropriate position in ethdev: check return result of rte_eth_dev_info_get
> 
> Changes from v2:
> - Remove braces around single line statements
> - use NULL comparisons
> 
> 
> Sinan Kaya (10):
>   ethdev: check return result of rte_eth_dev_info_get
>   memzone: check result of rte_fbarray_get
>   memzone: check result of malloc_elem_from_data
>   malloc: malloc_elem_join_adjacent_free can return null
>   malloc: check result of rte_mem_virt2memseg_list
>   malloc: check result of rte_fbarray_get
>   malloc: check result of rte_mem_virt2memseg
>   malloc: check result of malloc_elem_free
>   malloc: check result of elem_start_pt
>   bus/vdev: check result of rte_vdev_device_name
> 
>  lib/eal/common/eal_common_memalloc.c |  5 ++++-
>  lib/eal/common/eal_common_memzone.c  | 10 +++++++++-
>  lib/eal/common/malloc_elem.c         | 14 +++++++++++---
>  lib/eal/common/malloc_heap.c         |  9 ++++++++-
>  lib/ethdev/ethdev_vdev.h             |  2 ++
>  lib/ethdev/rte_class_eth.c           |  4 +++-
>  6 files changed, 37 insertions(+), 7 deletions(-)

The patches are fine, only warning was from the requirement that all
submitters be in .mailmap now.  Do you mind if I rebase these, add a mailmap
and combine the like ones together?

Acked-by: Stephen Hemminger <stephen@networkplumber.org>



  parent reply	other threads:[~2023-07-06 22:43 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20  4:41 okaya
2023-01-20  4:41 ` [PATCH v3 01/10] ethdev: check return result of rte_eth_dev_info_get okaya
2023-01-20 10:21   ` Morten Brørup
2023-01-20  4:41 ` [PATCH v3 02/10] memzone: check result of rte_fbarray_get okaya
2023-01-20  4:41 ` [PATCH v3 03/10] memzone: check result of malloc_elem_from_data okaya
2023-01-20  4:41 ` [PATCH v3 04/10] malloc: malloc_elem_join_adjacent_free can return null okaya
2023-01-20  4:41 ` [PATCH v3 05/10] malloc: check result of rte_mem_virt2memseg_list okaya
2023-01-20  4:41 ` [PATCH v3 06/10] malloc: check result of rte_fbarray_get okaya
2023-01-20  4:41 ` [PATCH v3 07/10] malloc: check result of rte_mem_virt2memseg okaya
2023-01-20  4:41 ` [PATCH v3 08/10] malloc: check result of malloc_elem_free okaya
2023-01-20  4:41 ` [PATCH v3 09/10] malloc: check result of elem_start_pt okaya
2023-01-20  4:41 ` [PATCH v3 10/10] bus/vdev: check result of rte_vdev_device_name okaya
2023-01-20 16:47   ` Stephen Hemminger
2023-01-22 20:51     ` Thomas Monjalon
2023-02-06 16:01       ` Sinan Kaya
2023-02-06 18:46         ` Thomas Monjalon
2023-02-06 16:00 ` [PATCH v3 00/10] codeql fixes for various subsystems Sinan Kaya
2023-07-06 22:43 ` Stephen Hemminger [this message]
2023-07-10 15:18   ` Sinan Kaya
2023-07-10 17:07 ` [PATCH v4 0/5] fixes for problems found by codeql analyzer Stephen Hemminger
2023-07-10 17:07   ` [PATCH v4 1/5] mailmap: add Sinan Stephen Hemminger
2023-07-10 17:07   ` [PATCH v4 2/5] ethdev: check return result of rte_eth_dev_info_get Stephen Hemminger
2023-12-16 10:06     ` Andrew Rybchenko
2023-12-16 10:08       ` Andrew Rybchenko
2023-07-10 17:07   ` [PATCH v4 3/5] memzone: check result of rte_fbarray_get and malloc_elem_from_data Stephen Hemminger
2023-07-10 17:07   ` [PATCH v4 4/5] malloc: codeql fixes Stephen Hemminger
2023-07-10 17:08   ` [PATCH v4 5/5] bus/vdev: check result of rte_vdev_device_name Stephen Hemminger
2023-12-16 10:10     ` Andrew Rybchenko
2023-07-11  1:37   ` [PATCH v4 0/5] fixes for problems found by codeql analyzer fengchengwen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230706154326.4b7c408f@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=okaya@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).