From: Stephen Hemminger <stephen@networkplumber.org>
To: Amit Prakash Shukla <amitprakashs@marvell.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>,
"navasile@linux.microsoft.com" <navasile@linux.microsoft.com>,
"dmitrym@microsoft.com" <dmitrym@microsoft.com>
Subject: Re: [EXT] Re: [PATCH] build: enable static analyzer
Date: Thu, 6 Jul 2023 15:59:30 -0700 [thread overview]
Message-ID: <20230706155930.34519c64@hermes.local> (raw)
In-Reply-To: <PH0PR18MB5167DCED917BC3CAD968ECE8C88B9@PH0PR18MB5167.namprd18.prod.outlook.com>
On Fri, 15 Jul 2022 12:05:41 +0000
Amit Prakash Shukla <amitprakashs@marvell.com> wrote:
> Thanks Bruce for the review. Please find my comments in-line.
>
> > -----Original Message-----
> > From: Bruce Richardson <bruce.richardson@intel.com>
> > Sent: Thursday, July 14, 2022 4:31 PM
> > To: Amit Prakash Shukla <amitprakashs@marvell.com>
> > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> > thomas@monjalon.net; david.marchand@redhat.com;
> > dmitry.kozliuk@gmail.com; navasile@linux.microsoft.com;
> > dmitrym@microsoft.com
> > Subject: [EXT] Re: [PATCH] build: enable static analyzer
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > On Thu, Jul 14, 2022 at 12:57:22PM +0530, Amit Prakash Shukla wrote:
> > > This patch adds support to enable compiler static analyzer for gcc and
> > > clang.
> > >
> > > Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
> > > ---
> > > config/meson.build | 14 ++++++++++++++
> > > doc/guides/prog_guide/index.rst | 1 +
> > > doc/guides/prog_guide/static_analyzer.rst | 21
> > +++++++++++++++++++++
> > > meson_options.txt | 2 ++
> > > 4 files changed, 38 insertions(+)
> > > create mode 100644 doc/guides/prog_guide/static_analyzer.rst
> > >
> > > diff --git a/config/meson.build b/config/meson.build index
> > > 7f7b6c92fd..1154396326 100644
> > > --- a/config/meson.build
> > > +++ b/config/meson.build
> > > @@ -440,6 +440,20 @@ if get_option('b_sanitize') == 'address' or
> > get_option('b_sanitize') == 'address
> > > endif
> > > endif
> > >
> > > +if get_option('static_analyzer')
> > > + if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.1.0')
> > > + add_project_arguments('-fanalyzer', language: 'c')
> >
> > Rather than checking for specific compiler versions, we should instead just
> > check for particular flags and use those.
>
> Sure, I will make the change as part of v2 patch.
Never saw a v2 of this patch??
prev parent reply other threads:[~2023-07-06 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 7:27 Amit Prakash Shukla
2022-07-14 11:01 ` Bruce Richardson
2022-07-15 12:05 ` [EXT] " Amit Prakash Shukla
2023-07-06 22:59 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706155930.34519c64@hermes.local \
--to=stephen@networkplumber.org \
--cc=amitprakashs@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=jerinj@marvell.com \
--cc=navasile@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).