From: Stephen Hemminger <stephen@networkplumber.org>
To: Alexander Kozyrev <akozyrev@nvidia.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>, <rasland@nvidia.com>,
<viacheslavo@nvidia.com>, <matan@nvidia.com>
Subject: Re: [PATCH 3/3] app/testpmd: fix meter mark handle update
Date: Tue, 11 Jul 2023 09:15:00 -0700 [thread overview]
Message-ID: <20230711091500.4aa15bf7@hermes.local> (raw)
In-Reply-To: <20230711152044.3141138-3-akozyrev@nvidia.com>
On Tue, 11 Jul 2023 18:20:44 +0300
Alexander Kozyrev <akozyrev@nvidia.com> wrote:
> + case RTE_FLOW_ACTION_TYPE_METER_MARK:
> + rte_memcpy(&mtr_update.meter_mark, action->conf,
> + sizeof(struct rte_flow_action_meter_mark));
Why use rte_memcpy? memcpy of fixed size is faster.
Also, more static checkers know what memcpy is.
next prev parent reply other threads:[~2023-07-11 20:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 15:20 [PATCH 1/3] net/mlx5: fix validation for conntrack indirect action Alexander Kozyrev
2023-07-11 15:20 ` [PATCH 2/3] net/mlx5: fix handle validation for meter mark Alexander Kozyrev
2023-07-18 9:02 ` Suanming Mou
2023-07-11 15:20 ` [PATCH 3/3] app/testpmd: fix meter mark handle update Alexander Kozyrev
2023-07-11 16:15 ` Stephen Hemminger [this message]
2023-07-18 13:27 ` Alexander Kozyrev
2023-07-18 9:01 ` [PATCH 1/3] net/mlx5: fix validation for conntrack indirect action Suanming Mou
2023-07-18 13:32 ` [PATCH v2 " Alexander Kozyrev
2023-07-18 13:32 ` [PATCH v2 2/3] net/mlx5: fix handle validation for meter mark Alexander Kozyrev
2023-07-18 14:31 ` Ori Kam
2023-07-18 13:32 ` [PATCH v2 3/3] app/testpmd: fix meter mark handle update Alexander Kozyrev
2023-07-18 14:32 ` Ori Kam
2023-07-18 14:29 ` [PATCH v2 1/3] net/mlx5: fix validation for conntrack indirect action Ori Kam
2023-07-18 15:51 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711091500.4aa15bf7@hermes.local \
--to=stephen@networkplumber.org \
--cc=akozyrev@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).