From: okaya@kernel.org
Cc: dev@dpdk.org, Graham Whyte <grwhyte@microsoft.com>,
Sinan Kaya <okaya@kernel.org>
Subject: [PATCH v1 1/7] eal: fixes for re-initialization issues
Date: Mon, 14 Aug 2023 21:38:20 -0400 [thread overview]
Message-ID: <20230815013826.1288972-2-okaya@kernel.org> (raw)
In-Reply-To: <20230815013826.1288972-1-okaya@kernel.org>
From: Graham Whyte <grwhyte@microsoft.com>
reinitialize the solib link list and clean the globals holding
state for parsing.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Signed-off by: Graham Whyte <graham.whyte@microsoft.com>
---
lib/eal/common/eal_common_options.c | 7 +++++++
lib/eal/linux/eal.c | 4 +++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c
index 2d6535781b..b58df1bc5f 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -1983,6 +1983,13 @@ compute_ctrl_threads_cpuset(struct internal_config *internal_cfg)
memcpy(cpuset, &lcore_config[rte_get_main_lcore()].cpuset,
sizeof(*cpuset));
}
+
+ // Reinitialize solib_list
+ TAILQ_INIT(&solib_list);
+
+ master_lcore_parsed = 0;
+ mem_parsed = 0;
+ core_parsed = 0;
}
int
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index 8c118d0d9f..5fd81d71cb 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -78,6 +78,8 @@ struct lcore_config lcore_config[RTE_MAX_LCORE];
int rte_cycles_vmware_tsc_map;
+static uint32_t run_once = 0;
+
int
eal_clean_runtime_dir(void)
{
@@ -504,6 +506,7 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg)
socket_arg[i] = val;
}
+ __atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);
return 0;
}
@@ -960,7 +963,6 @@ int
rte_eal_init(int argc, char **argv)
{
int i, fctret, ret;
- static uint32_t run_once;
uint32_t has_run = 0;
const char *p;
static char logid[PATH_MAX];
--
2.25.1
next prev parent reply other threads:[~2023-08-15 1:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 1:38 [PATCH v1 0/7] support reinit flow okaya
2023-08-15 1:38 ` okaya [this message]
2023-08-15 2:21 ` [PATCH v1 1/7] eal: fixes for re-initialization issues Stephen Hemminger
2023-08-15 2:24 ` Stephen Hemminger
2023-08-15 1:38 ` [PATCH v1 2/7] tailq: skip init if already initialized okaya
2023-08-15 2:22 ` Stephen Hemminger
2023-08-15 1:38 ` [PATCH v1 3/7] eal_memzone: bail out on initialized okaya
2023-08-15 2:22 ` Stephen Hemminger
2023-08-15 1:38 ` [PATCH v1 4/7] memseg: init once okaya
2023-08-15 1:38 ` [PATCH v1 5/7] eal_memory: skip initialization okaya
2023-08-15 1:38 ` [PATCH v1 6/7] eal_interrupts: don't reinitialize threads okaya
2023-08-15 2:20 ` Stephen Hemminger
2023-08-15 1:38 ` [PATCH v1 7/7] eal: initialize worker threads once okaya
2023-08-15 2:24 ` Stephen Hemminger
2023-08-15 2:12 ` [PATCH v1 0/7] support reinit flow Stephen Hemminger
2023-08-15 3:12 ` Sinan Kaya
2023-08-15 21:49 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815013826.1288972-2-okaya@kernel.org \
--to=okaya@kernel.org \
--cc=dev@dpdk.org \
--cc=grwhyte@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).