From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: echaudro@redhat.com, mkp@redhat.com, stable@dpdk.org,
Jingjing Wu <jingjing.wu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Declan Doherty <declan.doherty@intel.com>,
Abhijit Sinha <abhijit.sinha@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>
Subject: [PATCH] net/iavf: fix checksum offloading
Date: Fri, 18 Aug 2023 11:03:51 +0200 [thread overview]
Message-ID: <20230818090351.2402519-1-david.marchand@redhat.com> (raw)
The only presence of RTE_MBUF_F_TX_IPV4 can't be used as an indicator
that a checksum offload has been requested by an application.
Check that RTE_MBUF_F_TX_IP_CKSUM or others flags have been set.
Fixes: 1e728b01120c ("net/iavf: rework Tx path")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/iavf/iavf_rxtx.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index f7df4665d1..b9e2879764 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -2652,6 +2652,9 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1,
offset |= (m->l2_len >> 1)
<< IAVF_TX_DESC_LENGTH_MACLEN_SHIFT;
+ if ((m->ol_flags & IAVF_TX_CKSUM_OFFLOAD_MASK) == 0)
+ goto skip_cksum;
+
/* Enable L3 checksum offloading inner */
if (m->ol_flags & RTE_MBUF_F_TX_IP_CKSUM) {
if (m->ol_flags & RTE_MBUF_F_TX_IPV4) {
@@ -2702,6 +2705,7 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1,
break;
}
+skip_cksum:
*qw1 = rte_cpu_to_le_64((((uint64_t)command <<
IAVF_TXD_DATA_QW1_CMD_SHIFT) & IAVF_TXD_DATA_QW1_CMD_MASK) |
(((uint64_t)offset << IAVF_TXD_DATA_QW1_OFFSET_SHIFT) &
--
2.41.0
next reply other threads:[~2023-08-18 9:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 9:03 David Marchand [this message]
2023-08-21 8:03 ` Eelco Chaudron
2023-08-21 8:22 ` David Marchand
2023-08-21 11:54 ` Zhang, Qi Z
2023-08-21 17:29 ` David Marchand
2023-08-22 1:52 ` Zhang, Qi Z
2023-08-22 6:11 ` David Marchand
2023-08-22 7:33 ` Zhang, Qi Z
2023-08-22 7:39 ` David Marchand
2023-08-22 7:59 ` Zhang, Qi Z
2023-08-22 10:10 ` Zhang, Qi Z
2023-08-23 6:29 ` [PATCH v2] " David Marchand
2023-08-23 8:33 ` Zhang, Qi Z
2023-08-24 15:24 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818090351.2402519-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=abhijit.sinha@intel.com \
--cc=beilei.xing@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=echaudro@redhat.com \
--cc=jingjing.wu@intel.com \
--cc=mkp@redhat.com \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).