From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, "Reshma Pattan" <reshma.pattan@intel.com>,
"Vladimir Medvedkin" <vladimir.medvedkin@intel.com>,
"Cristian Dumitrescu" <cristian.dumitrescu@intel.com>,
"Aman Singh" <aman.deep.singh@intel.com>,
"Yuying Zhang" <yuying.zhang@intel.com>,
"Nithin Dabilpuram" <ndabilpuram@marvell.com>,
"Kiran Kumar K" <kirankumark@marvell.com>,
"Sunil Kumar Kori" <skori@marvell.com>,
"Satha Rao" <skoteshwar@marvell.com>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
"Jingjing Wu" <jingjing.wu@intel.com>,
"Beilei Xing" <beilei.xing@intel.com>,
"Kai Ji" <kai.ji@intel.com>,
"Ajit Khaparde" <ajit.khaparde@broadcom.com>,
"Raveendra Padasalagi" <raveendra.padasalagi@broadcom.com>,
"Vikas Gupta" <vikas.gupta@broadcom.com>,
"Timothy McDaniel" <timothy.mcdaniel@intel.com>,
"Harry van Haaren" <harry.van.haaren@intel.com>,
"Srikanth Yalavarthi" <syalavarthi@marvell.com>,
"Somnath Kotur" <somnath.kotur@broadcom.com>,
"Rahul Lakkireddy" <rahul.lakkireddy@chelsio.com>,
"Qi Zhang" <qi.z.zhang@intel.com>,
"Xiao Wang" <xiao.w.wang@intel.com>,
"Dongdong Liu" <liudongdong3@huawei.com>,
"Yisen Zhuang" <yisen.zhuang@huawei.com>,
"David Christensen" <drc@linux.vnet.ibm.com>,
"Qiming Yang" <qiming.yang@intel.com>,
"Ruifeng Wang" <ruifeng.wang@arm.com>,
"Wenjun Wu" <wenjun1.wu@intel.com>,
"Matan Azrad" <matan@nvidia.com>,
"Viacheslav Ovsiienko" <viacheslavo@nvidia.com>,
"Ori Kam" <orika@nvidia.com>,
"Suanming Mou" <suanmingm@nvidia.com>,
"Liron Himi" <lironh@marvell.com>,
"Long Li" <longli@microsoft.com>,
"Maxime Coquelin" <maxime.coquelin@redhat.com>,
"Chenbo Xia" <chenbo.xia@intel.com>,
"Nicolas Chautru" <nicolas.chautru@intel.com>,
"Brian Dooley" <brian.dooley@intel.com>,
"Gowrishankar Muthukrishnan" <gmuthukrishn@marvell.com>,
"Chengwen Feng" <fengchengwen@huawei.com>,
"Kevin Laatz" <kevin.laatz@intel.com>,
"Anatoly Burakov" <anatoly.burakov@intel.com>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
"Thomas Monjalon" <thomas@monjalon.net>,
"Ferruh Yigit" <ferruh.yigit@amd.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Yipeng Wang" <yipeng1.wang@intel.com>,
"Sameh Gobriel" <sameh.gobriel@intel.com>
Subject: Re: [PATCH 1/2] use abstracted bit count functions
Date: Fri, 25 Aug 2023 09:35:35 -0700 [thread overview]
Message-ID: <20230825163535.GC18422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20230825101812.2396339-1-david.marchand@redhat.com>
On Fri, Aug 25, 2023 at 12:18:10PM +0200, David Marchand wrote:
> Now that DPDK provides such bit count functions, make use of them.
>
> This patch was prepared with a "brutal" commandline:
>
> $ old=__builtin_clzll; new=rte_clz64;
> git grep -lw $old :^lib/eal/include/rte_bitops.h |
> xargs sed -i -e "s#\<$old\>#$new#g"
> $ old=__builtin_clz; new=rte_clz32;
> git grep -lw $old :^lib/eal/include/rte_bitops.h |
> xargs sed -i -e "s#\<$old\>#$new#g"
>
> $ old=__builtin_ctzll; new=rte_ctz64;
> git grep -lw $old :^lib/eal/include/rte_bitops.h |
> xargs sed -i -e "s#\<$old\>#$new#g"
> $ old=__builtin_ctz; new=rte_ctz32;
> git grep -lw $old :^lib/eal/include/rte_bitops.h |
> xargs sed -i -e "s#\<$old\>#$new#g"
>
> $ old=__builtin_popcountll; new=rte_popcount64;
> git grep -lw $old :^lib/eal/include/rte_bitops.h |
> xargs sed -i -e "s#\<$old\>#$new#g"
> $ old=__builtin_popcount; new=rte_popcount32;
> git grep -lw $old :^lib/eal/include/rte_bitops.h |
> xargs sed -i -e "s#\<$old\>#$new#g"
>
> Then inclusion of rte_bitops.h was added were necessary.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
These kinds of patches always make me dizzy, I did a pass I cannot see
any replacement problems so lgtm.
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
next prev parent reply other threads:[~2023-08-25 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 10:18 David Marchand
2023-08-25 10:18 ` [PATCH 2/2] devtools: forbid use of builtin helpers for bit count David Marchand
2023-08-25 16:35 ` Tyler Retzlaff
2023-08-25 16:35 ` Tyler Retzlaff [this message]
2023-08-26 0:06 ` [PATCH 1/2] use abstracted bit count functions Long Li
2023-09-05 15:33 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825163535.GC18422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=ajit.khaparde@broadcom.com \
--cc=aman.deep.singh@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=brian.dooley@intel.com \
--cc=bruce.richardson@intel.com \
--cc=chenbo.xia@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=gmuthukrishn@marvell.com \
--cc=harry.van.haaren@intel.com \
--cc=jingjing.wu@intel.com \
--cc=kai.ji@intel.com \
--cc=kevin.laatz@intel.com \
--cc=kirankumark@marvell.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=lironh@marvell.com \
--cc=liudongdong3@huawei.com \
--cc=longli@microsoft.com \
--cc=matan@nvidia.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=maxime.coquelin@redhat.com \
--cc=ndabilpuram@marvell.com \
--cc=nicolas.chautru@intel.com \
--cc=orika@nvidia.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=raveendra.padasalagi@broadcom.com \
--cc=reshma.pattan@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=sameh.gobriel@intel.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=suanmingm@nvidia.com \
--cc=syalavarthi@marvell.com \
--cc=thomas@monjalon.net \
--cc=timothy.mcdaniel@intel.com \
--cc=viacheslavo@nvidia.com \
--cc=vikas.gupta@broadcom.com \
--cc=vladimir.medvedkin@intel.com \
--cc=wenjun1.wu@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=yipeng1.wang@intel.com \
--cc=yisen.zhuang@huawei.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).