From: Stephen Hemminger <stephen@networkplumber.org>
To: Min Zhou <zhoumin@loongson.cn>
Cc: yipeng1.wang@intel.com, sameh.gobriel@intel.com,
bruce.richardson@intel.com, vladimir.medvedkin@intel.com,
pablo.de.lara.guarch@intel.com, dev@dpdk.org
Subject: Re: [PATCH 1/1] test/hash: fix error log output
Date: Wed, 13 Sep 2023 00:30:57 -0700 [thread overview]
Message-ID: <20230913003057.5f22f687@fedora> (raw)
In-Reply-To: <20230912115239.861800-1-zhoumin@loongson.cn>
On Tue, 12 Sep 2023 19:52:39 +0800
Min Zhou <zhoumin@loongson.cn> wrote:
> diff --git a/app/test/test_hash_readwrite.c
> b/app/test/test_hash_readwrite.c index 74ca13912f..4997a01249 100644
> --- a/app/test/test_hash_readwrite.c
> +++ b/app/test/test_hash_readwrite.c
> @@ -162,7 +162,7 @@ init_params(int use_ext, int use_htm, int rw_lf,
> int use_jhash)
> handle = rte_hash_create(&hash_params);
> if (handle == NULL) {
> - printf("hash creation failed");
> + printf("hash creation failed\n");
Errors should be writen to stderr, not stdout?
It looks like the hash test doesn't do that anywhere though.
next prev parent reply other threads:[~2023-09-13 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 11:52 Min Zhou
2023-09-13 7:30 ` Stephen Hemminger [this message]
2023-09-13 9:23 ` zhoumin
2023-11-23 0:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913003057.5f22f687@fedora \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
--cc=zhoumin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).