DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: <wanry@3snic.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>
Subject: Re: [PATCH v5 00/32] Introduce sssnic PMD for 3SNIC's 9x0 serials Ethernet adapters
Date: Mon, 18 Sep 2023 20:23:47 -0700	[thread overview]
Message-ID: <20230918202347.0f2ed15f@hermes.local> (raw)
In-Reply-To: <20230904045658.238185-1-wanry@3snic.com>

On Mon, 4 Sep 2023 12:56:26 +0800
<wanry@3snic.com> wrote:

> From: Renyong Wan <wanry@3snic.com>
> 
> The sssnic PMD (**librte_pmd_sssnic**) provides poll mode driver support
> for 3SNIC 9x0 serials family of Ethernet adapters.
> 
> Supported NICs are:
> 
> - 3S910 Dual Port SFP28 10/25GbE Ethernet adapter
> - 3S920 Quad Port SFP28 10/25GbE Ethernet adapter
> - 3S920 Quad Port QSFP28 100GbE Ethernet adapter
> 
> Features of sssnic PMD are:
> 
> - Link status
> - Link status event
> - Queue start/stop
> - Rx interrupt
> - Scattered Rx
> - TSO
> - LRO
> - Promiscuous mode
> - Allmulticast mode
> - Unicast MAC filter
> - Multicast MAC filte
> - RSS hash
> - RSS key update
> - RSS reta update
> - Inner RSS
> - VLAN filter
> - VLAN offload
> - L3 checksum offload
> - L4 checksum offload
> - Inner L3 checksum
> - Inner L4 checksum
> - Basic stats
> - Extended stats
> - Stats per queue
> - Flow control
> - FW version
> - Generic flow API
> 
> ---
> v2:
> * Fixed 'Title underline too short' in doc/guides/nics/sssnic.rst.
> * Removed error.h from including files.
> * Fixed variable 'cmd_len' is uninitialized when used.
> * Fixed 'EINVAL' undeclared.
> * Fixed wrong format of printing uint64_t.
> * Fixed 'mask->hdr.src_addr' will always evaluate to 'true'.
> 
> v3:
> * Fixed dereferencing type-punned pointer in base/sssnic_mbox.c.
> 
> v4:
> * Fixed dereferencing type-punned pointer in base/sssnic_eventq.c.
> * Fixed coding style issue of COMPLEX_MACRO.
> * Fixed coding style issue of REPEATED_WORD.
> 
> v5:
> * Fixed rebase mistake.
> * Fixed incorrect path in MAINTAINERS file.
> ---
> 
> Renyong Wan (32):
>   net/sssnic: add build and doc infrastructure
>   net/sssnic: add log type and log macros
>   net/sssnic: support probe and remove
>   net/sssnic: initialize hardware base
>   net/sssnic: add event queue
>   net/sssnic/base: add message definition and utility
>   net/sssnic/base: add mailbox support
>   net/sssnic/base: add work queue
>   net/sssnic/base: add control queue
>   net/sssnic: add dev configure and infos get
>   net/sssnic: add dev MAC ops
>   net/sssnic: support dev link status
>   net/sssnic: support link status event
>   net/sssnic: support Rx queue setup and release
>   net/sssnic: support Tx queue setup and release
>   net/sssnic: support Rx queue start and stop
>   net/sssnic: support Tx queue start and stop
>   net/sssnic: add Rx interrupt support
>   net/sssnic: support dev start and stop
>   net/sssnic: support dev close and reset
>   net/sssnic: add allmulticast and promiscuous ops
>   net/sssnic: add basic and extended stats ops
>   net/sssnic: support Rx packet burst
>   net/sssnic: support Tx packet burst
>   net/sssnic: add RSS support
>   net/sssnic: support dev MTU set
>   net/sssnic: support dev queue info get
>   net/sssnic: support dev firmware version get
>   net/sssnic: add dev flow control ops
>   net/sssnic: support VLAN offload and filter
>   net/sssnic: add generic flow ops
>   net/sssnic: add VF dev support
> 
>  .mailmap                                   |    2 +
>  MAINTAINERS                                |    7 +
>  doc/guides/nics/features/sssnic.ini        |   47 +
>  doc/guides/nics/index.rst                  |    1 +
>  doc/guides/nics/sssnic.rst                 |   73 +
>  drivers/net/meson.build                    |    1 +
>  drivers/net/sssnic/base/meson.build        |   20 +
>  drivers/net/sssnic/base/sssnic_api.c       | 1943 ++++++++++++++++++++
>  drivers/net/sssnic/base/sssnic_api.h       |  498 +++++
>  drivers/net/sssnic/base/sssnic_cmd.h       |  514 ++++++
>  drivers/net/sssnic/base/sssnic_ctrlq.c     |  521 ++++++
>  drivers/net/sssnic/base/sssnic_ctrlq.h     |   58 +
>  drivers/net/sssnic/base/sssnic_eventq.c    |  461 +++++
>  drivers/net/sssnic/base/sssnic_eventq.h    |   84 +
>  drivers/net/sssnic/base/sssnic_exception.c |  116 ++
>  drivers/net/sssnic/base/sssnic_exception.h |   10 +
>  drivers/net/sssnic/base/sssnic_hw.c        |  486 +++++
>  drivers/net/sssnic/base/sssnic_hw.h        |  117 ++
>  drivers/net/sssnic/base/sssnic_mbox.c      |  615 +++++++
>  drivers/net/sssnic/base/sssnic_mbox.h      |   45 +
>  drivers/net/sssnic/base/sssnic_misc.h      |   52 +
>  drivers/net/sssnic/base/sssnic_msg.c       |  254 +++
>  drivers/net/sssnic/base/sssnic_msg.h       |  166 ++
>  drivers/net/sssnic/base/sssnic_reg.h       |  267 +++
>  drivers/net/sssnic/base/sssnic_workq.c     |  141 ++
>  drivers/net/sssnic/base/sssnic_workq.h     |  108 ++
>  drivers/net/sssnic/meson.build             |   28 +
>  drivers/net/sssnic/sssnic_ethdev.c         | 1139 ++++++++++++
>  drivers/net/sssnic/sssnic_ethdev.h         |  102 +
>  drivers/net/sssnic/sssnic_ethdev_fdir.c    | 1017 ++++++++++
>  drivers/net/sssnic/sssnic_ethdev_fdir.h    |  332 ++++
>  drivers/net/sssnic/sssnic_ethdev_flow.c    |  981 ++++++++++
>  drivers/net/sssnic/sssnic_ethdev_flow.h    |   11 +
>  drivers/net/sssnic/sssnic_ethdev_link.c    |  209 +++
>  drivers/net/sssnic/sssnic_ethdev_link.h    |   14 +
>  drivers/net/sssnic/sssnic_ethdev_rss.c     |  377 ++++
>  drivers/net/sssnic/sssnic_ethdev_rss.h     |   20 +
>  drivers/net/sssnic/sssnic_ethdev_rx.c      | 1396 ++++++++++++++
>  drivers/net/sssnic/sssnic_ethdev_rx.h      |   50 +
>  drivers/net/sssnic/sssnic_ethdev_stats.c   |  414 +++++
>  drivers/net/sssnic/sssnic_ethdev_stats.h   |   18 +
>  drivers/net/sssnic/sssnic_ethdev_tx.c      | 1123 +++++++++++
>  drivers/net/sssnic/sssnic_ethdev_tx.h      |   45 +
>  drivers/net/sssnic/sssnic_log.h            |   51 +
>  44 files changed, 13934 insertions(+)
>  create mode 100644 doc/guides/nics/features/sssnic.ini
>  create mode 100644 doc/guides/nics/sssnic.rst
>  create mode 100644 drivers/net/sssnic/base/meson.build
>  create mode 100644 drivers/net/sssnic/base/sssnic_api.c
>  create mode 100644 drivers/net/sssnic/base/sssnic_api.h
>  create mode 100644 drivers/net/sssnic/base/sssnic_cmd.h
>  create mode 100644 drivers/net/sssnic/base/sssnic_ctrlq.c
>  create mode 100644 drivers/net/sssnic/base/sssnic_ctrlq.h
>  create mode 100644 drivers/net/sssnic/base/sssnic_eventq.c
>  create mode 100644 drivers/net/sssnic/base/sssnic_eventq.h
>  create mode 100644 drivers/net/sssnic/base/sssnic_exception.c
>  create mode 100644 drivers/net/sssnic/base/sssnic_exception.h
>  create mode 100644 drivers/net/sssnic/base/sssnic_hw.c
>  create mode 100644 drivers/net/sssnic/base/sssnic_hw.h
>  create mode 100644 drivers/net/sssnic/base/sssnic_mbox.c
>  create mode 100644 drivers/net/sssnic/base/sssnic_mbox.h
>  create mode 100644 drivers/net/sssnic/base/sssnic_misc.h
>  create mode 100644 drivers/net/sssnic/base/sssnic_msg.c
>  create mode 100644 drivers/net/sssnic/base/sssnic_msg.h
>  create mode 100644 drivers/net/sssnic/base/sssnic_reg.h
>  create mode 100644 drivers/net/sssnic/base/sssnic_workq.c
>  create mode 100644 drivers/net/sssnic/base/sssnic_workq.h
>  create mode 100644 drivers/net/sssnic/meson.build
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev.c
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev.h
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev_fdir.c
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev_fdir.h
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev_flow.c
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev_flow.h
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev_link.c
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev_link.h
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev_rss.c
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev_rss.h
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev_rx.c
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev_rx.h
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev_stats.c
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev_stats.h
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev_tx.c
>  create mode 100644 drivers/net/sssnic/sssnic_ethdev_tx.h
>  create mode 100644 drivers/net/sssnic/sssnic_log.h

Since secondary process is not supported...

static int
sssnic_ethdev_init(struct rte_eth_dev *ethdev)
{
	int ret;
	struct sssnic_hw *hw;
	struct sssnic_netdev *netdev;
	struct rte_pci_device *pci_dev;

	PMD_INIT_FUNC_TRACE();

	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
		return 0;

Should be something like:
	if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
		PMD_DRV_LOG(ERR, "Secondary process not supported");
		return -ENOTSUP;
	}

  parent reply	other threads:[~2023-09-19  3:23 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04  4:56 wanry
2023-09-04  4:56 ` [PATCH v5 01/32] net/sssnic: add build and doc infrastructure wanry
2023-09-26 13:06   ` Ferruh Yigit
2023-09-04  4:56 ` [PATCH v5 02/32] net/sssnic: add log type and log macros wanry
2023-09-04  4:56 ` [PATCH v5 03/32] net/sssnic: support probe and remove wanry
2023-09-18 16:08   ` Stephen Hemminger
2023-09-19  2:00     ` Renyong Wan
2023-09-04  4:56 ` [PATCH v5 04/32] net/sssnic: initialize hardware base wanry
2023-09-18  2:28   ` Stephen Hemminger
2023-09-18  4:47     ` Renyong Wan
2023-09-04  4:56 ` [PATCH v5 05/32] net/sssnic: add event queue wanry
2023-09-04  4:56 ` [PATCH v5 06/32] net/sssnic/base: add message definition and utility wanry
2023-09-18  2:31   ` Stephen Hemminger
2023-09-18  5:08     ` Renyong Wan
2023-09-04  4:56 ` [PATCH v5 07/32] net/sssnic/base: add mailbox support wanry
2023-09-18  2:32   ` Stephen Hemminger
2023-09-18  5:10     ` Renyong Wan
2023-09-26 13:13   ` Ferruh Yigit
2023-09-04  4:56 ` [PATCH v5 08/32] net/sssnic/base: add work queue wanry
2023-09-18  2:33   ` Stephen Hemminger
2023-09-18  5:11     ` Renyong Wan
2023-09-04  4:56 ` [PATCH v5 09/32] net/sssnic/base: add control queue wanry
2023-09-18  2:36   ` Stephen Hemminger
2023-09-18  5:22     ` Renyong Wan
2023-09-04  4:56 ` [PATCH v5 10/32] net/sssnic: add dev configure and infos get wanry
2023-09-04  4:56 ` [PATCH v5 11/32] net/sssnic: add dev MAC ops wanry
2023-09-26 13:07   ` Ferruh Yigit
2023-09-04  4:56 ` [PATCH v5 12/32] net/sssnic: support dev link status wanry
2023-09-04  4:56 ` [PATCH v5 13/32] net/sssnic: support link status event wanry
2023-09-26 13:08   ` Ferruh Yigit
2023-09-04  4:56 ` [PATCH v5 14/32] net/sssnic: support Rx queue setup and release wanry
2023-09-04  4:56 ` [PATCH v5 15/32] net/sssnic: support Tx " wanry
2023-09-04  4:56 ` [PATCH v5 16/32] net/sssnic: support Rx queue start and stop wanry
2023-09-04  4:56 ` [PATCH v5 17/32] net/sssnic: support Tx " wanry
2023-09-04  4:56 ` [PATCH v5 18/32] net/sssnic: add Rx interrupt support wanry
2023-09-04  4:56 ` [PATCH v5 19/32] net/sssnic: support dev start and stop wanry
2023-09-26 13:09   ` Ferruh Yigit
2023-09-04  4:56 ` [PATCH v5 20/32] net/sssnic: support dev close and reset wanry
2023-09-26 13:09   ` Ferruh Yigit
2023-09-04  4:56 ` [PATCH v5 21/32] net/sssnic: add allmulticast and promiscuous ops wanry
2023-09-04  4:56 ` [PATCH v5 22/32] net/sssnic: add basic and extended stats ops wanry
2023-09-04  4:56 ` [PATCH v5 23/32] net/sssnic: support Rx packet burst wanry
2023-09-04  4:56 ` [PATCH v5 24/32] net/sssnic: support Tx " wanry
2023-09-26 13:10   ` Ferruh Yigit
2023-09-04  4:56 ` [PATCH v5 25/32] net/sssnic: add RSS support wanry
2023-09-04  4:56 ` [PATCH v5 26/32] net/sssnic: support dev MTU set wanry
2023-09-04  4:56 ` [PATCH v5 27/32] net/sssnic: support dev queue info get wanry
2023-09-04  4:56 ` [PATCH v5 28/32] net/sssnic: support dev firmware version get wanry
2023-09-04  4:56 ` [PATCH v5 29/32] net/sssnic: add dev flow control ops wanry
2023-09-26 13:12   ` Ferruh Yigit
2023-09-04  4:56 ` [PATCH v5 30/32] net/sssnic: support VLAN offload and filter wanry
2023-09-04  4:56 ` [PATCH v5 31/32] net/sssnic: add generic flow ops wanry
2023-09-04  4:56 ` [PATCH v5 32/32] net/sssnic: add VF dev support wanry
2023-09-26 13:11   ` Ferruh Yigit
2023-09-18  2:37 ` [PATCH v5 00/32] Introduce sssnic PMD for 3SNIC's 9x0 serials Ethernet adapters Stephen Hemminger
2023-09-18  3:23   ` Renyong Wan
2023-09-19  3:19 ` Stephen Hemminger
2023-09-19  5:18   ` Renyong Wan
2023-09-19  3:21 ` Stephen Hemminger
2023-09-19  5:18   ` Renyong Wan
2023-09-19  3:23 ` Stephen Hemminger [this message]
2023-09-19  5:19   ` Renyong Wan
2023-09-19 15:24 ` Stephen Hemminger
2023-09-26 13:13 ` Ferruh Yigit
2024-03-29 11:32   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230918202347.0f2ed15f@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=wanry@3snic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).