From: Stephen Hemminger <stephen@networkplumber.org>
To: Tomasz Duszynski <tduszynski@marvell.com>
Cc: <dev@dpdk.org>, Jakub Palider <jpalider@marvell.com>,
Anatoly Burakov <anatoly.burakov@intel.com>, <jerinj@marvell.com>,
<thomas@monjalon.net>
Subject: Re: [PATCH 1/2] raw/cnxk_gpio: support multi-process mode
Date: Tue, 3 Oct 2023 15:28:42 -0700 [thread overview]
Message-ID: <20231003152842.11b3ed7f@hermes.local> (raw)
In-Reply-To: <20231003204603.3377509-1-tduszynski@marvell.com>
On Tue, 3 Oct 2023 22:46:02 +0200
Tomasz Duszynski <tduszynski@marvell.com> wrote:
> +
> +struct cnxk_gpio_params {
> + char allowlist[CNXK_GPIO_BUFSZ];
> + int num;
> +};
Should be using unsigned for number of params since can't be negative.
You could also use a flex array to avoid any buf size issues.
next prev parent reply other threads:[~2023-10-03 22:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 20:46 Tomasz Duszynski
2023-10-03 20:46 ` [PATCH 2/2] raw/cnxk_gpio: add bunch of newlines Tomasz Duszynski
2023-10-03 22:26 ` Stephen Hemminger
2023-10-04 20:42 ` [EXT] " Tomasz Duszynski
2023-10-05 2:54 ` Stephen Hemminger
2023-10-05 7:36 ` Tomasz Duszynski
2023-10-03 22:28 ` Stephen Hemminger [this message]
2023-10-04 20:35 ` [EXT] Re: [PATCH 1/2] raw/cnxk_gpio: support multi-process mode Tomasz Duszynski
2023-10-05 21:09 ` [PATCH v2 " Tomasz Duszynski
2023-10-05 21:10 ` [PATCH v2 2/2] raw/cnxk_gpio: add bunch of newlines Tomasz Duszynski
2023-10-16 10:04 ` [PATCH v3 1/2] raw/cnxk_gpio: support multi-process mode Tomasz Duszynski
2023-10-16 10:04 ` [PATCH v3 2/2] raw/cnxk_gpio: add bunch of newlines Tomasz Duszynski
2023-10-18 6:51 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003152842.11b3ed7f@hermes.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jpalider@marvell.com \
--cc=tduszynski@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).