From: Stephen Hemminger <stephen@networkplumber.org>
To: "Mattias Rönnblom" <hofors@lysator.liu.se>
Cc: "David Marchand" <david.marchand@redhat.com>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
dev@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH] random: clarify PRNG MT safety guarantees
Date: Fri, 6 Oct 2023 08:58:24 -0700 [thread overview]
Message-ID: <20231006085824.002a5c4b@hermes.local> (raw)
In-Reply-To: <23c66954-b560-4cf0-bc50-bab4248b2f8b@lysator.liu.se>
On Fri, 6 Oct 2023 14:18:25 +0200
Mattias Rönnblom <hofors@lysator.liu.se> wrote:
> On 2023-10-06 11:13, David Marchand wrote:
> > On Wed, Oct 4, 2023 at 1:00 PM Mattias Rönnblom
> > <mattias.ronnblom@ericsson.com> wrote:
> >>
> >> Clarify MT safety guarantees for unregistered non-EAL threads calling
> >> PRNG functions in rte_random.h.
> >>
> >> Clarify that rte_srand() is not MT safe in regards to calls to
> >> rte_rand_max() and rte_drand().
> >>
> >> Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
> >> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> >
> > Should it be backported along 3a4e21301c7a ("random: initialize state
> > for unregistered non-EAL threads") ?
> >
> >
>
> I don't think that's worth the trouble, but if someone has a different
> opinion, I also don't mind if it is.
Agree. The initialization patch should be backported, but not this one.
prev parent reply other threads:[~2023-10-06 15:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 10:54 Mattias Rönnblom
2023-10-04 12:05 ` Morten Brørup
2023-10-10 9:40 ` David Marchand
2023-10-06 9:13 ` David Marchand
2023-10-06 12:18 ` Mattias Rönnblom
2023-10-06 15:58 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006085824.002a5c4b@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hofors@lysator.liu.se \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).