From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>,
tomaszx.kulasek@intel.com, stable@dpdk.org,
Chaoyong He <chaoyong.he@corigine.com>,
Peng Zhang <peng.zhang@corigine.com>
Subject: [PATCH 1/3] app/test: fix control flow issue
Date: Tue, 10 Oct 2023 14:23:02 +0800 [thread overview]
Message-ID: <20231010062304.205933-2-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20231010062304.205933-1-chaoyong.he@corigine.com>
From: Long Wu <long.wu@corigine.com>
CI found that execution cannot reach the expression "-1"
inside this statement.
Coverity issue: 403097
Fixes: 5e41ab250dfa ("app/test: unit tests for bonding mode 4")
Cc: tomaszx.kulasek@intel.com
Cc: stable@dpdk.org
Signed-off-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
app/test/test_link_bonding_mode4.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c
index 645fc1e0d4..ff13dbed93 100644
--- a/app/test/test_link_bonding_mode4.c
+++ b/app/test/test_link_bonding_mode4.c
@@ -641,8 +641,7 @@ bond_handshake(void)
/* If response didn't send - report failure */
TEST_ASSERT_EQUAL(all_members_done, 1, "Bond handshake failed\n");
- /* If flags doesn't match - report failure */
- return all_members_done == 1 ? TEST_SUCCESS : TEST_FAILED;
+ return TEST_SUCCESS;
}
#define TEST_LACP_MEMBER_COUT RTE_DIM(test_params.member_ports)
--
2.39.1
next parent reply other threads:[~2023-10-10 6:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231010062304.205933-1-chaoyong.he@corigine.com>
2023-10-10 6:23 ` Chaoyong He [this message]
2023-10-31 14:51 ` Ferruh Yigit
2023-10-10 6:23 ` [PATCH 2/3] net/bonding: fix illegal memory accesses Chaoyong He
2023-10-31 14:51 ` Ferruh Yigit
2023-11-01 2:19 ` [PATCH v2] " Chaoyong He
2023-11-01 15:38 ` Ferruh Yigit
2023-10-10 6:23 ` [PATCH 3/3] app/test: fix checking return value Chaoyong He
2023-10-31 14:52 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010062304.205933-2-chaoyong.he@corigine.com \
--to=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stable@dpdk.org \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).