From: Huisong Li <lihuisong@huawei.com>
To: <dev@dpdk.org>, Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Shahaf Shuler <shahafs@nvidia.com>
Cc: <thomas@monjalon.net>, <ferruh.yigit@amd.com>,
<zhichaox.zeng@intel.com>, <lihuisong@huawei.com>
Subject: [PATCH v3 1/2] app/testpmd: remove useless code for TSO setting command
Date: Tue, 7 Nov 2023 12:11:16 +0800 [thread overview]
Message-ID: <20231107041117.23285-2-lihuisong@huawei.com> (raw)
In-Reply-To: <20231107041117.23285-1-lihuisong@huawei.com>
Testpmd has added the check of TSO offload capability of port, please see
the commit 3926dd2b6668 ("app/testpmd: enforce offload capabilities check")
So the code following the check code memtioned above to display warning
when port doesn't support TSO offload doesn't access to forever.
Fixes: 3926dd2b6668 ("app/testpmd: enforce offload capabilities check")
Cc: stable@dpdk.org
Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
app/test-pmd/cmdline.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 912bf3355c..1c57e07d41 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -4967,19 +4967,6 @@ cmd_tso_set_parsed(void *parsed_result,
ports[res->port_id].tso_segsz);
}
cmd_config_queue_tx_offloads(&ports[res->port_id]);
-
- /* display warnings if configuration is not supported by the NIC */
- ret = eth_dev_info_get_print_err(res->port_id, &dev_info);
- if (ret != 0)
- return;
-
- if ((ports[res->port_id].tso_segsz != 0) &&
- (dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_TCP_TSO) == 0) {
- fprintf(stderr,
- "Warning: TSO enabled but not supported by port %d\n",
- res->port_id);
- }
-
cmd_reconfig_device_queue(res->port_id, 1, 1);
}
--
2.33.0
next prev parent reply other threads:[~2023-11-07 4:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 2:13 [PATCH] app/testpmd: fix UDP cksum error for UFO enable Huisong Li
2023-08-02 2:55 ` [PATCH v2] " Huisong Li
2023-10-20 3:38 ` lihuisong (C)
2023-10-27 6:15 ` fengchengwen
2023-11-03 1:31 ` Ferruh Yigit
2023-11-03 9:09 ` lihuisong (C)
2023-11-03 10:42 ` Ferruh Yigit
2023-11-06 4:13 ` lihuisong (C)
2023-11-06 10:09 ` Ferruh Yigit
2023-11-06 12:29 ` lihuisong (C)
2023-11-07 4:11 ` [PATCH v3 0/2] " Huisong Li
2023-11-07 4:11 ` Huisong Li [this message]
2023-11-07 4:11 ` [PATCH v3 2/2] " Huisong Li
2023-11-07 9:54 ` [PATCH v3 0/2] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231107041117.23285-2-lihuisong@huawei.com \
--to=lihuisong@huawei.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=shahafs@nvidia.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
--cc=yuying.zhang@intel.com \
--cc=zhichaox.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).