DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: "David Marchand" <david.marchand@redhat.com>, <dev@dpdk.org>,
	<konstantin.v.ananyev@yandex.ru>
Subject: Re: [PATCH] dumpcap: fix mbuf pool ring type
Date: Tue, 7 Nov 2023 09:00:18 -0800	[thread overview]
Message-ID: <20231107090018.3687b2a8@hermes.local> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9EFE8@smartserver.smartshare.dk>

On Tue, 7 Nov 2023 08:22:37 +0100
Morten Brørup <mb@smartsharesystems.com> wrote:

> > > Or are you saying that if they want to use dumpcap, they must choose  
> > a thread safe pool type for their application (regardless if the
> > application is single-threaded or not)?
> > 
> > There is no command line of EAL nature in dumpcap.
> > This is intentional.
> > QED: overriding default pool type is not going to be a possible  
> 
> The preferred mbuf pool type can configured in the primary process by EAL params. If so configured, it is stored in a memzone named "mbuf_user_pool_ops".
> And if it is set there, the secondary process will also use it as its preferred mbuf pool type.

I notice that no other app or example is using the create_by_ops except pdump/pcapng/dumpcap.

~/DPDK/main/examples $ git grep rte_pktmbuf_pool_create_by_ops


~/DPDK/main/app $ git grep rte_pktmbuf_pool_create_by_ops
dumpcap/main.c: mp = rte_pktmbuf_pool_create_by_ops(pool_name, num_mbufs,
pdump/main.c:                   mbuf_pool = rte_pktmbuf_pool_create_by_ops(mempool_name,
test/test_pcapng.c:     mp = rte_pktmbuf_pool_create_by_ops("pcapng_test_pool", IOV_MAX + NUM_PACKETS,

  parent reply	other threads:[~2023-11-07 17:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04 16:16 Stephen Hemminger
2023-08-05  9:05 ` Morten Brørup
2023-10-02  7:33 ` David Marchand
2023-10-02  8:42   ` Morten Brørup
2023-11-06 19:23     ` Stephen Hemminger
2023-11-06 21:50       ` Morten Brørup
2023-11-07  2:36         ` Stephen Hemminger
2023-11-07  7:22           ` Morten Brørup
2023-11-07 16:41             ` Stephen Hemminger
2023-11-07 17:38               ` Morten Brørup
2023-11-08 16:50                 ` Stephen Hemminger
2023-11-08 17:43                   ` Morten Brørup
2023-11-07 17:00             ` Stephen Hemminger [this message]
2023-11-06 19:24   ` Stephen Hemminger
2023-11-06 19:34 ` [PATCH v2] " Stephen Hemminger
2023-11-08 17:47 ` [PATCH v3 ] " Stephen Hemminger
2023-11-09  7:21   ` Morten Brørup
2023-11-12 14:05     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231107090018.3687b2a8@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=mb@smartsharesystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).