From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Subject: Re: [PATCH] mbuf: remove use of now unnecessary extension keyword
Date: Tue, 7 Nov 2023 15:07:33 -0800 [thread overview]
Message-ID: <20231107230733.GA15565@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <1699395284-8751-1-git-send-email-roretzla@linux.microsoft.com>
this series will be withdrawn since the keyword was also applied to the
bitfields.
sorry for the noise
On Tue, Nov 07, 2023 at 02:14:44PM -0800, Tyler Retzlaff wrote:
> Remove the use of __extension__ on nameless struct and union members
> they are no longer necessary as they are standard in C11
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
> lib/mbuf/rte_mbuf_core.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
> index 5688683..d335ed8 100644
> --- a/lib/mbuf/rte_mbuf_core.h
> +++ b/lib/mbuf/rte_mbuf_core.h
> @@ -525,7 +525,6 @@ struct rte_mbuf {
> */
> union {
> uint32_t packet_type; /**< L2/L3/L4 and tunnel information. */
> - __extension__
> struct {
> uint8_t l2_type:4; /**< (Outer) L2 type. */
> uint8_t l3_type:4; /**< (Outer) L3 type. */
> @@ -537,7 +536,6 @@ struct rte_mbuf {
> * RTE_PTYPE_TUNNEL_ESP tunnel type is set
> * on both Tx and Rx.
> */
> - __extension__
> struct {
> uint8_t inner_l2_type:4;
> /**< Inner L2 type. */
> @@ -614,7 +612,6 @@ struct rte_mbuf {
> /* fields to support TX offloads */
> union {
> uint64_t tx_offload; /**< combined for easy fetch */
> - __extension__
> struct {
> uint64_t l2_len:RTE_MBUF_L2_LEN_BITS;
> /**< L2 (MAC) Header Length for non-tunneling pkt.
> --
> 1.8.3.1
prev parent reply other threads:[~2023-11-07 23:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 22:14 Tyler Retzlaff
2023-11-07 23:07 ` Tyler Retzlaff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231107230733.GA15565@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).