DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Trevor Tao <taozj888@163.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 1/2] examples/l3fwd: relax RSS requirement with option
Date: Sun, 12 Nov 2023 15:33:49 -0800	[thread overview]
Message-ID: <20231112153349.202150ff@hermes.local> (raw)
In-Reply-To: <20231112071611.101503-2-taozj888@163.com>

On Sun, 12 Nov 2023 07:16:10 +0000
Trevor Tao <taozj888@163.com> wrote:

> Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS
> by default, but some hw and/or virtual interface does not
> support the RSS and offload mode presupposed, e.g., some
> virtio interfaces in the cloud don't support
> RSS and the error msg may like:
> 
> virtio_dev_configure(): RSS support requested but not supported by
> the device
> Port0 dev_configure = -95
> 
> So to enable the l3fwd running in that environment, the Rx mode requirement
> can be relaxed to reflect the hardware feature reality here, and the l3fwd
> can run smoothly then.
> 
> An option named "relax-rx-mode" is added to enable the relax action
> here, and it's disabled by default.
> 
> Signed-off-by: Trevor Tao <taozj888@163.com>

Doesn't need to be an option. The application can just look at the offload
flags and quickly determine that if multiple queues are being used than
RSS is required. If device doesn't support RSS, then fallback to single
queue with a warning.

  reply	other threads:[~2023-11-12 23:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-12  7:16 [PATCH v3 0/2] example/l3fwd: relax l3fwd rx RSS/Offload if needed Trevor Tao
2023-11-12  7:16 ` [PATCH v3 1/2] examples/l3fwd: relax RSS requirement with option Trevor Tao
2023-11-12 23:33   ` Stephen Hemminger [this message]
2023-11-13 11:47     ` taozj888
2023-11-13 12:40       ` Morten Brørup
2023-11-13 13:19         ` Konstantin Ananyev
2023-11-13 16:06           ` taozj888
2023-11-12  7:16 ` [PATCH v3 2/2] examples/l3fwd: relax the Offload requirement Trevor Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231112153349.202150ff@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=taozj888@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).