From: Stephen Hemminger <stephen@networkplumber.org>
To: Joyce Kong <joyce.kong@arm.com>
Cc: thomas@monjalon.net, ruifeng.wang@arm.com,
bruce.richardson@intel.com, dev@dpdk.org, nd@arm.com,
stable@dpdk.org
Subject: Re: [PATCH v4 1/2] config: correct cpu instruction set for cross build
Date: Thu, 7 Dec 2023 14:41:11 -0800 [thread overview]
Message-ID: <20231207144111.7b9405fd@hermes.local> (raw)
In-Reply-To: <20231205035259.3516625-2-joyce.kong@arm.com>
On Tue, 5 Dec 2023 03:52:58 +0000
Joyce Kong <joyce.kong@arm.com> wrote:
> The platform value would be 'native' only when not cross build.
> Move the operation about modifying cpu_instruction_set while
> platform equals 'native' to the not cross build branch.
>
> Fixes: bf66003b51ec ("build: use platform for generic and native builds")
> Cc: stable@dpdk.org
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Looks right, what is the impact on existing users doing current cross builds?
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2023-12-07 22:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230822074743.3243015-1-joyce.kong@arm.com>
[not found] ` <20231205035259.3516625-1-joyce.kong@arm.com>
2023-12-05 3:52 ` Joyce Kong
2023-12-07 22:41 ` Stephen Hemminger [this message]
2023-12-08 2:51 ` Joyce Kong
2024-01-19 19:39 ` Pavan Nikhilesh Bhagavatula
2024-03-06 14:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207144111.7b9405fd@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=joyce.kong@arm.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).