DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, Zerun Fu <zerun.fu@corigine.com>,
	Long Wu <long.wu@corigine.com>,
	Peng Zhang <peng.zhang@corigine.com>,
	Chaoyong He <chaoyong.he@corigine.com>
Subject: [PATCH 7/7] net/nfp: support setting FEC mode
Date: Mon, 11 Dec 2023 11:08:58 +0800	[thread overview]
Message-ID: <20231211030858.1693240-8-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20231211030858.1693240-1-chaoyong.he@corigine.com>

From: Zerun Fu <zerun.fu@corigine.com>

Add support for configuring FEC mode. This feature allows to set any
currently supported FEC mode.

Signed-off-by: Zerun Fu <zerun.fu@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
---
 drivers/net/nfp/nfp_ethdev.c      |  1 +
 drivers/net/nfp/nfp_net_common.c  | 54 +++++++++++++++++++++++++++++++
 drivers/net/nfp/nfp_net_common.h  |  2 ++
 drivers/net/nfp/nfpcore/nfp_nsp.h |  1 +
 4 files changed, 58 insertions(+)

diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index e3f5fe7917..185b570892 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -761,6 +761,7 @@ static const struct eth_dev_ops nfp_net_eth_dev_ops = {
 	.flow_ops_get           = nfp_net_flow_ops_get,
 	.fec_get_capability     = nfp_net_fec_get_capability,
 	.fec_get                = nfp_net_fec_get,
+	.fec_set                = nfp_net_fec_set,
 };
 
 static inline void
diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c
index 063c048675..eeb0aaae26 100644
--- a/drivers/net/nfp/nfp_net_common.c
+++ b/drivers/net/nfp/nfp_net_common.c
@@ -2386,3 +2386,57 @@ nfp_net_fec_get(struct rte_eth_dev *dev,
 
 	return 0;
 }
+
+static enum nfp_eth_fec
+nfp_net_fec_rte_to_nfp(uint32_t fec)
+{
+	switch (fec) {
+	case RTE_BIT32(RTE_ETH_FEC_AUTO):
+		return NFP_FEC_AUTO_BIT;
+	case RTE_BIT32(RTE_ETH_FEC_NOFEC):
+		return NFP_FEC_DISABLED_BIT;
+	case RTE_BIT32(RTE_ETH_FEC_RS):
+		return NFP_FEC_REED_SOLOMON_BIT;
+	case RTE_BIT32(RTE_ETH_FEC_BASER):
+		return NFP_FEC_BASER_BIT;
+	default:
+		return NFP_FEC_INVALID_BIT;
+	}
+}
+
+int
+nfp_net_fec_set(struct rte_eth_dev *dev,
+		uint32_t fec_capa)
+{
+	enum nfp_eth_fec fec;
+	struct nfp_net_hw *hw;
+	uint32_t supported_fec;
+	struct nfp_eth_table *nfp_eth_table;
+	struct nfp_eth_table_port *eth_port;
+
+	hw = nfp_net_get_hw(dev);
+	if (hw->pf_dev == NULL)
+		return -EINVAL;
+
+	nfp_eth_table = hw->pf_dev->nfp_eth_table;
+	eth_port = &nfp_eth_table->ports[hw->idx];
+
+	supported_fec = nfp_eth_supported_fec_modes(eth_port);
+	if (supported_fec == 0) {
+		PMD_DRV_LOG(ERR, "NFP can not support FEC.");
+		return -ENOTSUP;
+	}
+
+	fec = nfp_net_fec_rte_to_nfp(fec_capa);
+	if (fec == NFP_FEC_INVALID_BIT) {
+		PMD_DRV_LOG(ERR, "FEC modes is invalid.");
+		return -EINVAL;
+	}
+
+	if ((RTE_BIT32(fec) & supported_fec) == 0) {
+		PMD_DRV_LOG(ERR, "Unsupported FEC mode is set.");
+		return -EIO;
+	}
+
+	return nfp_eth_set_fec(hw->cpp, eth_port->index, fec);
+}
diff --git a/drivers/net/nfp/nfp_net_common.h b/drivers/net/nfp/nfp_net_common.h
index fa88323b7c..66c900e3b8 100644
--- a/drivers/net/nfp/nfp_net_common.h
+++ b/drivers/net/nfp/nfp_net_common.h
@@ -293,6 +293,8 @@ int nfp_net_fec_get_capability(struct rte_eth_dev *dev,
 		unsigned int num);
 int nfp_net_fec_get(struct rte_eth_dev *dev,
 		uint32_t *fec_capa);
+int nfp_net_fec_set(struct rte_eth_dev *dev,
+		uint32_t fec_capa);
 
 #define NFP_PRIV_TO_APP_FW_NIC(app_fw_priv)\
 	((struct nfp_app_fw_nic *)app_fw_priv)
diff --git a/drivers/net/nfp/nfpcore/nfp_nsp.h b/drivers/net/nfp/nfpcore/nfp_nsp.h
index 41e8402154..2ce05c2ec9 100644
--- a/drivers/net/nfp/nfpcore/nfp_nsp.h
+++ b/drivers/net/nfp/nfpcore/nfp_nsp.h
@@ -100,6 +100,7 @@ enum nfp_eth_fec {
 	NFP_FEC_BASER_BIT,
 	NFP_FEC_REED_SOLOMON_BIT,
 	NFP_FEC_DISABLED_BIT,
+	NFP_FEC_INVALID_BIT,
 };
 
 #define NFP_FEC_AUTO            RTE_BIT32(NFP_FEC_AUTO_BIT)
-- 
2.39.1


  parent reply	other threads:[~2023-12-11  3:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11  3:08 [PATCH 0/7] support link auto negotiation Chaoyong He
2023-12-11  3:08 ` [PATCH 1/7] net/nfp: set a new parameter to hwinfo Chaoyong He
2023-12-11  3:08 ` [PATCH 2/7] net/nfp: support getting speed capability Chaoyong He
2023-12-11  3:08 ` [PATCH 3/7] net/nfp: support setting port speed Chaoyong He
2023-12-11  3:08 ` [PATCH 4/7] net/nfp: modify the link update function Chaoyong He
2023-12-11  3:08 ` [PATCH 5/7] net/nfp: support getting FEC capability Chaoyong He
2023-12-11  3:08 ` [PATCH 6/7] net/nfp: support getting FEC mode Chaoyong He
2023-12-11  3:08 ` Chaoyong He [this message]
2023-12-12 15:28 ` [PATCH 0/7] support link auto negotiation Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231211030858.1693240-8-chaoyong.he@corigine.com \
    --to=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=long.wu@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=peng.zhang@corigine.com \
    --cc=zerun.fu@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).