From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>, marcinx.kerlin@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] cmdline: check return value at initialization
Date: Thu, 19 May 2016 14:26:02 +0200 [thread overview]
Message-ID: <2023616.jWtzSNvIF8@xps13> (raw)
In-Reply-To: <1463474217-30875-1-git-send-email-olivier.matz@6wind.com>
2016-05-17 10:36, Olivier Matz:
> From: Marcin Kerlin <marcinx.kerlin@intel.com>
>
> The value returned by rdline_init() was not checked in cmdline_new().
> On error, free the allocated memory and return NULL.
>
> This condition should not happen today, but it's safer to do the check
> in case rdline_init() is updated.
>
> Fixes: af75078fece3 ("first public release")
> Coverity ID 13204
>
> Signed-off-by: Marcin Kerlin <marcinx.kerlin@intel.com>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>
> Hi Marcin,
>
> I updated the commit log and title to be clearer.
Applied, thanks
prev parent reply other threads:[~2016-05-19 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 15:18 [dpdk-dev] [PATCH 1/1] lib/librte_cmdline: fix added checking return value Marcin Kerlin
2016-05-17 8:36 ` [dpdk-dev] [PATCH v2] cmdline: check return value at initialization Olivier Matz
2016-05-19 12:26 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023616.jWtzSNvIF8@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=marcinx.kerlin@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).