DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Madhuker Mythri <madhuker.mythri@oracle.com>
Cc: "ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements.
Date: Fri, 5 Jan 2024 09:41:27 -0800	[thread overview]
Message-ID: <20240105094127.62346585@hermes.local> (raw)
In-Reply-To: <SJ0PR10MB4798716CDAE44555EA18B7BF97662@SJ0PR10MB4798.namprd10.prod.outlook.com>

On Fri, 5 Jan 2024 15:11:22 +0000
Madhuker Mythri <madhuker.mythri@oracle.com> wrote:

> By using this " bpf_skb_load_bytes_relative()" helper function we can directly retrieve the Network header data fields, so we no need to check for L2-header VLAN presence.
> 
> Thanks,
> Madhuker.

No problem, the vlan code was already broken. The kernel offloads vlan header to skb
but who ever wrote the original did not know that is what happens in modern kernels.

  reply	other threads:[~2024-01-05 17:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04 17:27 madhuker.mythri
2024-01-04 20:32 ` Stephen Hemminger
2024-01-05 14:58   ` [External] : " Madhuker Mythri
2024-01-04 20:33 ` Stephen Hemminger
2024-01-04 20:35 ` Stephen Hemminger
2024-01-04 20:38 ` Stephen Hemminger
2024-01-05 14:58   ` [External] : " Madhuker Mythri
2024-01-05 17:40     ` Stephen Hemminger
2024-01-04 20:39 ` Stephen Hemminger
2024-01-04 20:41 ` Stephen Hemminger
2024-01-05 15:11   ` [External] : " Madhuker Mythri
2024-01-05 17:41     ` Stephen Hemminger [this message]
2024-01-04 20:42 ` Stephen Hemminger
2024-01-04 20:57 ` Stephen Hemminger
2024-01-05 14:44   ` [External] : " Madhuker Mythri
2024-01-05 17:39     ` Stephen Hemminger
2024-01-06  5:47       ` Madhuker Mythri
2024-01-05 19:30 ` Stephen Hemminger
2024-01-06  5:36   ` [External] : " Madhuker Mythri
2024-01-06 10:23     ` Madhuker Mythri
2024-01-06 16:54       ` Stephen Hemminger
2024-01-06 18:16       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240105094127.62346585@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=madhuker.mythri@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).