From: Stephen Hemminger <stephen@networkplumber.org>
To: Hernan Vargas <hernan.vargas@intel.com>
Cc: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,
maxime.coquelin@redhat.com, nicolas.chautru@intel.com,
qi.z.zhang@intel.com
Subject: Re: [PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for consistency
Date: Fri, 5 Jan 2024 14:00:04 -0800 [thread overview]
Message-ID: <20240105140004.7389f645@hermes.local> (raw)
In-Reply-To: <20240105211519.185086-2-hernan.vargas@intel.com>
On Fri, 5 Jan 2024 13:15:16 -0800
Hernan Vargas <hernan.vargas@intel.com> wrote:
> +#define FPGA_5GNR_QUEUE_FLUSH_TIMEOUT_US (1000)
Just my opinion, no need it doesn't have to change but.
These variable names are getting quite long which doesn't
improve readability.
next prev parent reply other threads:[~2024-01-05 22:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 21:15 [PATCH v4 0/4] changes for 24.03 Hernan Vargas
2024-01-05 21:15 ` [PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for consistency Hernan Vargas
2024-01-05 22:00 ` Stephen Hemminger [this message]
2024-01-10 17:19 ` Chautru, Nicolas
2024-01-05 21:15 ` [PATCH v4 2/4] baseband/fpga_5gnr_fec: add Vista Creek variant Hernan Vargas
2024-01-15 10:48 ` Maxime Coquelin
2024-01-05 21:15 ` [PATCH v4 3/4] baseband/fpga_5gnr_fec: add AGX100 support Hernan Vargas
2024-01-15 16:59 ` Maxime Coquelin
2024-01-05 21:15 ` [PATCH v4 4/4] baseband/fpga_5gnr_fec: cosmetic comment changes Hernan Vargas
2024-01-05 22:00 ` Stephen Hemminger
2024-01-10 17:17 ` Chautru, Nicolas
2024-01-16 13:12 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240105140004.7389f645@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=nicolas.chautru@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).