From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] build: fix linker warnings about undefined symbols
Date: Wed, 10 Jan 2024 08:58:14 -0800 [thread overview]
Message-ID: <20240110165814.GA25069@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20240110150103.529080-1-bruce.richardson@intel.com>
On Wed, Jan 10, 2024 at 03:01:03PM +0000, Bruce Richardson wrote:
> The default behaviour of "ld.lld" has changed, so it now prints out
> warnings about entries in the version.map file which don't exist in
> the current build. Since we use our version.map file simply to filter
> out the functions we don't want made public, we include in it all
> functions across all OS's and builds that we want public if present.
> This causes these ld warnings to be emitted, e.g. on BSD, which is
> missing functionality found on Linux. For example:
>
> * hpet functions in EAL
> * regexdev enqueue and dequeue burst
> * eventdev event_timer functions
>
> Easiest solution, without major rework of how we use our version.map
> files, and without dynamically generating them per-build, is to pass
> the --undefined-version flag to the linker, to restore the old
> behaviour.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
i don't know if has ever been discussed but a way to achieve a similar
outcome would be to introduce a visibility macro allowing the data and
function symbols to be explicitly made visible while making the build
default hidden.
https://gcc.gnu.org/wiki/Visibility
on windows symbols are hidden by default (opposite of gnu toolchain) and
allowing the symbols that are intended to be public be annotated in code
with a macro instead of a separate map/def file would arguably appear
more consistent. additionally, the current process of converting a map
file to a def file for windows has limitations with respect to things
like marking the type of symbol being exported.
ty
next prev parent reply other threads:[~2024-01-10 16:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 15:01 Bruce Richardson
2024-01-10 16:58 ` Tyler Retzlaff [this message]
2024-01-11 9:38 ` Morten Brørup
2024-01-11 9:48 ` Bruce Richardson
2024-01-12 20:11 ` Tyler Retzlaff
2024-01-12 20:49 ` Morten Brørup
2024-01-12 22:22 ` Stephen Hemminger
2024-01-15 8:56 ` David Marchand
2024-01-15 16:17 ` Tyler Retzlaff
2024-02-18 17:38 ` Thomas Monjalon
2024-02-20 17:02 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240110165814.GA25069@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).