From: Stephen Hemminger <stephen@networkplumber.org>
To: madhuker.mythri@oracle.com
Cc: dev@dpdk.org, ferruh.yigit@amd.com
Subject: Re: [PATCH] net/tap: Modified TAP BPF program as per the Kernel-version upgrade requirements.
Date: Fri, 12 Jan 2024 08:43:59 -0800 [thread overview]
Message-ID: <20240112084359.603c1ed8@hermes.local> (raw)
In-Reply-To: <20240112134821.2067-1-madhuker.mythri@oracle.com>
On Fri, 12 Jan 2024 19:18:21 +0530
madhuker.mythri@oracle.com wrote:
> + if (bpf_skb_load_bytes_relative(skb, 0, &nh, sizeof(nh), BPF_HDR_START_NET))
> + return TC_ACT_OK;
> + if (nh.iph.version == 4) {
Using IP header bytes, instead of ether header protocol (in skb->proto)
is changing functionality and wrong. You don't want to be seeing some other
protocol (not IPv4 or IPv6) that just happened to have the 4 in that nibble.
Original code was fine.
next prev parent reply other threads:[~2024-01-12 16:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 13:48 madhuker.mythri
2024-01-12 16:40 ` Stephen Hemminger
2024-01-12 16:41 ` Stephen Hemminger
2024-01-13 17:50 ` [External] : " Madhuker Mythri
2024-01-13 18:05 ` Stephen Hemminger
2024-01-16 16:43 ` Stephen Hemminger
2024-01-12 16:42 ` Stephen Hemminger
2024-01-13 17:52 ` [External] : " Madhuker Mythri
2024-01-13 18:06 ` Stephen Hemminger
2024-01-16 5:43 ` Madhuker Mythri
2024-01-16 16:40 ` Stephen Hemminger
2024-01-17 3:25 ` Stephen Hemminger
2024-01-17 16:19 ` Madhuker Mythri
2024-01-12 16:43 ` Stephen Hemminger [this message]
2024-01-12 16:46 ` Stephen Hemminger
2024-01-13 17:55 ` [External] : " Madhuker Mythri
2024-01-12 17:53 ` [RFC v3] tap: rework the BPF header parsing Stephen Hemminger
2024-02-07 18:55 ` [PATCH] net/tap: Modified TAP BPF program as per the Kernel-version upgrade requirements Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112084359.603c1ed8@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=madhuker.mythri@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).