From: Stephen Hemminger <stephen@networkplumber.org>
To: "Mattias Rönnblom" <hofors@lysator.liu.se>
Cc: dev@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>,
"Tyler Retzlaff" <roretzla@linux.microsoft.com>
Subject: Re: [PATCH v3 5/5] eal: replace out of bounds VLA with static_assert
Date: Wed, 17 Jan 2024 09:11:36 -0800 [thread overview]
Message-ID: <20240117091136.6bdb72ec@hermes.local> (raw)
In-Reply-To: <2e1c560d-f19c-4a3c-a066-2e80a9c71f86@lysator.liu.se>
On Wed, 17 Jan 2024 08:53:44 +0100
Mattias Rönnblom <hofors@lysator.liu.se> wrote:
> > * Triggers an error at compilation time if the condition is true.
> > */
> > -#define RTE_BUILD_BUG_ON(condition) ((void)sizeof(char[1 - 2*!!(condition)]))
> > +#define RTE_BUILD_BUG_ON(condition) { static_assert(!(condition), #condition); }
> >
> > /*********** Cache line related macros ********/
> >
>
> Should one use RTE_BUILD_BUG_ON() or static_assert() in new DPDK code?
>
> If static_assert() occasionally needs a work-around, it sounds like
> keeping using RTE_BUILD_BUG_ON() everywhere is the better choice.
Either choice is the same. Keeping the macro instead of directly using
static_assert will reduce the effort to change when the next C standard
introduces something different.
But using static_assert() can allow for a better warning message.
next prev parent reply other threads:[~2024-01-17 17:11 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 17:21 [RFC] eal: use _Static_assert() for RTE_BUILD_BUG_ON Stephen Hemminger
2023-11-11 17:52 ` Morten Brørup
2023-11-13 16:30 ` Tyler Retzlaff
2023-11-13 16:28 ` Tyler Retzlaff
2023-11-13 17:06 ` [PATCH v2 0/3] use static_assertion for build errors Stephen Hemminger
2023-11-13 17:06 ` [PATCH v2 1/3] event/opdl: fix non-constant compile time assertion Stephen Hemminger
2023-11-13 17:10 ` Bruce Richardson
2023-11-13 17:54 ` Tyler Retzlaff
2023-11-13 17:06 ` [PATCH v2 2/3] net/sfc: fix non-constant expression inr RTE_BUILD_BUG_ON() Stephen Hemminger
2023-11-13 17:55 ` Tyler Retzlaff
2023-11-13 22:13 ` Stephen Hemminger
2023-11-13 22:28 ` Tyler Retzlaff
2023-11-14 0:00 ` Stephen Hemminger
2023-11-14 0:16 ` Stephen Hemminger
2023-11-14 0:22 ` Stephen Hemminger
2023-11-14 5:50 ` Morten Brørup
2023-11-13 17:06 ` [PATCH v2 3/3] eal: replace out of bounds VLA with static_assert Stephen Hemminger
2023-11-13 17:12 ` Bruce Richardson
2023-11-13 17:57 ` Tyler Retzlaff
2024-02-16 0:33 ` Tyler Retzlaff
2024-02-16 7:48 ` Morten Brørup
2024-02-16 8:02 ` David Marchand
2024-02-16 20:30 ` Tyler Retzlaff
2023-11-13 18:13 ` [PATCH v2 0/3] use static_assertion for build errors Ferruh Yigit
2023-11-13 18:28 ` Morten Brørup
2023-11-13 18:57 ` Tyler Retzlaff
2023-11-17 16:18 ` [PATCH v3 00/10] replace uses of zero length array Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 01/10] member: replace zero length array with flex array Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 02/10] cryptodev: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 03/10] security: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 04/10] pipeline: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 05/10] net/nfp: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 06/10] net/enic: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 07/10] net/mlx5: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 08/10] pdcp: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 09/10] net/cpfl: " Stephen Hemminger
2023-11-17 16:18 ` [PATCH v3 10/10] common/dpaxx: remove zero length array Stephen Hemminger
2024-01-16 18:41 ` [PATCH v3 0/5] use static_assert to catch build errors Stephen Hemminger
2024-01-16 18:41 ` [PATCH v3 1/5] event/opdl: fix non-constant compile time assertion Stephen Hemminger
2024-01-17 7:58 ` Andrew Rybchenko
2024-01-17 9:26 ` Bruce Richardson
2024-01-17 9:57 ` Morten Brørup
2024-01-16 18:41 ` [PATCH v3 2/5] net/sfc: fix non-constant expression in RTE_BUILD_BUG_ON() Stephen Hemminger
2024-01-17 7:57 ` Andrew Rybchenko
2024-01-16 18:41 ` [PATCH v3 3/5] net/i40e: avoid using const variable in assertion Stephen Hemminger
2024-01-16 18:41 ` [PATCH v3 4/5] mempool: avoid floating point expression in static assertion Stephen Hemminger
2024-01-17 8:06 ` Andrew Rybchenko
2024-01-16 18:41 ` [PATCH v3 5/5] eal: replace out of bounds VLA with static_assert Stephen Hemminger
2024-01-17 7:52 ` Andrew Rybchenko
2024-01-17 17:12 ` Stephen Hemminger
2024-01-17 7:53 ` Mattias Rönnblom
2024-01-17 17:11 ` Stephen Hemminger [this message]
2024-01-17 18:19 ` [PATCH v4 0/6] use static assert to cathc build errors Stephen Hemminger
2024-01-17 18:19 ` [PATCH v4 1/6] eal: introduce RTE_MIN_T() and RTE_MAX_T() macros Stephen Hemminger
2024-01-18 9:35 ` Konstantin Ananyev
2024-01-18 9:44 ` Andrew Rybchenko
2024-01-19 20:58 ` Tyler Retzlaff
2024-01-19 22:39 ` Stephen Hemminger
2024-01-17 18:19 ` [PATCH v4 2/6] event/opdl: fix non-constant compile time assertion Stephen Hemminger
2024-01-18 9:43 ` Andrew Rybchenko
2024-01-17 18:19 ` [PATCH v4 3/6] net/sfc: fix non-constant expression in RTE_BUILD_BUG_ON() Stephen Hemminger
2024-01-18 9:40 ` Andrew Rybchenko
2024-01-17 18:19 ` [PATCH v4 4/6] net/i40e: avoid using const variable in assertion Stephen Hemminger
2024-01-18 8:57 ` Bruce Richardson
2024-01-18 9:34 ` Konstantin Ananyev
2024-01-17 18:19 ` [PATCH v4 5/6] mempool: avoid floating point expression in static assertion Stephen Hemminger
2024-01-17 18:32 ` Morten Brørup
2024-01-18 9:41 ` Andrew Rybchenko
2024-01-18 9:32 ` Konstantin Ananyev
2024-01-17 18:20 ` [PATCH v4 6/6] eal: replace out of bounds VLA with static_assert Stephen Hemminger
2024-01-18 16:50 ` [PATCH v5 0/6] use static_assert for build error reports Stephen Hemminger
2024-01-18 16:50 ` [PATCH v5 1/6] eal: introduce RTE_MIN_T() and RTE_MAX_T() macros Stephen Hemminger
2024-01-19 1:30 ` fengchengwen
2024-01-18 16:50 ` [PATCH v5 2/6] event/opdl: fix non-constant compile time assertion Stephen Hemminger
2024-01-18 16:50 ` [PATCH v5 3/6] net/sfc: fix non-constant expression in RTE_BUILD_BUG_ON() Stephen Hemminger
2024-01-18 16:50 ` [PATCH v5 4/6] net/i40e: avoid using const variable in assertion Stephen Hemminger
2024-01-18 16:51 ` [PATCH v5 5/6] mempool: avoid floating point expression in static assertion Stephen Hemminger
2024-01-18 18:46 ` Morten Brørup
2024-01-19 10:07 ` Slava Ovsiienko
2024-01-18 16:51 ` [PATCH v5 6/6] eal: replace out of bounds VLA with static_assert Stephen Hemminger
2024-01-18 18:42 ` Morten Brørup
2024-01-19 13:10 ` Ferruh Yigit
2024-02-16 9:14 ` [PATCH v5 0/6] use static_assert for build error reports David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240117091136.6bdb72ec@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=hofors@lysator.liu.se \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).