From: Rahul Gupta <rahulgupt@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: David Marchand <david.marchand@redhat.com>,
dev@dpdk.org, bruce.richardson@intel.com,
dmitry.kozliuk@gmail.com, stephen@networkplumber.org,
sovaradh@linux.microsoft.com, okaya@kernel.org,
sujithsankar@microsoft.com, sowmini.varadhan@microsoft.com,
krathinavel@microsoft.com, rahulrgupta27@gmail.com
Subject: Re: [dpdk-dev] [PATCH v4] eal: refactor rte_eal_init into sub-functions
Date: Sat, 3 Feb 2024 04:57:49 -0800 [thread overview]
Message-ID: <20240203125749.GA28537@microsoft.com> (raw)
In-Reply-To: <2255489.irdbgypaU6@thomas>
On (02/02/24 11:21), Thomas Monjalon wrote:
> Date: Fri, 02 Feb 2024 11:21:59 +0100
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Rahul Gupta <rahulgupt@linux.microsoft.com>
> Cc: David Marchand <david.marchand@redhat.com>, dev@dpdk.org,
> bruce.richardson@intel.com, dmitry.kozliuk@gmail.com,
> stephen@networkplumber.org, sovaradh@linux.microsoft.com,
> okaya@kernel.org, sujithsankar@microsoft.com,
> sowmini.varadhan@microsoft.com, krathinavel@microsoft.com,
> rahulrgupta27@gmail.com
> Subject: Re: [dpdk-dev] [PATCH v4] eal: refactor rte_eal_init into
> sub-functions
>
> 29/01/2024 08:55, David Marchand:
> > On Mon, Jan 29, 2024 at 6:35 AM Rahul Gupta
> > <rahulgupt@linux.microsoft.com> wrote:
> > > > Looking at what this patch does.. I am under the impression all you
> > > > really need is rte_eal_init without initial probing.
> > > > Such behavior can probably be achieved with a allowlist set to a non
> > > > existing device (like for example "-a 0000:00:00.0"), then later, use
> > > > device hotplug.
> > > The patch will be useful to all the adapters irrespective of their
> > > host plug support.
> >
> > I did not say hotplug support is needed.
> > If what I described already works, this patch adds nothing.
>
> I agree with David.
> Disabling initial probing should provide what you want.
> Did you test his proposal?
>
>
Yes, I was about to reply after testing same, will be done with testing in few days.
But I think the bootup time saved by my patch and hot plug patch will be almost same,
because apart from FLR (probe()) the extra work done by my patch (i.e. telemetry,
rte_service_init() in parallel to mbuf pool creation) are consuming very less bootup time.
So in future if more things are added to 2nd part of eal_init (i.e. rte_eal_init_async_setup()),
then the bootup time will be less if we use my patch.
I think we can defer this patch till then.
Thanks,
Rahul.
next prev parent reply other threads:[~2024-02-03 12:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 13:45 Rahul Gupta
2024-01-24 15:47 ` Stephen Hemminger
2024-01-24 15:47 ` Stephen Hemminger
2024-01-24 15:53 ` David Marchand
2024-01-29 5:35 ` Rahul Gupta
2024-01-29 7:55 ` David Marchand
2024-02-02 10:21 ` Thomas Monjalon
2024-02-03 12:57 ` Rahul Gupta [this message]
2024-02-08 17:05 ` Rahul Gupta
2024-01-24 17:49 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240203125749.GA28537@microsoft.com \
--to=rahulgupt@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=krathinavel@microsoft.com \
--cc=okaya@kernel.org \
--cc=rahulrgupta27@gmail.com \
--cc=sovaradh@linux.microsoft.com \
--cc=sowmini.varadhan@microsoft.com \
--cc=stephen@networkplumber.org \
--cc=sujithsankar@microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).