From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Yipeng Wang <yipeng1.wang@intel.com>,
mb@smartsharesystems.com, fengchengwen@huawei.com,
Dodji Seketeli <dodji@redhat.com>
Subject: Re: [PATCH v2 0/4] more replacement of zero length array
Date: Tue, 13 Feb 2024 11:20:42 -0800 [thread overview]
Message-ID: <20240213192042.GA24086@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <CAJFAV8wNDj7f0Qzwp3UYsYUxQH2KObBFRzNTzTOeU=A_i3FVzA@mail.gmail.com>
On Tue, Feb 13, 2024 at 02:14:28PM +0100, David Marchand wrote:
> On Mon, Feb 12, 2024 at 11:36 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > Replace some missed zero length arrays not captured in the
> > original series.
> > https://patchwork.dpdk.org/project/dpdk/list/?series=30410&state=*
> >
> > Zero length arrays are a GNU extension that has been
> > superseded by flex arrays.
> >
> > https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> >
> > v2:
> > * added additional patches for fib & pipeline libs.
> > series-acks have been placed only against original
> > hash and rcu patches.
>
> There seems to be an issue with the ABI check on those changes.
> After a quick chat with Dodji, I opened a bug for libabigail.
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=31377
I double checked again and I don't see the struct in question being
embedded as a field of another struct/union. So I don't think there should
be an ABI change here.
I'm okay with the change being merged but if there is concern I can drop
this patch from the series.
>
>
> --
> David Marchand
next prev parent reply other threads:[~2024-02-13 19:20 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 22:17 [PATCH 0/2] " Tyler Retzlaff
2024-01-24 22:17 ` [PATCH 1/2] hash: replace zero length array with flex array Tyler Retzlaff
2024-01-24 22:57 ` Honnappa Nagarahalli
2024-01-25 7:16 ` Morten Brørup
2024-01-24 22:17 ` [PATCH 2/2] rcu: " Tyler Retzlaff
2024-01-24 22:57 ` Honnappa Nagarahalli
2024-01-25 7:14 ` Morten Brørup
2024-01-25 12:57 ` [PATCH 0/2] more replacement of zero length array fengchengwen
2024-02-12 22:36 ` [PATCH v2 0/4] " Tyler Retzlaff
2024-02-12 22:36 ` [PATCH v2 1/4] hash: replace zero length array with flex array Tyler Retzlaff
2024-02-12 22:36 ` [PATCH v2 2/4] rcu: " Tyler Retzlaff
2024-02-12 22:36 ` [PATCH v2 3/4] fib: " Tyler Retzlaff
2024-02-12 22:36 ` [PATCH v2 4/4] pipeline: " Tyler Retzlaff
2024-02-12 22:57 ` [PATCH v2 0/4] more replacement of zero length array Stephen Hemminger
2024-02-13 8:31 ` Morten Brørup
2024-02-13 13:14 ` David Marchand
2024-02-13 19:20 ` Tyler Retzlaff [this message]
2024-02-14 7:36 ` David Marchand
2024-02-16 10:14 ` David Marchand
2024-02-16 20:46 ` Tyler Retzlaff
2024-02-18 12:31 ` Dodji Seketeli
2024-02-27 23:56 ` [PATCH v3 0/6] " Tyler Retzlaff
2024-02-27 23:56 ` [PATCH v3 1/6] hash: replace zero length array with flex array Tyler Retzlaff
2024-02-27 23:56 ` [PATCH v3 2/6] rcu: " Tyler Retzlaff
2024-02-27 23:56 ` [PATCH v3 3/6] fib: " Tyler Retzlaff
2024-02-27 23:56 ` [PATCH v3 4/6] pipeline: " Tyler Retzlaff
2024-02-27 23:56 ` [PATCH v3 5/6] lpm: " Tyler Retzlaff
2024-02-28 7:26 ` Morten Brørup
2024-02-27 23:56 ` [PATCH v3 6/6] table: " Tyler Retzlaff
2024-02-28 7:27 ` Morten Brørup
2024-02-29 22:58 ` [PATCH v4 0/6] more replacement of zero length array Tyler Retzlaff
2024-02-29 22:58 ` [PATCH v4 1/6] hash: replace zero length array with flex array Tyler Retzlaff
2024-02-29 22:58 ` [PATCH v4 2/6] rcu: " Tyler Retzlaff
2024-02-29 22:58 ` [PATCH v4 3/6] fib: " Tyler Retzlaff
2024-02-29 22:58 ` [PATCH v4 4/6] pipeline: " Tyler Retzlaff
2024-02-29 22:58 ` [PATCH v4 5/6] lpm: " Tyler Retzlaff
2024-03-01 8:12 ` Morten Brørup
2024-02-29 22:58 ` [PATCH v4 6/6] table: " Tyler Retzlaff
2024-03-01 8:13 ` Morten Brørup
2024-03-06 19:39 ` [PATCH v4 0/6] more replacement of zero length array Tyler Retzlaff
2024-03-06 20:13 ` [PATCH v5 " Tyler Retzlaff
2024-03-06 20:13 ` [PATCH v5 1/6] hash: replace zero length array with flex array Tyler Retzlaff
2024-03-06 20:52 ` Medvedkin, Vladimir
2024-03-06 20:13 ` [PATCH v5 2/6] rcu: " Tyler Retzlaff
2024-03-06 20:13 ` [PATCH v5 3/6] fib: " Tyler Retzlaff
2024-03-06 20:53 ` Medvedkin, Vladimir
2024-03-06 20:13 ` [PATCH v5 4/6] pipeline: " Tyler Retzlaff
2024-03-06 20:13 ` [PATCH v5 5/6] lpm: " Tyler Retzlaff
2024-03-06 20:53 ` Medvedkin, Vladimir
2024-03-06 20:13 ` [PATCH v5 6/6] table: " Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213192042.GA24086@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dodji@redhat.com \
--cc=fengchengwen@huawei.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=mb@smartsharesystems.com \
--cc=sameh.gobriel@intel.com \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).