From: Stephen Hemminger <stephen@networkplumber.org>
To: Isaac Boukris <iboukris@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] dumpcap: correctly disable promiscuous mode at exit
Date: Tue, 27 Feb 2024 10:07:48 -0800 [thread overview]
Message-ID: <20240227100748.086d5bfd@hermes.local> (raw)
In-Reply-To: <20240227092326.340229-1-iboukris@gmail.com>
On Tue, 27 Feb 2024 11:23:26 +0200
Isaac Boukris <iboukris@gmail.com> wrote:
> Signed-off-by: Isaac Boukris <iboukris@gmail.com>
> ---
> app/dumpcap/main.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
> index d57db0589a..88cec43086 100644
> --- a/app/dumpcap/main.c
> +++ b/app/dumpcap/main.c
> @@ -830,11 +830,12 @@ static void enable_pdump(struct rte_ring *r, struct rte_mempool *mp)
> intf->opts.promisc_mode = false;
> } else {
> ret = rte_eth_promiscuous_enable(intf->port);
> - if (ret != 0)
> + if (ret != 0) {
> fprintf(stderr,
> "port %u set promiscuous enable failed: %d\n",
> intf->port, ret);
> - intf->opts.promisc_mode = false;
> + intf->opts.promisc_mode = false;
> + }
> }
> }
> ++count;
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2024-02-27 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 9:23 Isaac Boukris
2024-02-27 18:07 ` Stephen Hemminger [this message]
2024-03-06 21:45 ` Thomas Monjalon
2024-03-07 22:37 ` [PATCH v2] " Stephen Hemminger
2024-03-08 7:09 ` Isaac Boukris
2024-03-18 3:04 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227100748.086d5bfd@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=iboukris@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).