From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
mb@smartsharesystems.com
Subject: Re: [PATCH v2 0/3] use rte macros instead of GCC __attribute
Date: Wed, 6 Mar 2024 13:22:35 -0800 [thread overview]
Message-ID: <20240306212235.GA1082@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <CAJFAV8wF9zJ6sN024=eXJ5LMD9hV-y6TH7ur5XVF6+5a1M9L6w@mail.gmail.com>
On Wed, Mar 06, 2024 at 09:49:31PM +0100, David Marchand wrote:
> On Wed, Feb 28, 2024 at 7:48 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > Clean up direct uses of GCC __attribute__ in libs outside of EAL. A
> > checkpatch check already warns for new additions.
> >
> > v2:
> > * fix typo __rte_pure -> __rte_may_alias in rcu commit message
> >
> > Tyler Retzlaff (3):
> > eal: add rte pure attribute macro
> > lpm: use rte macro instead of GCC attribute
> > rcu: use rte macro instead of GCC attribute
> >
> > lib/eal/include/rte_common.h | 9 +++++++++
> > lib/lpm/rte_lpm.c | 4 ++--
> > lib/lpm/rte_lpm6.c | 2 +-
> > lib/rcu/rcu_qsbr_pvt.h | 2 +-
> > 4 files changed, 13 insertions(+), 4 deletions(-)
>
> Introducing __rte_pure and converting lib/lpm looks fine.
> But please finish the job for the other occurence in the tree as it is
> a mechanical change.
Sure, it's trivial that I don't have to burn it in on lib first.
Will submit an updated rev.
>
> Thanks.
>
> --
> David Marchand
next prev parent reply other threads:[~2024-03-06 21:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 23:07 [PATCH " Tyler Retzlaff
2024-02-27 23:07 ` [PATCH 1/3] eal: add rte pure attribute macro Tyler Retzlaff
2024-02-27 23:07 ` [PATCH 2/3] lpm: use rte macro instead of GCC attribute Tyler Retzlaff
2024-02-27 23:07 ` [PATCH 3/3] rcu: " Tyler Retzlaff
2024-02-28 9:29 ` Morten Brørup
2024-02-28 17:29 ` Tyler Retzlaff
2024-02-28 18:47 ` [PATCH v2 0/3] use rte macros instead of GCC __attribute Tyler Retzlaff
2024-02-28 18:47 ` [PATCH v2 1/3] eal: add rte pure attribute macro Tyler Retzlaff
2024-02-28 18:47 ` [PATCH v2 2/3] lpm: use rte macro instead of GCC attribute Tyler Retzlaff
2024-03-06 20:51 ` Medvedkin, Vladimir
2024-02-28 18:47 ` [PATCH v2 3/3] rcu: " Tyler Retzlaff
2024-03-06 19:36 ` [PATCH v2 0/3] use rte macros instead of GCC __attribute Tyler Retzlaff
2024-03-06 20:49 ` David Marchand
2024-03-06 21:22 ` Tyler Retzlaff [this message]
2024-03-06 22:14 ` [PATCH v3 0/5] " Tyler Retzlaff
2024-03-06 22:14 ` [PATCH v3 1/5] eal: add rte pure attribute macro Tyler Retzlaff
2024-03-06 22:14 ` [PATCH v3 2/5] lpm: use rte macro instead of GCC attribute Tyler Retzlaff
2024-03-06 22:14 ` [PATCH v3 3/5] rcu: " Tyler Retzlaff
2024-03-06 22:14 ` [PATCH v3 4/5] app/test: " Tyler Retzlaff
2024-03-06 22:41 ` Morten Brørup
2024-03-06 22:14 ` [PATCH v3 5/5] net/cxgbe: " Tyler Retzlaff
2024-03-06 22:42 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306212235.GA1082@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=mb@smartsharesystems.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).