DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Ori Kam <orika@nvidia.com>,
	Aman Singh <aman.deep.singh@intel.com>,
	Yuying Zhang <yuying.zhang@intel.com>
Subject: Re: [PATCH] test-pmd: add more packet decode options (verbose)
Date: Wed, 13 Mar 2024 14:49:55 -0700	[thread overview]
Message-ID: <20240313144955.1821c981@hermes.local> (raw)
In-Reply-To: <20240312220129.70667-1-stephen@networkplumber.org>

On Tue, 12 Mar 2024 15:01:27 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> The existing verbose levels 1..3 provide a messy multi-line
> output per packet. This is unhelpful when diagnosing many
> types of problems like packet flow.
> 
> This patch adds two new levels:
> 4: one line per packet is printed in a format resembling
>    tshark output. With addresses and protocol info.
> 5: dump packet in hex.
>    Useful if the driver is messing up the data.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

The build on mingw (ie. GCC on Windows) fails because of mismatch
in the function prototype. It is already fixed upstream in mingw
could the CI infrastructure please be updated. 

The commit upstream that fixed the bug was almost 5 years ago.

commit 1b5ae4b567ee1699f69cd918ae2bc693898edbb2
Author: Martin Storsjö <martin@martin.st>
Date:   Mon Apr 22 15:09:14 2019 +0300

    headers: Use proper types for InetNtopA/W
    
    PCVOID is not commonly defined, only LPCVOID.
    
    Signed-off-by: Martin Storsjö <martin@martin.st>


This commit is in the 7.0 release.
The current version of MinGw is 11.0 which is what CI should be using!

Unfortunately, DPDK documentation and build does not have a version listed.

      reply	other threads:[~2024-03-13 21:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12 22:01 Stephen Hemminger
2024-03-13 21:49 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240313144955.1821c981@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=aman.deep.singh@intel.com \
    --cc=dev@dpdk.org \
    --cc=orika@nvidia.com \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).