From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Yipeng Wang <yipeng1.wang@intel.com>
Subject: Re: [PATCH] hash: remove return statement from function returning void
Date: Thu, 14 Mar 2024 09:30:31 -0700 [thread overview]
Message-ID: <20240314163031.GA27730@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <CAJFAV8wnFA57HJh5Tp7bTJySKkyQ+tfRiQLuricKNYe3zfSLLA@mail.gmail.com>
On Thu, Mar 14, 2024 at 04:58:54PM +0100, David Marchand wrote:
> Hello Tyler,
>
> On Fri, Mar 8, 2024 at 10:20 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > rte_thash_gfni_bulk and rte_thash_gfni_bulk_stub both return void.
> > Remove superfluous return statement from rte_thash_gfni_bulk.
> >
> > Fixes: 944a03a5cfc1 ("hash: fix MSVC link on GFNI stubs")
> > Cc: stephen@networkplumber.org
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> > lib/hash/rte_thash_gfni.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/hash/rte_thash_gfni.h b/lib/hash/rte_thash_gfni.h
> > index edae2e8..132f375 100644
> > --- a/lib/hash/rte_thash_gfni.h
> > +++ b/lib/hash/rte_thash_gfni.h
> > @@ -71,7 +71,7 @@
> > rte_thash_gfni_bulk(const uint64_t *mtrx, int len, uint8_t *tuple[],
> > uint32_t val[], uint32_t num)
> > {
> > - return rte_thash_gfni_bulk_stub(mtrx, len, tuple, val, num);
> > + rte_thash_gfni_bulk_stub(mtrx, len, tuple, val, num);
> > }
>
> I am surprised the CI did not catch it.
> I need to pass -pedantic when compiling with this header, but no code
> does this in-tree.
> How did you catch this issue?
MSVC warns about it (and hundreds of other things). Benefits of compiling the
same code with a compiler not sharing the same lineage.
>
>
> --
> David Marchand
next prev parent reply other threads:[~2024-03-14 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 21:20 Tyler Retzlaff
2024-03-14 15:58 ` David Marchand
2024-03-14 16:30 ` Tyler Retzlaff [this message]
2024-04-04 18:19 ` Tyler Retzlaff
2024-05-16 16:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240314163031.GA27730@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=sameh.gobriel@intel.com \
--cc=stephen@networkplumber.org \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).