From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, "Bruce Richardson" <bruce.richardson@intel.com>,
"Stephen Hemminger" <stephen@networkplumber.org>,
"Thomas Monjalon" <thomas@monjalon.net>,
"Ferruh Yigit" <ferruh.yigit@amd.com>,
"Akhil Goyal" <gakhil@marvell.com>,
"Jerin Jacob Kollanukkaran" <jerinj@marvell.com>,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH 00/83] move alignment attribute on types
Date: Wed, 20 Mar 2024 12:12:20 -0700 [thread overview]
Message-ID: <20240320191220.GB12261@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <CAJFAV8wTDBj0qCUHn3y897LcZ7k_UbffVfjHO5jSuvy-FvZGTw@mail.gmail.com>
On Wed, Mar 20, 2024 at 06:41:30PM +0100, David Marchand wrote:
> Hello Tyler,
>
> On Wed, Mar 20, 2024 at 4:38 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > The current location used for __rte_aligned(a) for alignment of types
> > and variables is not compatible with MSVC. There is only a single
> > location accepted by both toolchains.
> >
> > After having established this as the conventional standard for lib/*
> > this series is intended to convert the remainder of the source tree to
> > use the same location for __rte_aligned(a) and alignas(a) for
> > consistency.
>
> The series looks good to me.
>
> We may have some misses because of drivers wrapping in their own
> stuff, but I am not sure those are fixable (this touches some base
> drivers..)
> drivers/common/cnxk/roc_platform.h:#define __plt_aligned __rte_aligned
> drivers/common/dpaax/compat.h:#define ____cacheline_aligned
> __rte_aligned(L1_CACHE_BYTES)
> drivers/common/cnxk/roc_platform.h:#define __plt_cache_aligned
> __rte_cache_aligned
> drivers/net/ena/base/ena_plat_dpdk.h:#define ____cacheline_aligned
> __rte_cache_aligned
> drivers/net/gve/base/gve_osdep.h:#define ____cacheline_aligned
> __rte_cache_aligned
Yes, I know about these and I made the call to leave them untouched for
now. The cnxk drivers aren't built on windows and i didn't want to
interfere with some out of tree abstraction they may be using for
testing.
>
> I also noticed memif:
> drivers/net/memif/memif.h:typedef struct __rte_packed __rte_aligned(128)
This should be okay, I also have to address __rte_packed (series coming
soon).
So long as there are no objections I would propose this series merged as
soon as possible (after release) assuming CI doesn't identify anything
of concern. if there is follow up to do with cnxk/dpaax i'm happy to do
it as a separate series.
ty
next prev parent reply other threads:[~2024-03-20 19:12 UTC|newest]
Thread overview: 181+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 15:36 Tyler Retzlaff
2024-03-20 15:36 ` [PATCH 01/83] examples: " Tyler Retzlaff
2024-04-06 14:55 ` Morten Brørup
2024-04-08 15:44 ` Tyler Retzlaff
2024-04-10 15:29 ` Akhil Goyal
2024-03-20 15:36 ` [PATCH 02/83] net/ark: " Tyler Retzlaff
2024-03-20 15:36 ` [PATCH 03/83] net/avp: " Tyler Retzlaff
2024-03-20 15:36 ` [PATCH 04/83] net/axgbe: " Tyler Retzlaff
2024-03-20 15:36 ` [PATCH 05/83] net/bnxt: " Tyler Retzlaff
2024-03-20 15:36 ` [PATCH 06/83] net/bonding: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 07/83] net/cxgbe: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 08/83] net/e1000: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 09/83] net/ena: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 10/83] net/enic: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 11/83] net/fm10k: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 12/83] net/hinic: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 13/83] net/hns3: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 14/83] net/i40e: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 15/83] net/iavf: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 16/83] net/ice: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 17/83] net/igc: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 18/83] net/ionic: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 19/83] net/ixgbe: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 20/83] net/memif: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 21/83] net/mlx5: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 22/83] net/mlx4: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 23/83] net/mvpp2: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 24/83] net/netvsc: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 25/83] net/nfp: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 26/83] net/ngbe: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 27/83] net/octeontx: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 28/83] net/pfe: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 29/83] net/qede: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 30/83] net/softnic: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 31/83] net/tap: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 32/83] net/thunderx: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 33/83] net/txgbe: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 34/83] net/virtio: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 35/83] vdpa/mlx5: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 36/83] regex/cn9k: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 37/83] raw/ntb: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 38/83] ml/cnxk: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 39/83] mempool/cnxk: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 40/83] event/sw: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 41/83] event/skeleton: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 42/83] event/opdl: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 43/83] event/octeontx: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 44/83] event/dsw: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 45/83] event/dlb2: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 46/83] event/cnxk: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 47/83] dma/skeleton: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 48/83] dma/ioat: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 49/83] dma/idxd: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 50/83] crypto/uadk: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 51/83] crypto/scheduler: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 52/83] crypto/qat: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 53/83] crypto/openssl: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 54/83] crypto/octeontx: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 55/83] crypto/null: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 56/83] crypto/mvsam: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 57/83] crypto/mlx5: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 58/83] crypto/ipsec_mb: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 59/83] crypto/cnxk: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 60/83] crypto/ccp: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 61/83] crypto/caam_jr: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 62/83] crypto/bcmfs: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 63/83] crypto/armv8: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 64/83] compress/zlib: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 65/83] compress/qat: " Tyler Retzlaff
2024-03-20 15:37 ` [PATCH 66/83] compress/octeontx: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 67/83] compress/nitrox: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 68/83] compress/isal: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 69/83] common/qat: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 70/83] common/mlx5: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 71/83] common/idpf: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 72/83] common/cpt: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 73/83] bus/fslmc: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 74/83] baseband/turbo_sw: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 75/83] baseband/null: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 76/83] app/test: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 77/83] app/test-pipeline: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 78/83] app/test-mldev: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 79/83] app/test-flow-perf: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 80/83] app/test-eventdev: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 81/83] app/pdump: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 82/83] app/graph: " Tyler Retzlaff
2024-03-20 15:38 ` [PATCH 83/83] bus/dpaa: " Tyler Retzlaff
2024-03-20 15:50 ` [PATCH 00/83] " Bruce Richardson
2024-03-20 16:00 ` David Marchand
2024-03-20 17:40 ` Morten Brørup
2024-03-20 17:41 ` David Marchand
2024-03-20 19:12 ` Tyler Retzlaff [this message]
2024-04-02 17:56 ` Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 01/83] examples: " Tyler Retzlaff
2024-04-17 6:21 ` [EXTERNAL] " Akhil Goyal
2024-04-15 20:03 ` [PATCH v2 02/83] net/ark: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 03/83] net/avp: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 04/83] net/axgbe: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 05/83] net/bnxt: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 06/83] net/bonding: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 07/83] net/cxgbe: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 08/83] net/e1000: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 09/83] net/ena: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 10/83] net/enic: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 11/83] net/fm10k: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 12/83] net/hinic: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 13/83] net/hns3: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 14/83] net/i40e: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 15/83] net/iavf: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 16/83] net/ice: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 17/83] net/igc: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 18/83] net/ionic: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 19/83] net/ixgbe: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 20/83] net/memif: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 21/83] net/mlx5: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 22/83] net/mlx4: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 23/83] net/mvpp2: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 24/83] net/netvsc: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 25/83] net/nfp: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 26/83] net/ngbe: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 27/83] net/octeontx: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 28/83] net/pfe: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 29/83] net/qede: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 30/83] net/softnic: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 31/83] net/tap: " Tyler Retzlaff
2024-05-02 18:33 ` Stephen Hemminger
2024-04-15 20:03 ` [PATCH v2 32/83] net/thunderx: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 33/83] net/txgbe: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 34/83] net/virtio: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 35/83] vdpa/mlx5: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 36/83] regex/cn9k: " Tyler Retzlaff
2024-04-15 20:03 ` [PATCH v2 37/83] raw/ntb: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 38/83] ml/cnxk: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 39/83] mempool/cnxk: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 40/83] event/sw: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 41/83] event/skeleton: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 42/83] event/opdl: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 43/83] event/octeontx: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 44/83] event/dsw: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 45/83] event/dlb2: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 46/83] event/cnxk: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 47/83] dma/skeleton: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 48/83] dma/ioat: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 49/83] dma/idxd: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 50/83] crypto/uadk: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 51/83] crypto/scheduler: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 52/83] crypto/qat: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 53/83] crypto/openssl: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 54/83] crypto/octeontx: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 55/83] crypto/null: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 56/83] crypto/mvsam: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 57/83] crypto/mlx5: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 58/83] crypto/ipsec_mb: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 59/83] crypto/cnxk: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 60/83] crypto/ccp: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 61/83] crypto/caam_jr: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 62/83] crypto/bcmfs: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 63/83] crypto/armv8: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 64/83] compress/zlib: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 65/83] compress/qat: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 66/83] compress/octeontx: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 67/83] compress/nitrox: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 68/83] compress/isal: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 69/83] common/qat: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 70/83] common/mlx5: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 71/83] common/idpf: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 72/83] common/cpt: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 73/83] bus/fslmc: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 74/83] baseband/turbo_sw: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 75/83] baseband/null: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 76/83] app/test: " Tyler Retzlaff
2024-04-17 6:18 ` [EXTERNAL] " Akhil Goyal
2024-04-15 20:04 ` [PATCH v2 77/83] app/test-pipeline: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 78/83] app/test-mldev: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 79/83] app/test-flow-perf: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 80/83] app/test-eventdev: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 81/83] app/pdump: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 82/83] app/graph: " Tyler Retzlaff
2024-04-15 20:04 ` [PATCH v2 83/83] bus/dpaa: " Tyler Retzlaff
2024-04-19 15:05 ` [PATCH v2 00/83] " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320191220.GB12261@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).