From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Marek Pazdan <mpazdan@arista.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [PATCH] lib: add get/set link settings interface
Date: Wed, 3 Apr 2024 09:49:37 -0700 [thread overview]
Message-ID: <20240403164937.GA14169@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20240403134026.7037-1-mpazdan@arista.com>
On Wed, Apr 03, 2024 at 06:40:24AM -0700, Marek Pazdan wrote:
> There are link settings parameters available from PMD drivers level
> which are currently not exposed to the user via consistent interface.
> When interface is available for system level those information can
> be acquired with 'ethtool DEVNAME' (ioctl: ETHTOOL_SLINKSETTINGS/
> ETHTOOL_GLINKSETTINGS). There are use cases where
> physical interface is passthrough to dpdk driver and is not available
> from system level. Information provided by ioctl carries information
> useful for link auto negotiation settings among others.
>
> Signed-off-by: Marek Pazdan <mpazdan@arista.com>
> ---
> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
> index 147257d6a2..66aad925d0 100644
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -335,7 +335,7 @@ struct rte_eth_stats {
> __extension__
> struct __rte_aligned(8) rte_eth_link { /**< aligned for atomic64 read/write */
> uint32_t link_speed; /**< RTE_ETH_SPEED_NUM_ */
> - uint16_t link_duplex : 1; /**< RTE_ETH_LINK_[HALF/FULL]_DUPLEX */
> + uint16_t link_duplex : 2; /**< RTE_ETH_LINK_[HALF/FULL/UNKNOWN]_DUPLEX */
> uint16_t link_autoneg : 1; /**< RTE_ETH_LINK_[AUTONEG/FIXED] */
> uint16_t link_status : 1; /**< RTE_ETH_LINK_[DOWN/UP] */
> };
this breaks the abi. David does libabigail pick this up i wonder?
next prev parent reply other threads:[~2024-04-03 16:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 23:59 [PATCH] igc/ixgbe: " Marek Pazdan
2024-03-27 11:12 ` Bruce Richardson
2024-04-03 13:40 ` [PATCH] lib: " Marek Pazdan
2024-04-03 16:49 ` Tyler Retzlaff [this message]
2024-04-04 7:09 ` David Marchand
2024-04-05 0:55 ` Tyler Retzlaff
2024-04-05 0:56 ` Tyler Retzlaff
2024-04-05 8:58 ` David Marchand
2024-04-05 13:05 ` Dodji Seketeli
2024-04-03 13:59 ` Marek Pazdan
2024-04-03 14:48 ` Thomas Monjalon
2024-04-03 14:59 ` Marek Pazdan
2024-04-03 16:13 ` Thomas Monjalon
2024-04-03 17:23 ` Stephen Hemminger
2024-04-03 22:08 ` Marek Pazdan
2024-04-03 23:38 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403164937.GA14169@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=mpazdan@arista.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).